Port the application menu to qqc2
AcceptedPublic

Authored by astippich on Thu, Jun 20, 5:21 PM.

Details

Reviewers
mgallien
ngraham
Summary

Move to an item-based qqc2 implementation.
The menu is the last blocker for a full qqc2 Elisa!

This must not land until the corresponding patch
for the qqc2 desktop style is landed released

BUG: 405144

Depends on D21944
Depends on D22011

Test Plan

menu works as before

Diff Detail

Repository
R255 Elisa
Branch
qqc2_menu
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13404
Build 13422: arc lint + arc unit
astippich requested review of this revision.Thu, Jun 20, 5:21 PM
astippich created this revision.
astippich added a comment.EditedThu, Jun 20, 5:22 PM

qqc1

qqc2, with patch for desktop style

astippich edited the summary of this revision. (Show Details)Thu, Jun 20, 5:23 PM

What is the reference of the patch for the desktop style ?

ngraham accepted this revision.Fri, Jun 28, 2:27 PM
ngraham edited the summary of this revision. (Show Details)

@mgallien QQC2 can be styled in multiple ways; the screenshot is just showing the desktop (aka Breeze) style. LGTM in conjunction with D21944.

This revision is now accepted and ready to land.Fri, Jun 28, 2:29 PM
mgallien accepted this revision.Fri, Jun 28, 2:57 PM

@mgallien QQC2 can be styled in multiple ways; the screenshot is just showing the desktop (aka Breeze) style. LGTM in conjunction with D21944.

Sure

Though since D21944 is in a framework, perhaps once it lands, we should increase Elisa's frameworks dependency version here, or else the menus will look ugly.

Though since D21944 is in a framework, perhaps once it lands, we should increase Elisa's frameworks dependency version here, or else the menus will look ugly.

Yes but I am pretty sure @astippich will do it like he did recently.

astippich updated this revision to Diff 60831.Sat, Jun 29, 10:11 AM
  • raise frameworks requirement

I will commit once the binary factory is on 5.60

I will commit once the binary factory is on 5.60

Sounds good, thanks