Avoid multiple lookups of keys in the metadata map.
Instead, iterate over it and add it to the track.
Saves about 5% in the benchmark.
Depends on D22590
Details
Details
- Reviewers
mgallien ngraham - Commits
- R255:cd4c54c9ba11: Improve metadata scanning a bit
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Huh.
$ arc patch D22591 Already on 'master' Your branch is up to date with 'origin/master'. Already up to date. error: branch 'arcpatch-D22591' not found. INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D22591. Branch name arcpatch-D22439 already exists; trying a new name. Created and checked out branch arcpatch-D22439_1. Checking patch src/filescanner.h... Checking patch src/filescanner.cpp... Checking patch src/abstractfile/abstractfilelisting.cpp... Applied patch src/filescanner.h cleanly. Applied patch src/filescanner.cpp cleanly. Applied patch src/abstractfile/abstractfilelisting.cpp cleanly. Cherry Pick Failed! Exception Command failed with error #1! COMMAND git cherry-pick 'arcpatch-D22439_1' STDOUT (empty) STDERR error: could not apply a332dbb... Consolidate cover scanning into file scanner hint: after resolving the conflicts, mark the corrected paths hint: with 'git add <paths>' or 'git rm <paths>' hint: and commit the result with 'git commit' (Run with `--trace` for a full exception trace.)
Comment Actions
probably arcanist trying to apply the already merged dependent revision, I've rebased