Feed Advanced Search

Today

ngraham accepted D23223: Remove all remnants of outdated notification system.
Sun, Aug 18, 1:14 AM · Elisa

Yesterday

mgallien accepted D23223: Remove all remnants of outdated notification system.

Let's go. I have not enough time for a proper review but a big +1

Sat, Aug 17, 4:40 PM · Elisa
astippich requested review of D23223: Remove all remnants of outdated notification system.
Sat, Aug 17, 3:57 PM · Elisa
astippich closed D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.
Sat, Aug 17, 1:42 PM · Elisa
astippich accepted D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.

Great, thanks again

Sat, Aug 17, 1:41 PM · Elisa
mykolak added a comment to D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.

Thanks a lot!
There is some added space in the all tracks view between the first and the second line, which imho is a little too much. Using elisaTheme.layoutVerticalMargin / 2 for the trackDelegateHeight works for me here, could please try that?

Sat, Aug 17, 12:45 PM · Elisa
astippich updated the diff for D22772: Rework the mediaplayercontrol.
  • rebase
Sat, Aug 17, 9:51 AM · Elisa
astippich updated the diff for D22771: Add previous and next tracks to mediaplaylist.
  • rebase
Sat, Aug 17, 9:50 AM · Elisa
astippich added a comment to D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.

Thanks a lot!
There is some added space in the all tracks view between the first and the second line, which imho is a little too much. Using elisaTheme.layoutVerticalMargin / 2 for the trackDelegateHeight works for me here, could please try that?

Sat, Aug 17, 9:33 AM · Elisa
astippich closed T7570: Investigate bugs where busy indicator spins forever as Resolved.

If you would like to start contributing, you may have a look at the Junior Jobs column of the tasks or try to fix some bugs at https://bugs.kde.org/buglist.cgi?component=general&list_id=1655384&product=elisa&resolution=---

Sat, Aug 17, 9:20 AM · Elisa
sayakbiswas added a comment to T7570: Investigate bugs where busy indicator spins forever.

Okay thanks. No, I haven't faced these issues.

Sat, Aug 17, 4:24 AM · Elisa

Fri, Aug 16

mykolak updated the summary of D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.
Fri, Aug 16, 4:46 PM · Elisa
mykolak requested review of D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.
Fri, Aug 16, 4:43 PM · Elisa

Thu, Aug 15

mgallien added a comment to T7570: Investigate bugs where busy indicator spins forever.

Do you experience any problems yourself? Judging from the bug reports, the bugs have been fixed and this task should have been closed.
@mgallien are all bugs fixed?

Thu, Aug 15, 7:24 PM · Elisa
astippich added a comment to T7570: Investigate bugs where busy indicator spins forever.

Do you experience any problems yourself? Judging from the bug reports, the bugs have been fixed and this task should have been closed.
@mgallien are all bugs fixed?

Thu, Aug 15, 6:46 PM · Elisa
astippich updated the diff for D22770: Rework shuffle handling.
  • rebase
Thu, Aug 15, 6:44 PM · Elisa
astippich updated the diff for D22769: Make MediaPlayList responsible for remaining tracks.
  • rebase on master
Thu, Aug 15, 6:43 PM · Elisa
mykolak added a comment to D23132: Use Qt's highDPI scaling.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Is that a regression? Since I cannot test this, are you able to provide a fix? The issue may be located at
https://phabricator.kde.org/source/elisa/browse/master/src/qml/GridBrowserView.qml$127

Thu, Aug 15, 11:32 AM · Elisa
sayakbiswas added a comment to T7570: Investigate bugs where busy indicator spins forever.

Is anyone working on this? If not I'd like to help out with this.

Thu, Aug 15, 6:13 AM · Elisa

Wed, Aug 14

mykolak added a comment to D23132: Use Qt's highDPI scaling.

If you're adjusting the DPI using the Force Fonts DPI spinbox, you're doing something unsupported. This patch is for people who are (correctly) using the scaling slider on the KScreen KCM (i.e. the displays page in System Settings).

Wed, Aug 14, 8:01 PM · Elisa
astippich closed T7530: High DPI support as Resolved by committing R255:3710916442cb: Use Qt's highDPI scaling.
Wed, Aug 14, 6:28 PM · Elisa
astippich closed D23132: Use Qt's highDPI scaling.
Wed, Aug 14, 6:28 PM · Elisa
ngraham added a comment to D23132: Use Qt's highDPI scaling.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Wed, Aug 14, 4:17 PM · Elisa
astippich added a comment to D23132: Use Qt's highDPI scaling.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Wed, Aug 14, 4:04 PM · Elisa
mykolak added a comment to D23132: Use Qt's highDPI scaling.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Wed, Aug 14, 2:22 PM · Elisa
mgallien accepted D23132: Use Qt's highDPI scaling.

Really nice. Thank you

Wed, Aug 14, 7:12 AM · Elisa

Tue, Aug 13

ngraham accepted D23132: Use Qt's highDPI scaling.
Tue, Aug 13, 8:49 PM · Elisa
ngraham updated the summary of D23132: Use Qt's highDPI scaling.
Tue, Aug 13, 8:49 PM · Elisa
astippich updated the diff for D22769: Make MediaPlayList responsible for remaining tracks.
  • fix code style again
Tue, Aug 13, 6:59 PM · Elisa
astippich moved T7530: High DPI support from Backlog to In Progress on the Elisa board.
Tue, Aug 13, 6:57 PM · Elisa
astippich closed D21943: Port the application menu to qqc2.
Tue, Aug 13, 6:55 PM · Elisa
astippich updated the diff for D22769: Make MediaPlayList responsible for remaining tracks.
  • fix code style and unrelated changes
  • fix remaining tracks label
Tue, Aug 13, 6:47 PM · Elisa
astippich added a comment to D22769: Make MediaPlayList responsible for remaining tracks.

I don't want to remove ManageHeaderBar, on the contrary. This is a simplification and cleanup in order to easily extend it in the future after D22771, which is the goal of this whole series.
While working on it, I found that the ManageHeaderBar is needlessly entangled to the MediaPlayList by connecting to all of those signals, but which are mostly ignored. This is just because of the remaining tracks, for which the MediaPlayList is the correct place to retrieve the information.
By only connecting to the currentTrackChanged signal, the rest can be implemented much more easily. D22771 is working towards T7674

Tue, Aug 13, 6:41 PM · Elisa
astippich added a task to D23132: Use Qt's highDPI scaling: T7530: High DPI support.
Tue, Aug 13, 6:41 PM · Elisa
astippich added a revision to T7530: High DPI support: D23132: Use Qt's highDPI scaling.
Tue, Aug 13, 6:41 PM · Elisa
astippich closed T7576: port to controls2 as Resolved.
Tue, Aug 13, 6:38 PM · Elisa
astippich added a comment to D23132: Use Qt's highDPI scaling.

Please note that I cannot test this myself due to lack of a high DPI monitor

Tue, Aug 13, 6:37 PM · Elisa
astippich requested review of D23132: Use Qt's highDPI scaling.
Tue, Aug 13, 6:37 PM · Elisa
mgallien added a comment to D22769: Make MediaPlayList responsible for remaining tracks.

I forgot to say that the very big reduction in line count is really good. Thanks for that

Tue, Aug 13, 5:45 AM · Elisa
mgallien added a comment to D22769: Make MediaPlayList responsible for remaining tracks.

Could you please add a general overview of what is the goal of this change ?

Tue, Aug 13, 5:24 AM · Elisa

Thu, Aug 8

astippich added a comment to D22772: Rework the mediaplayercontrol.

Thanks. Just wanted to make sure that it does not fall through

Thu, Aug 8, 10:14 AM · Elisa
mgallien added a comment to D22772: Rework the mediaplayercontrol.

friendly ping @mgallien for the series

Thu, Aug 8, 8:13 AM · Elisa
astippich added a comment to D22772: Rework the mediaplayercontrol.

friendly ping @mgallien for the series

Thu, Aug 8, 7:55 AM · Elisa

Sat, Aug 3

astippich updated the task description for T8176: explore using Kirigami.
Sat, Aug 3, 6:33 PM · Elisa
astippich placed T6293: Fix HeaderBar for missing animations up for grabs.
Sat, Aug 3, 6:33 PM · Elisa
astippich updated the diff for D22772: Rework the mediaplayercontrol.
  • further simplify
Sat, Aug 3, 2:54 PM · Elisa
astippich closed D22781: Fix setup of search shortcut.
Sat, Aug 3, 7:57 AM · Elisa

Fri, Aug 2

ngraham added a comment to D22772: Rework the mediaplayercontrol.

Everything works and looks sane enough to me, but I'm not super familiar with all of this so I'm going to leave the review to @mgallien if you don't mind. :)

Fri, Aug 2, 9:23 PM · Elisa
ngraham added a dependent revision for D22781: Fix setup of search shortcut: D22761: Use Kirigami.SearchField.
Fri, Aug 2, 12:03 AM · Elisa
ngraham accepted D22781: Fix setup of search shortcut.

Very nice! I learned about StateChangeScript, too. Seems handy.

Fri, Aug 2, 12:02 AM · Elisa

Sun, Jul 28

ndavis added a comment to D12992: New elisa icon.

I think we are trying hard to accommodate and the elements are not lending themselves to turn them into an E with some musical tones. I reviewed a few music sheets looking for commonalities. I feel also that the icon is busy, it is trying really hard to tell you that this app is about music. I feel we can simplify and provide other ideas.

Here is a proposal. Not final. I welcome feedback. The idea here is to show soundwaves instead.

The colors must match to HIG? I don't understand why KDE Applications have a logos in different styles. We do not have complete unify KDE style.

Sun, Jul 28, 10:34 AM · Elisa, Frameworks
KonqiDragon added a comment to D12992: New elisa icon.

I think we are trying hard to accommodate and the elements are not lending themselves to turn them into an E with some musical tones. I reviewed a few music sheets looking for commonalities. I feel also that the icon is busy, it is trying really hard to tell you that this app is about music. I feel we can simplify and provide other ideas.

Here is a proposal. Not final. I welcome feedback. The idea here is to show soundwaves instead.

Sun, Jul 28, 9:53 AM · Elisa, Frameworks
ognarb accepted D22781: Fix setup of search shortcut.

The search bar is now working perfectly with the new version of my patch. 🎉

Sun, Jul 28, 9:41 AM · Elisa
astippich added a comment to D22781: Fix setup of search shortcut.

It's amazing how you notice these little things :) thanks!

Sun, Jul 28, 9:12 AM · Elisa
astippich updated the diff for D22781: Fix setup of search shortcut.
  • force focus upon entering expandend state
Sun, Jul 28, 9:11 AM · Elisa

Sat, Jul 27

ngraham requested changes to D22781: Fix setup of search shortcut.

This fixes the potential crash issue (yikes) and the need to hit the shortcut multiple times, but now the search field no longer automatically receives focus when that action is triggered and it becomes visible.

Sat, Jul 27, 4:02 PM · Elisa
astippich requested review of D22781: Fix setup of search shortcut.
Sat, Jul 27, 3:51 PM · Elisa
astippich triaged T7597: Add a progress bar under the current track in playlist as Wishlist priority.
Sat, Jul 27, 11:59 AM · Elisa
astippich moved T7576: port to controls2 from Backlog to In Progress on the Elisa board.
Sat, Jul 27, 11:57 AM · Elisa
astippich added a dependent revision for D22771: Add previous and next tracks to mediaplaylist: D22772: Rework the mediaplayercontrol.
Sat, Jul 27, 8:20 AM · Elisa
astippich added a dependency for D22772: Rework the mediaplayercontrol: D22771: Add previous and next tracks to mediaplaylist.
Sat, Jul 27, 8:20 AM · Elisa
astippich added a reviewer for D22771: Add previous and next tracks to mediaplaylist: mgallien.
Sat, Jul 27, 8:19 AM · Elisa
astippich added a reviewer for D22771: Add previous and next tracks to mediaplaylist: ngraham.
Sat, Jul 27, 8:19 AM · Elisa
astippich requested review of D22772: Rework the mediaplayercontrol.
Sat, Jul 27, 8:18 AM · Elisa
astippich added a project to D22771: Add previous and next tracks to mediaplaylist: Elisa.
Sat, Jul 27, 8:15 AM · Elisa
astippich added a dependent revision for D22770: Rework shuffle handling: D22771: Add previous and next tracks to mediaplaylist.
Sat, Jul 27, 8:15 AM · Elisa
astippich updated the test plan for D22770: Rework shuffle handling.
Sat, Jul 27, 8:12 AM · Elisa
astippich requested review of D22770: Rework shuffle handling.
Sat, Jul 27, 8:11 AM · Elisa
astippich added a dependent revision for D22769: Make MediaPlayList responsible for remaining tracks: D22770: Rework shuffle handling.
Sat, Jul 27, 8:11 AM · Elisa
astippich requested review of D22769: Make MediaPlayList responsible for remaining tracks.
Sat, Jul 27, 8:08 AM · Elisa

Thu, Jul 25

astippich created T11281: year browser.
Thu, Jul 25, 7:23 PM · Elisa
astippich renamed T7883: genre browser from year and genre browser to genre browser.
Thu, Jul 25, 7:22 PM · Elisa
astippich added a comment to T6293: Fix HeaderBar for missing animations.

Is anybody working on this?

Thu, Jul 25, 7:21 PM · Elisa
astippich closed T7884: file browser as Resolved.
Thu, Jul 25, 7:18 PM · Elisa
astippich moved T7884: file browser from Backlog to Done on the Elisa board.
Thu, Jul 25, 7:18 PM · Elisa
astippich moved T8176: explore using Kirigami from Backlog to Junior Jobs on the Elisa board.
Thu, Jul 25, 7:17 PM · Elisa
astippich updated the task description for T8176: explore using Kirigami.
Thu, Jul 25, 7:17 PM · Elisa
astippich closed D22591: Improve metadata scanning a bit.
Thu, Jul 25, 4:34 PM · Elisa
astippich closed D22741: bump Qt version to 5.11 and remove unrequired code.
Thu, Jul 25, 4:33 PM · Elisa
ngraham accepted D22741: bump Qt version to 5.11 and remove unrequired code.

Given that we're already depending on something newer than the 5.9 Qt LTS version, I don't see the harm in this, especially if it allows us to clean some things up.

Thu, Jul 25, 4:28 PM · Elisa
ngraham accepted D22591: Improve metadata scanning a bit.

Great work!

Thu, Jul 25, 4:26 PM · Elisa
astippich requested review of D22741: bump Qt version to 5.11 and remove unrequired code.
Thu, Jul 25, 4:23 PM · Elisa
astippich added a comment to D22591: Improve metadata scanning a bit.

probably arcanist trying to apply the already merged dependent revision, I've rebased

Thu, Jul 25, 3:52 PM · Elisa
astippich updated the diff for D22591: Improve metadata scanning a bit.
  • rebase
Thu, Jul 25, 3:50 PM · Elisa

Wed, Jul 24

ngraham added a comment to D22591: Improve metadata scanning a bit.
$ arc patch D22591
Already on 'master'
Your branch is up to date with 'origin/master'.
Already up to date.
error: branch 'arcpatch-D22591' not found.
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D22591.
Branch name arcpatch-D22439 already exists; trying a new name.
Created and checked out branch arcpatch-D22439_1.
Checking patch src/filescanner.h...
Checking patch src/filescanner.cpp...
Checking patch src/abstractfile/abstractfilelisting.cpp...
Applied patch src/filescanner.h cleanly.
Applied patch src/filescanner.cpp cleanly.
Applied patch src/abstractfile/abstractfilelisting.cpp cleanly.
Wed, Jul 24, 10:41 PM · Elisa
astippich closed D22590: Test and benchmark file scanning.
Wed, Jul 24, 9:30 PM · Elisa
astippich closed D22442: Remove datatype.
Wed, Jul 24, 9:30 PM · Elisa
ngraham accepted D22590: Test and benchmark file scanning.
Wed, Jul 24, 7:42 PM · Elisa
ngraham accepted D22442: Remove datatype.
Wed, Jul 24, 6:32 PM · Elisa
astippich updated the diff for D22591: Improve metadata scanning a bit.
  • rebase
Wed, Jul 24, 4:23 PM · Elisa
astippich updated the diff for D22590: Test and benchmark file scanning.
  • rebase
Wed, Jul 24, 4:21 PM · Elisa
astippich updated the diff for D22442: Remove datatype.
  • rebase
Wed, Jul 24, 4:20 PM · Elisa
astippich closed D22441: Speed up search of album covers.
Wed, Jul 24, 4:20 PM · Elisa
astippich closed D22440: Test searching for album covers.
Wed, Jul 24, 4:15 PM · Elisa
astippich closed D22439: Consolidate cover scanning into file scanner.
Wed, Jul 24, 4:14 PM · Elisa
astippich closed D22454: Cleanup file browser implementation.
Wed, Jul 24, 4:14 PM · Elisa

Tue, Jul 23

ngraham added a comment to D22590: Test and benchmark file scanning.

Needs a rebase I think.

Tue, Jul 23, 7:14 PM · Elisa
ngraham accepted D22441: Speed up search of album covers.
Tue, Jul 23, 7:13 PM · Elisa
ngraham accepted D22454: Cleanup file browser implementation.
Tue, Jul 23, 7:11 PM · Elisa
ngraham accepted D22440: Test searching for album covers.
Tue, Jul 23, 6:55 PM · Elisa