Bump KDE Framework version to 5.57 for Kirigami 2.8
Depends on D22781
ngraham |
Elisa |
Bump KDE Framework version to 5.57 for Kirigami 2.8
Depends on D22781
Run.
No visual change:
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
+1 on the concept. Actual search field works fine too.
Using the Ctrl+F shortcut only works intermittently though. I seem to have to hit it three times before the search fiels appears or disappears. Maybe it's conflicting with the shortcut set on the action elsewhere in this file.
I probably broke it even more, but I get the same behavior using master, but I only need to hit two times to toggle the search bar. Could you please it confirm it?
Hmm, using an actual SearchField is semantically correct here. If it has bugs that make it not work for our use case here, we should fix them upstream in Kirigami rather than working around them by using a more basic roll-your-own component.
For example, perhaps we could add a public property that tells it to not set its own shortcut. Or maybe we could remove the shortcut on the action and connect the search row's visibility to the text field gaining focus?
Just thinking out loud here.
It was just a test, but even if we use the ActionTextField the bug is still present for me.
Use SearchField with focusSequcence: null
Use Kirigami 5.58
Tested with D22781 and it works.
Works great now, just needs one more little change:
src/qml/NavigationActionBar.qml | ||
---|---|---|
22 | The minimum version is 2.8, not 2.7 |