implement browsing with the genre tag
Description
Details
- Differential Revisions
- D12785: [WIP] introduce GenericDataModel and ModelDataCache to have a generic model
D12586: starts storing lyricists in their own table to prepare for more
D12568: starts storing composers in their own table to prepare for more
D12548: extend MusicAudioTrack constructor to include lyricist and update tests
D12532: use the same set of tracks for database automatic tests
D12537: extend MusicAudioTrack constructor to allow adding the genre
D12540: extend MusicAudioTrack constructor to include composer and update tests
Related Objects
- Mentioned In
- R255:b5a0f6b32f95: starts storing lyricists in their own table to prepare for more
R255:b7c4412b166e: starts storing composers in their own table to prepare for more
R255:9a7d8e251737: extend MusicAudioTrack constructor to include lyricist and update tests
R255:ed1dcc554d9c: extend MusicAudioTrack constructor to include composer and update tests
R255:4e0455400955: extend MusicAudioTrack constructor to include composer and update tests
R255:3c7a7eedaf90: extend MusicAudioTrack constructor to allow adding the genre
R255:358202f9c1f0: use the same set of tracks for database automatic tests
@astippich , @ngraham are you able to test and provide me feedback before Saturday. This is more or less finished and I would like to push it in master before the feature freeze.
You can test the code from the genericModel branch in Elisa repository.
I just gave it a quick try, it does not really seem to work.
-the genre is using the artist icon for the delegates
-clicking a genre shows an empty page
Unfortunately, I won't be able to provide more feedback since I won't have access to my development computer starting tomorrow
Gave this a quick try:
- I have lots of empty genres, but I do have some that have some artists (but not all that should be in that genre)
- The first time I tried it the browse button didn't work for artists, but after going back and forth (and re building) it started working and now I can browse, enqueue and play at any level.
- It feels a bit slower that the rest of the views. At least going genre->artist
- Play and enqueue from inside a genre work, but not when doing it from the icon in the list.
Thanks for the feedback so far. I have fixed some problems. One of them was a wrong size of genre metadata in database. It requires to remove it and index your music again.
I've been having some trouble getting Elisa to run after compilation (qml errors), but I'll try to sort them out and test this. Thanks so much for your hard work getting it done!
Tried this again from Master after nuking my DB. I get more genres (I think) but they are all empty and if I try to play them I get an empty playlist.