genre browser
Closed, ResolvedPublic

Description

implement browsing with the genre tag

astippich created this task.Feb 4 2018, 6:59 PM
astippich triaged this task as Normal priority.
mgallien moved this task from Backlog to In Progress on the Elisa board.Apr 23 2018, 9:05 PM
mgallien raised the priority of this task from Normal to High.
mgallien claimed this task.
mgallien added a subscriber: ngraham.EditedMay 31 2018, 8:15 PM

@astippich , @ngraham are you able to test and provide me feedback before Saturday. This is more or less finished and I would like to push it in master before the feature freeze.
You can test the code from the genericModel branch in Elisa repository.

I just gave it a quick try, it does not really seem to work.
-the genre is using the artist icon for the delegates
-clicking a genre shows an empty page

Unfortunately, I won't be able to provide more feedback since I won't have access to my development computer starting tomorrow

januz added a subscriber: januz.May 31 2018, 11:02 PM

Gave this a quick try:

  • I have lots of empty genres, but I do have some that have some artists (but not all that should be in that genre)
  • The first time I tried it the browse button didn't work for artists, but after going back and forth (and re building) it started working and now I can browse, enqueue and play at any level.
  • It feels a bit slower that the rest of the views. At least going genre->artist
  • Play and enqueue from inside a genre work, but not when doing it from the icon in the list.

Thanks for the feedback so far. I have fixed some problems. One of them was a wrong size of genre metadata in database. It requires to remove it and index your music again.

I've been having some trouble getting Elisa to run after compilation (qml errors), but I'll try to sort them out and test this. Thanks so much for your hard work getting it done!

januz added a comment.EditedJun 3 2018, 12:34 AM

Tried this again from Master after nuking my DB. I get more genres (I think) but they are all empty and if I try to play them I get an empty playlist.

mgallien moved this task from In Progress to Backlog on the Elisa board.Jun 4 2018, 5:22 AM
mgallien raised the priority of this task from High to Needs Triage.
astippich renamed this task from year and genre browser to genre browser.Jul 25 2019, 7:22 PM
astippich closed this task as Resolved.
astippich updated the task description. (Show Details)