mykolak (Mykola Krachkovsky)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 12 2018, 12:24 PM (79 w, 6 d)
Availability
Available

Recent Activity

Sat, Aug 17

mykolak added a comment to D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.

Thanks a lot!
There is some added space in the all tracks view between the first and the second line, which imho is a little too much. Using elisaTheme.layoutVerticalMargin / 2 for the trackDelegateHeight works for me here, could please try that?

Sat, Aug 17, 12:45 PM · Elisa

Fri, Aug 16

mykolak updated the summary of D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.
Fri, Aug 16, 4:46 PM · Elisa
mykolak requested review of D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.
Fri, Aug 16, 4:43 PM · Elisa

Thu, Aug 15

mykolak added a comment to D23132: Use Qt's highDPI scaling.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Is that a regression? Since I cannot test this, are you able to provide a fix? The issue may be located at
https://phabricator.kde.org/source/elisa/browse/master/src/qml/GridBrowserView.qml$127

Thu, Aug 15, 11:32 AM · Elisa

Wed, Aug 14

mykolak added a comment to D23132: Use Qt's highDPI scaling.

If you're adjusting the DPI using the Force Fonts DPI spinbox, you're doing something unsupported. This patch is for people who are (correctly) using the scaling slider on the KScreen KCM (i.e. the displays page in System Settings).

Wed, Aug 14, 8:01 PM · Elisa
mykolak added a comment to D23132: Use Qt's highDPI scaling.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Wed, Aug 14, 2:22 PM · Elisa

May 24 2018

mykolak added a comment to D12889: Remove multiple usage of SQL parameter.

Shall I land this for you?

May 24 2018, 3:30 PM · Elisa

May 23 2018

mykolak added a comment to D12889: Remove multiple usage of SQL parameter.

Shall I land this for you?

May 23 2018, 2:34 PM · Elisa

May 15 2018

mykolak requested review of D12889: Remove multiple usage of SQL parameter.
May 15 2018, 6:54 AM · Elisa
mykolak added a watcher for Elisa: mykolak.
May 15 2018, 6:25 AM

Feb 22 2018

mykolak added a comment to D10460: To make theme size depend on DPI.

@astippich sure: Mykola Krachkovsky <w01dnick@gmail.com>

Feb 22 2018, 8:30 AM · Elisa

Feb 17 2018

mykolak added a comment to D10460: To make theme size depend on DPI.
In D10460#207155, @asn wrote:

Are you on IRC or Matrix?

Feb 17 2018, 10:47 AM · Elisa

Feb 15 2018

mykolak added a comment to D10460: To make theme size depend on DPI.
In D10460#207043, @asn wrote:

The logout screen (ctrl+alt+del) has exactly the same issues as I have in elisa.

I think the interface is fine, even with your changes applied on top of mine everything seems to scal correctly, just the fonts look horrible.

Feb 15 2018, 2:30 PM · Elisa
mykolak added a comment to D10460: To make theme size depend on DPI.

As far as I can see, plasma doing almost the same:
https://phabricator.kde.org/source/plasma-framework/browse/master/src/declarativeimports/core/units.cpp;c05b1bdec7901293ad0ad9c06b352a89fe33c3b5$233
https://phabricator.kde.org/source/plasma-workspace/browse/master/applets/digital-clock/package/contents/ui/CalendarView.qml;c2dc1fae5d0f38c9606e9bcd33177d079418835d$245

Feb 15 2018, 1:50 PM · Elisa
mykolak added a comment to D10460: To make theme size depend on DPI.
In D10460#206625, @asn wrote:

I have a HiDPI Screen and the interface looks fine for me. The problem I have is that the fonts are rendered incorrectly. I haven't found any solution for that.

My current patch:
https://xor.cryptomilk.org/elisa/elisa-hidpi.patch.txt

Which still results in:
https://xor.cryptomilk.org/elisa/elisa.png

It looks like you have fractional QT_SCALE_FACTOR it looks similar in my case, when dpi dropped to 96 and QT_SCALE_FACTOR=1.5. As fractional scaling isn't promised to be fine, I'm trying to fix case when scaling set to 1 (or other integral value) and dpi is not 96. In my case 144.

Feb 15 2018, 12:42 PM · Elisa

Feb 13 2018

mykolak added a comment to D10460: To make theme size depend on DPI.

Thanks for your work.

Happy to help :)

Feb 13 2018, 9:26 AM · Elisa

Feb 12 2018

mykolak requested review of D10460: To make theme size depend on DPI.
Feb 12 2018, 12:33 PM · Elisa