In D23206#513301, @astippich wrote:

Thanks a lot!
There is some added space in the all tracks view between the first and the second line, which imho is a little too much. Using elisaTheme.layoutVerticalMargin / 2 for the trackDelegateHeight works for me here, could please try that?

In D23132#511902, @astippich wrote:

In D23132#511825, @mykolak wrote:

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Is that a regression? Since I cannot test this, are you able to provide a fix? The issue may be located at
https://phabricator.kde.org/source/elisa/browse/master/src/qml/GridBrowserView.qml$127

In D23132#511926, @ngraham wrote:

If you're adjusting the DPI using the Force Fonts DPI spinbox, you're doing something unsupported. This patch is for people who are (correctly) using the scaling slider on the KScreen KCM (i.e. the displays page in System Settings).

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

In D12889#265937, @astippich wrote:

Shall I land this for you?

In D12889#265937, @astippich wrote:

Shall I land this for you?

@astippich sure: Mykola Krachkovsky <w01dnick@gmail.com>

In D10460#207155, @asn wrote:

Are you on IRC or Matrix?

In D10460#207043, @asn wrote:

The logout screen (ctrl+alt+del) has exactly the same issues as I have in elisa.

I think the interface is fine, even with your changes applied on top of mine everything seems to scal correctly, just the fonts look horrible.

As far as I can see, plasma doing almost the same:
https://phabricator.kde.org/source/plasma-framework/browse/master/src/declarativeimports/core/units.cpp;c05b1bdec7901293ad0ad9c06b352a89fe33c3b5$233
https://phabricator.kde.org/source/plasma-workspace/browse/master/applets/digital-clock/package/contents/ui/CalendarView.qml;c2dc1fae5d0f38c9606e9bcd33177d079418835d$245

In D10460#206625, @asn wrote:

I have a HiDPI Screen and the interface looks fine for me. The problem I have is that the fonts are rendered incorrectly. I haven't found any solution for that.

My current patch:
https://xor.cryptomilk.org/elisa/elisa-hidpi.patch.txt

Which still results in:
https://xor.cryptomilk.org/elisa/elisa.png

It looks like you have fractional QT_SCALE_FACTOR it looks similar in my case, when dpi dropped to 96 and QT_SCALE_FACTOR=1.5. As fractional scaling isn't promised to be fine, I'm trying to fix case when scaling set to 1 (or other integral value) and dpi is not 96. In my case 144.

Thanks for your work.

Happy to help :)