Rework shuffle handling
ClosedPublic

Authored by astippich on Jul 27 2019, 8:11 AM.

Details

Summary

Remove deprecated usage of qrand().
Keep a list of the previous, current and next track
when in shuffle mode, to be used in a following patch.
Simplify calling skip and previousTracks

Depends on D22769

Test Plan

all tests pass

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Jul 27 2019, 8:11 AM
astippich created this revision.
astippich edited the summary of this revision. (Show Details)Jul 27 2019, 8:12 AM
astippich edited the test plan for this revision. (Show Details)

I am unable to get arc to properly download this review patch. I will be waiting for D22769 to land and a rebase. Sorry

src/mediaplaylist.cpp
1312

missing space

astippich updated this revision to Diff 64343.Thu, Aug 22, 6:16 PM
  • add space
  • rebase

this should now apply cleanly

mgallien accepted this revision.Mon, Aug 26, 5:26 AM

Thanks

This revision is now accepted and ready to land.Mon, Aug 26, 5:26 AM
This revision was automatically updated to reflect the committed changes.