Extend the GridBrowserDelegate and base the delegate
for file browsing on it.
Fix loading of playlist via file browser.
Cleanup unused methods and rename some roles.
Details
Details
- Reviewers
mgallien ngraham - Commits
- R255:2858e16fae76: Cleanup file browser implementation
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
$ (arcpatch-D22454) kb && elisa Total of 'trivial' dependency cycles detected & eliminated: 2 Building elisa from guessed_from_cmdline (1/1) Source update complete for elisa: Skipped Compiling... succeeded (after 28 seconds) Installing.. succeeded (after 0 seconds) <<< PACKAGES SUCCESSFULLY BUILT >>> elisa Removing 1 out of 23 old log directories... :-) Your logs are saved in /home/nate/kde/src/log/2019-07-14-03 QQmlApplicationEngine failed to load component qrc:/qml/ElisaMainWindow.qml:266 Type ContentView unavailable qrc:/qml/ContentView.qml:376 Type FileBrowserView unavailable qrc:/qml/FileBrowserView.qml:51 Cannot assign to non-existent property "onLoadPlayListFromUrl"
onLoadPlayListFromUrl is still used in src/qml/FileBrowserView.qml, but you've deleted it.
Comment Actions
Oops, my bad. Just one thing to change:
| src/qml/GridBrowserDelegate.qml | ||
|---|---|---|
| 160 | onClicked should do the same thing as Keys.onReturnPressed and Keys.onEnterPressed so they all have the same behavior. | |
| src/qml/GridBrowserDelegate.qml | ||
|---|---|---|
| 160 | good catch, that was stupid | |