Use Qt's highDPI scaling
ClosedPublic

Authored by astippich on Tue, Aug 13, 6:37 PM.

Details

Summary

Use Qt's internal scaling for HighDPI now that
we rely only on QQC2.
Closes T7530

Test Plan

HighDPI works

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Tue, Aug 13, 6:37 PM
astippich created this revision.

Please note that I cannot test this myself due to lack of a high DPI monitor

astippich edited the summary of this revision. (Show Details)Tue, Aug 13, 6:41 PM
ngraham accepted this revision.Tue, Aug 13, 8:49 PM
ngraham edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Tue, Aug 13, 8:49 PM
mgallien accepted this revision.Wed, Aug 14, 7:12 AM

Really nice. Thank you

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Is that a regression? Since I cannot test this, are you able to provide a fix? The issue may be located at
https://phabricator.kde.org/source/elisa/browse/master/src/qml/GridBrowserView.qml$127

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

If you're adjusting the DPI using the Force Fonts DPI spinbox, you're doing something unsupported. This patch is for people who are (correctly) using the scaling slider on the KScreen KCM (i.e. the displays page in System Settings).

This revision was automatically updated to reflect the committed changes.
mykolak added a comment.EditedWed, Aug 14, 8:01 PM

If you're adjusting the DPI using the Force Fonts DPI spinbox, you're doing something unsupported. This patch is for people who are (correctly) using the scaling slider on the KScreen KCM (i.e. the displays page in System Settings).

No, just my monitor has 144 DPI, no forcing, except X -dpi 144. The reason I'm using (old-style) Qt scaling set to 1 and DPI at 144 is this variant gives fine results. Setting Qt scaling to 1.5 leads to many visual artifacts in a lot of applications. And BTW, all other applications works fine with such setup.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Is that a regression? Since I cannot test this, are you able to provide a fix? The issue may be located at
https://phabricator.kde.org/source/elisa/browse/master/src/qml/GridBrowserView.qml$127

Yes, but it's not that bad, unlike QQC1 problems there is no any cut texts, I'll check that file.