VDGGroup
ActivePublic

Recent Activity

Today

ndavis added a comment to T11124: Unify highlight effect style.

Finally there is still the issue of the HighlightedText foreground color in the palette. It is chosen to have high contrast against the highligh (=focus) color background. This is why it is white in the default color scheme. You should not change this, if you do not want to break other widget themes, or break text selection. If you want to manually lighten the focus/highlight color, by adding some translucency, so that you do not have to change the text color, you must make sure to use the QPalette::Text or QPalette::WindowText role, rather than modifying the palette's HighlightedText role. For monochrome icons there is the extra complication that the QIcon::Selected state will by default use the HighlightedText role for its main color. So what you would then need is to use the QIcon::Normal state instead of ::Selected, everywhere you do not want this color change to happen.

Fri, Jul 19, 3:33 AM · VDG

Yesterday

The-Feren-OS-Dev added a comment to T11227: Loading Look and Feel.

-snip-
That means instead of the loading bar we should then just have the spinning indicator. While it may remove some detail in terms of how much a program has left to load, we can either move that into their window list item's progress bar ala Spectacle's timer or we could just take into account the fact that once it starts progressing it'll most likely be finished doing whatever it does on most of these applications anyway in a few seconds (therefore making having a progress bar redundant anyway).

The point of a longform loading screen is to be for things that may not complete in a few seconds like refreshing repositories on Discover's start (add distro repositories + repos for universal packages and there's probably a lot to do). Nothing kills user experience more than a dreaded nonstop loading screen with an indeterminate indicator. If loading must take a while, there should be effort to let users know how much time is left or how much is done versus how much there is to do.

Thu, Jul 18, 8:50 PM · VDG
cblack added a comment to T11227: Loading Look and Feel.

-snip-
That means instead of the loading bar we should then just have the spinning indicator. While it may remove some detail in terms of how much a program has left to load, we can either move that into their window list item's progress bar ala Spectacle's timer or we could just take into account the fact that once it starts progressing it'll most likely be finished doing whatever it does on most of these applications anyway in a few seconds (therefore making having a progress bar redundant anyway).

Thu, Jul 18, 7:56 PM · VDG
The-Feren-OS-Dev added a comment to T11227: Loading Look and Feel.

GNOME does something pretty nice: they draw a blank/white background with a monochrome desaturated version of the app's icon in the middle. It looks really classy IMO. We could do the same, maybe also with a monochrome desaturated indeterminate progress bar below the icon.

That's pretty much the long form loading that I described - mostly because that's what I drew most of my inspiration from.

The example I gave of what Discover could be is literally just a description of GNOME Software's start loading screen

Thu, Jul 18, 7:39 PM · VDG
felixernst added a comment to T11153: Unify sidebar appearance.

What about tabs on top? I'd say those should be used when they only change a part of the window and not the whole view (except in falkon of course),

Thu, Jul 18, 5:47 PM · VDG, Breeze

Wed, Jul 17

romangg added a comment to T11222: Reimagine output cloning.
More technical info:

Outputs may be in a cloned view because they share the same CRTC. Such outputs can only be driven in a cloned mode, here meaning same resolution and frame rate.

Wed, Jul 17, 10:25 PM · VDG, Plasma
cblack added a comment to T11227: Loading Look and Feel.

GNOME does something pretty nice: they draw a blank/white background with a monochrome desaturated version of the app's icon in the middle. It looks really classy IMO. We could do the same, maybe also with a monochrome desaturated indeterminate progress bar below the icon.

Wed, Jul 17, 5:07 PM · VDG
ngraham updated subscribers of T11222: Reimagine output cloning.
Wed, Jul 17, 4:14 PM · VDG, Plasma
ngraham added a comment to T11227: Loading Look and Feel.

GNOME does something pretty nice: they draw a blank/white background with a monochrome desaturated version of the app's icon in the middle. It looks really classy IMO. We could do the same, maybe also with a monochrome desaturated indeterminate progress bar below the icon.

Wed, Jul 17, 3:34 PM · VDG
romangg added a project to T11222: Reimagine output cloning: VDG.
Wed, Jul 17, 2:09 PM · VDG, Plasma
fabianr added a comment to T11227: Loading Look and Feel.

One probably needs to consider that progress indicators may be determinate or indeterminate.

Wed, Jul 17, 6:06 AM · VDG

Tue, Jul 16

lydia added a comment to T11227: Loading Look and Feel.

Ah ok. Thanks :)

Tue, Jul 16, 6:27 PM · VDG
cblack edited projects for T11227: Loading Look and Feel, added: VDG; removed Goal Setting 2019.
Tue, Jul 16, 6:18 PM · VDG
ngraham added a comment to T10891: Breeze theme evolution.
In T10891#191854, @mthw wrote:
  1. Use CSDs and fix text color on non-selected tabs (something I am trying to fix - but might be a bug in Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1461650)
Tue, Jul 16, 5:51 PM · VDG, Breeze
lavender updated the task description for T11052: Accent Colors, Color Ramps and other improvements to theming..
Tue, Jul 16, 3:51 PM · Plasma, VDG
mthw added a comment to T10891: Breeze theme evolution.

@ngraham I have been tracking this for a while but finally created an account to contribute some comments. As a newcomer to KDE from gnome-based desktops I am reliant on apps like firefox and thunderbird. The GTK Breeze theme has some minor usability issues with tabs in these apps. See these screenshots:

Firefox is decent with Breeze, but it is hard at quick glance to visually separate the active tab from the other tabs. There is a blue bar at the top, but better would be to darken the color of the inactive tabs. It would help to not be so disorienting. Note I am using "Firefox Containers" which is why all the blue lines are at the bottom of the tabs.

Thunderbird is harder to differentiate the tabs. There is no line at the bottom of inactive tabs so it is really hard to tell what is active and what isn't: again only the blue line at the top of the active tab lets you know that, but at quick glance it is hard to pick up.

Thanks for looking at things that will make Breeze the "go to theme" for cross-toolkit apps to give them the unified look that Linux deserves!

Tue, Jul 16, 8:42 AM · VDG, Breeze

Mon, Jul 15

niccolove added a comment to T11153: Unify sidebar appearance.

I would think we only need two different sidebar appearances for this: The one used in System Settings when there are many entries and D20908: RFC: Redesign QML applet configuration windows when there are few.

Mon, Jul 15, 9:47 PM · VDG, Breeze
niccolove added a parent task for T11153: Unify sidebar appearance: T11093: Consistency.
Mon, Jul 15, 9:28 PM · VDG, Breeze
niccolove added a parent task for T9126: Breeze scrollbar look-and-feel unification: T11093: Consistency.
Mon, Jul 15, 9:28 PM · VDG
cblack added a comment to T10891: Breeze theme evolution.

There's something I've noticed that's inconsistent between applications - how loading is represented. There's not really any consistency at all, excluding Kirigami applications.

Mon, Jul 15, 8:05 PM · VDG, Breeze
ngraham updated subscribers of T10891: Breeze theme evolution.

I sure hope so! Yeah, we're working on that particular issue too. @mthw may be interested in this!

Mon, Jul 15, 7:29 PM · VDG, Breeze
rikshaw added a comment to T10891: Breeze theme evolution.

@ngraham I have been tracking this for a while but finally created an account to contribute some comments. As a newcomer to KDE from gnome-based desktops I am reliant on apps like firefox and thunderbird. The GTK Breeze theme has some minor usability issues with tabs in these apps. See these screenshots:

Mon, Jul 15, 6:35 PM · VDG, Breeze
cullmann added a comment to D22059: Enlarge the find and replace add-on combo boxes.

Thanks for taking care of this!
Both to the submitter of the patch and all reviewers.

Mon, Jul 15, 4:55 PM · VDG, Kate
cullmann closed D22059: Enlarge the find and replace add-on combo boxes.
Mon, Jul 15, 4:54 PM · VDG, Kate
ngraham accepted D22059: Enlarge the find and replace add-on combo boxes.
In D22059#495675, @sars wrote:

@ngraham Unfortunately there is no way with UI files to dynamically modify the layout depending on the size of the container, so munging the layout in C++ is the best way I know so far :)

Mon, Jul 15, 4:41 PM · VDG, Kate
hpereiradacosta added a comment to T11124: Unify highlight effect style.

Can I change the selection background color and use the selection color for the background of highlights? Then the regular highlight color could be used mainly for line highlights and outlines.

Mon, Jul 15, 1:49 PM · VDG
ndavis added a comment to T11124: Unify highlight effect style.

Can I change the selection background color and use the selection color for the background of highlights? Then the regular highlight color could be used mainly for line highlights and outlines.

Mon, Jul 15, 1:45 PM · VDG
hpereiradacosta added a comment to T11124: Unify highlight effect style.

Thanks for the color overview. I'll avoid changing the highlighted text color in the colorscheme.

Personal opinion follows.

In my personal opinion, the current breeze widget style highlight model is fine as it is, internally consistent, and consistent with the breeze visual goal. It is simple (in particular in lists and menus), it minimizes the use of frames, and is also consistent with text selection (something on which you have no handle). I also note that it is quite trendy, when comparing e.g. to highlight model of many web-based applications (slack, github, etc.), or to the other widget styles shipped by Qt.
To ensure consistency with plasma, rather than modifying the complex beast that is the widget style highlight model, I would have changed the plasma model instead. Simpler, both implementation-wise and visually wise.
My two cents.

That's a fair point, but the current style does have rather poor contrast with light text. While dark text has significantly better contrast, I don't like the way it looks against Plasma Blue. The highlight color could be changed, which would be much easier than changing the highlight style, but that would affect everything that currently uses the highlight color, including icons.

Mon, Jul 15, 12:52 PM · VDG
ndavis added a comment to T11124: Unify highlight effect style.

Thanks for the color overview. I'll avoid changing the highlighted text color in the colorscheme.

Mon, Jul 15, 12:40 PM · VDG
hpereiradacosta added a comment to T11124: Unify highlight effect style.

Personal opinion follows.

Mon, Jul 15, 12:09 PM · VDG
hpereiradacosta added a comment to T11124: Unify highlight effect style.

Few words about colors (sorry if you know all about it already)

Mon, Jul 15, 12:01 PM · VDG
davidre added a comment to T11124: Unify highlight effect style.

Thanks, can you give me an example of an application where I can find this behavior? I can't find anything in the applications I have installed.

Some of the Buttons in Spectacle are Toolbuttons instead of Pushbuttons. Namely "Save" and "Copy to Clipboard"

Mon, Jul 15, 8:31 AM · VDG
sars accepted D22059: Enlarge the find and replace add-on combo boxes.

@ngraham Unfortunately there is no way with UI files to dynamically modify the layout depending on the size of the container, so munging the layout in C++ is the best way I know so far :)

Mon, Jul 15, 7:54 AM · VDG, Kate
ndavis added a comment to T11124: Unify highlight effect style.

...Which reminds me, these QStyle changes are going to need to be replicated in qqc2-desktop-style too. And maybe also Kirigami in some places.

Mon, Jul 15, 4:19 AM · VDG
ngraham added a comment to T11124: Unify highlight effect style.
  • For the record: toolbar buttons (or rather QToolButtons) can have focus too, when they are used outside of toolbars (and there are examples of such everywhere, for instance when you have an "open" button next to a text entry for selecting a file.

Thanks, can you give me an example of an application where I can find this behavior? I can't find anything in the applications I have installed.

Mon, Jul 15, 1:18 AM · VDG

Sun, Jul 14

ndavis added a comment to T11124: Unify highlight effect style.
  • For the record: toolbar buttons (or rather QToolButtons) can have focus too, when they are used outside of toolbars (and there are examples of such everywhere, for instance when you have an "open" button next to a text entry for selecting a file.
Sun, Jul 14, 10:05 PM · VDG
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Sun, Jul 14, 2:02 PM · VDG, Okular
hpereiradacosta added a comment to T11124: Unify highlight effect style.
  • For the record: toolbar buttons (or rather QToolButtons) can have focus too, when they are used outside of toolbars (and there are examples of such everywhere, for instance when you have an "open" button next to a text entry for selecting a file.

your enumeration did not mention

  • checkboxes and radiobuttons who also have hove/focus + the various selected states.
  • tabbar entries (hover, focus, selected)
  • toolboxes
Sun, Jul 14, 1:39 PM · VDG
ngraham added a comment to D22059: Enlarge the find and replace add-on combo boxes.

Hmm, munging the layout that's provided by the UI file in QWidgets code doesn't sit that well with me (especially grid layout code, which is already quite difficult to read). Is there no other way?

Sun, Jul 14, 12:38 PM · VDG, Kate
cullmann added a comment to D22059: Enlarge the find and replace add-on combo boxes.

:=) I see, I should have properly read the description.

Sun, Jul 14, 12:19 PM · VDG, Kate
mickaelbo added a comment to D22059: Enlarge the find and replace add-on combo boxes.

Ok. Note that the layout is still the one you currently use when toolview is at the bottom (when toolview.width >= toolview.height)

Sun, Jul 14, 12:15 PM · VDG, Kate
cullmann added a comment to D22059: Enlarge the find and replace add-on combo boxes.

Ok, I see, for the search stuff at the left/right, it makes sense, thought I normaly keep it at the bottom.

Sun, Jul 14, 12:11 PM · VDG, Kate
mickaelbo updated the diff for D22059: Enlarge the find and replace add-on combo boxes.

I agree about reverting the search.ui changes. I made these changes when trying the 2nd layout but they do not make any sense now. Fixed.
The double space was unintentional and it is fixed.

Sun, Jul 14, 12:10 PM · VDG, Kate
mickaelbo updated the test plan for D22059: Enlarge the find and replace add-on combo boxes.
Sun, Jul 14, 12:04 PM · VDG, Kate
ndavis added a comment to T10997: Improve check box design.
In T10997#191697, @mglb wrote:

I think the symbol is too small for dashed line:


I'll see how it works with a little larger check mark

Sun, Jul 14, 11:21 AM · VDG, Breeze
ngraham added a comment to T10997: Improve check box design.
In T10997#191697, @mglb wrote:

Will animations be OK?

Sun, Jul 14, 11:18 AM · VDG, Breeze
ndavis added a comment to T11124: Unify highlight effect style.

I need some help coming up with a consistent way of showing a distinct difference between mouse hover, keyboard focus and the sunken state. Here's what I know about how different widget types use these.

Sun, Jul 14, 11:07 AM · VDG
ognarb added a comment to T11179: Update wikis version and theme.

The new design looks great!
The dark mode is certainly a nice addition, but I feel the "Note" Box feels a bit out of place there with its dark text on a light green background. I think the box would look nicer in dark mode if you used the same color palette as inline notifications in Plasma with the Breeze Dark theme. I'll try to find a screenshot as I'm on mobile right now.

Sun, Jul 14, 9:00 AM · VDG, Websites, Documentation
ognarb added a comment to T11179: Update wikis version and theme.

Looks great overall!
I just want to nitpick that the top-right search bar doesn't align with the sidebar. Adding the class "mr-3" to the form and setting the .form-control width to 255px seems to have aligned them for me but that is maybe not the right solution.

Sun, Jul 14, 8:59 AM · VDG, Websites, Documentation

Sat, Jul 13

cullmann added a comment to D22059: Enlarge the find and replace add-on combo boxes.

I am a bit concerned about the height increase. As most people have 16:9/10 screens, screen height is always sparse.

Sat, Jul 13, 11:37 PM · VDG, Kate