"To reduce eye strain, Night Color makes the colors on the screen warmer at the time of your choosing"
Thanks, now the bug and the fix are very clear! LGTM!
Maybe this should be a critical notification? If it's your mouse or a device you're using to present with, that's not something you want to miss. :)
- Drop odd parentheses
Delete stray include.
Put the separator in the formlayout for more simplicity
Restore original import order for timings view now that we don't need layouts anymore
Put the labels back in a FormLayout to align the times, but don't align the formlayout
itself with the top one or else the whole thing is too far over to the left
This idea was to have a top-to-bottom flow. First you turn it on, then you select the activation mode, then you manipulate the controls specific to that mode (if applicable), then you see the times that result from those settings. I think it makes logical sense. If you have any suggestions for how to improve the presentation, I'm all ears. Also interested in VDG feedback.
Sorry, but I don't like how the text is "hanging in the air" and how it is jumping around when changing the setting.
I'm not sure how to reproduce the issue that this patch is fixing. Can you add more detail to the Test Plan section maybe?
Yes, the second one looks the best out of those for sure. FDO = "FreeDesktop.org", in this case referring to the FreeDesktop spec for icon naming. It ensures that icon themes work (at least tolerably).
Polish everything even more to ensure a consistent top-to-bottom workflow. To do this
I had to do a lot of refactoring that also has the side effect of making the UI a lot
My main problem is, the difficulty to control the size of the icon.
While it appears to be a general icon issue, I hope that I'm doing something wrong.
- Restore condition
- emit signals when setConnected
All right, you've convinced me. :)
How is it, though? It is an internal hint on some DBus method no user will ever see. Internally it's all things like notificationsInhibitedUntil, even the (public) DBus API says "Inhibited"
Yeah but this is a user-facing thing (well, sort of user-facing).
Improve begin/end strings again
Internally it uses "inhibited" for that everywhere