MouseArea.pressAndHold runs based on the synthesised left press event, I don't see anything in your code which would prevent a conflict there.
Same for any widget code that uses a current QTapAndHoldGesture
Is redshift -P -O fully backwards-compatible with older versions of redshift? If not, then this will just break everyone not using >=1.12.
I am not sure how the version scheme will work now that this plasmoid is officially part of KDE, but once this is merged the version should definitely be bumped as this is a critical issue preventing use of manual mode. See also: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910901
To be clear, I don't have a problem with your patch - and happily support it.
I didn't test this, but I wrote the code which will handle this and it works in other cases ;-)
My comment was to confirm that the commit does indeed what you intend it to do, according to the spec and code.
Effect is kdesystemsettings.desktop not being shown in any software center.
IIRC the objection was that making press-and-hold always mean right-click at the toolkit level could interfere with apps that want to re-implement the press-and-hold behavior for some other behavior. For example a lot of Android apps use press-and-hold to mean "make this list/view editable".
All right, hopefully the third time's the charm: D23328
You assume far too much competance on my part :)
I assume you also change the cmake install command in app/CMakeLists.txt in the final patch, though :)
No, we need exactly right click events. They are too important for many apps. For instance, how will we mark the cells in KMines without right click event? I backported my patch on 5.12 in order to replace native Qt version under Kubuntu and now I can successfully mark and unmark the cells.
And finally, it would be nice to display the text + progress indicator in the center of the view, not at the very top.
Also hide the placeholder icon while the progress indicator is visible so this doesn't happen:
Lose the BusyIndicator
@ngraham You used the "appdata.xml" file suffix here. I noticed yesterday when reading the spec that it now declares that as legacy suffix:
Adjust to the fact that the Switch user button is always visible now
Copying a comment I made on the Qt report after explaining the problems of doing it in the platform.
Hi @mak, so seems we appdata content creators are still unsure what to do, allow me to put the last question of last night again to your attention:
Remove unnecessary X-AppStream-Ignore property
Weird, I actually updated my git config before comitting. Will pay attention to it next time.
Thanks for landing it!
can I request that some of the big cheeses (@ngraham @graesslin etc) have a discussion with the QT devs on this? It needs to be agreed where this belongs. I'd agree with @AndreyYashkin and put it in QT.. But no-one cares what I think!