PlasmaProject
ActivePublic

Recent Activity

Today

AndreyYashkin added a comment to T10783: Right-click on touch.

MouseArea.pressAndHold runs based on the synthesised left press event, I don't see anything in your code which would prevent a conflict there.
Same for any widget code that uses a current QTapAndHoldGesture

Wed, Aug 21, 9:11 PM · Plasma, VDG
ngraham added a comment to D23330: Make manual control compatible with redshift >= 1.12.

Is redshift -P -O fully backwards-compatible with older versions of redshift? If not, then this will just break everyone not using >=1.12.

Wed, Aug 21, 8:55 PM · Plasma
vermeeren added a reviewer for D23330: Make manual control compatible with redshift >= 1.12: Plasma.
Wed, Aug 21, 8:44 PM · Plasma
vermeeren added a comment to D23330: Make manual control compatible with redshift >= 1.12.

I am not sure how the version scheme will work now that this plasmoid is officially part of KDE, but once this is merged the version should definitely be bumped as this is a critical issue preventing use of manual mode. See also: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910901

Wed, Aug 21, 8:34 PM · Plasma
vermeeren requested review of D23330: Make manual control compatible with redshift >= 1.12.
Wed, Aug 21, 8:32 PM · Plasma
davidedmundson added a comment to T10783: Right-click on touch.

To be clear, I don't have a problem with your patch - and happily support it.

Wed, Aug 21, 7:43 PM · Plasma, VDG
AndreyYashkin added a comment to T10783: Right-click on touch.

IIRC the objection was that making press-and-hold always mean right-click at the toolkit level could interfere with apps that want to re-implement the press-and-hold behavior for some other behavior. For example a lot of Android apps use press-and-hold to mean "make this list/view editable".

Personally I think a consistent behavior is more important, but I understand that it is a concern.

Wed, Aug 21, 7:32 PM · Plasma, VDG
mak added a comment to D23328: Exclude other desktop file from AppStream metadata generation.

I didn't test this, but I wrote the code which will handle this and it works in other cases ;-)
My comment was to confirm that the commit does indeed what you intend it to do, according to the spec and code.

Wed, Aug 21, 7:28 PM · Plasma
ngraham closed D23328: Exclude other desktop file from AppStream metadata generation.
Wed, Aug 21, 7:24 PM · Plasma
ngraham added a comment to D23328: Exclude other desktop file from AppStream metadata generation.
In D23328#516191, @mak wrote:

Effect is kdesystemsettings.desktop not being shown in any software center.
LGTM

Wed, Aug 21, 7:15 PM · Plasma
mak added a comment to D23328: Exclude other desktop file from AppStream metadata generation.

Effect is kdesystemsettings.desktop not being shown in any software center.
LGTM

Wed, Aug 21, 7:15 PM · Plasma
ngraham added a comment to T10783: Right-click on touch.

IIRC the objection was that making press-and-hold always mean right-click at the toolkit level could interfere with apps that want to re-implement the press-and-hold behavior for some other behavior. For example a lot of Android apps use press-and-hold to mean "make this list/view editable".

Wed, Aug 21, 7:07 PM · Plasma, VDG
ngraham added a comment to D23306: Add AppStream metadata file.

All right, hopefully the third time's the charm: D23328

Wed, Aug 21, 7:02 PM · Plasma
ngraham requested review of D23328: Exclude other desktop file from AppStream metadata generation.
Wed, Aug 21, 7:02 PM · Plasma
ngraham closed D23325: Use non-deprecated .metainfo.xml filename extension.
Wed, Aug 21, 6:58 PM · Plasma
ngraham updated the diff for D23325: Use non-deprecated .metainfo.xml filename extension.

You assume far too much competance on my part :)

Wed, Aug 21, 6:57 PM · Plasma
mak added a comment to D23306: Add AppStream metadata file.
In D23306#515662, @mak wrote:

Thanks! Though reading it, leaves open questions with me:

  • what is meant by "referenced"? only via <launchable>?

In modern metainfo files yes, only via launchable. However, if a component id has a .desktop suffix, as was required in the past, and a matching .desktop file is found, that also counts as referenced and the desktop-entry file will be read.

As developer trying to write metainfo files, I would welcome this logic also documented n the docs. The current content of the docs is confusing to me at least.

  • if there are two desktop files referenced by <launchable> where one has the ignore entry set, will this overrule the "Data will only be fetched from a desktop file if one <launchable/> tag is present" rules above?

No. A launchable tag always beats whatever was defined in the desktop-entry file itself, so if there is one launchable tag, the .desktop entry file will be taken into consideration no matter what was defined in it (to e.g. merge in category information). Any equivalent data in the metainfo file beats that of the desktop-entry file though. If there are multiple launchable entries, the generator has no idea which .desktop file to read, so rather than reading any and getting information wrong, it will read none (requiring the metainfo author to add all data they want in there explicitly).
This could maybe be made smarter, but tbh this case is so rare that just making the metainfo files more complete in such events seems like the better approach.

So, in our case here, <launchable type="desktop-id">systemsettings.desktop</launchable> actually means there is no need to add X-AppStream-Ignore=true to "kdesystemsettings.desktop" ? Because the generators would ignore it already due to a <launchable> present and pointing to the other desktop file?

Wed, Aug 21, 6:43 PM · Plasma
kossebau added a comment to D23325: Use non-deprecated .metainfo.xml filename extension.

I assume you also change the cmake install command in app/CMakeLists.txt in the final patch, though :)

Wed, Aug 21, 6:39 PM · Plasma
kossebau accepted D23325: Use non-deprecated .metainfo.xml filename extension.
Wed, Aug 21, 6:30 PM · Plasma
ngraham added a comment to D23306: Add AppStream metadata file.

@ngraham You used the "appdata.xml" file suffix here. I noticed yesterday when reading the spec that it now declares that as legacy suffix:

While desktop-application metadata is commonly stored in /usr/share/metainfo/%{id}.metainfo.xml (with a .metainfo.xml extension), using a .appdata.xml extension is also permitted for this component type for legacy compatibility.

From https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html

Given Plasma targets newer system, perhaps it makes sense to start right away with a metainfo.xml suffix?

Wed, Aug 21, 6:23 PM · Plasma
ngraham requested review of D23325: Use non-deprecated .metainfo.xml filename extension.
Wed, Aug 21, 6:23 PM · Plasma
AndreyYashkin added a comment to T10783: Right-click on touch.

No, we need exactly right click events. They are too important for many apps. For instance, how will we mark the cells in KMines without right click event? I backported my patch on 5.12 in order to replace native Qt version under Kubuntu and now I can successfully mark and unmark the cells.

Wed, Aug 21, 6:04 PM · Plasma, VDG
ngraham added a comment to D23324: Show progress for PackageKit update fetching.

And finally, it would be nice to display the text + progress indicator in the center of the view, not at the very top.

Wed, Aug 21, 5:39 PM · Plasma
ngraham added a comment to D23324: Show progress for PackageKit update fetching.

Also hide the placeholder icon while the progress indicator is visible so this doesn't happen:

Wed, Aug 21, 5:38 PM · Plasma
apol updated the diff for D23324: Show progress for PackageKit update fetching.

Lose the BusyIndicator

Wed, Aug 21, 5:32 PM · Plasma
apol requested review of D23324: Show progress for PackageKit update fetching.
Wed, Aug 21, 5:28 PM · Plasma
kossebau added a comment to D23306: Add AppStream metadata file.

@ngraham You used the "appdata.xml" file suffix here. I noticed yesterday when reading the spec that it now declares that as legacy suffix:

Wed, Aug 21, 4:46 PM · Plasma
ngraham updated the summary of D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to.
Wed, Aug 21, 4:22 PM · Plasma
ngraham updated the diff for D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to.

Adjust to the fact that the Switch user button is always visible now

Wed, Aug 21, 4:14 PM · Plasma
davidedmundson added a comment to T10783: Right-click on touch.

Copying a comment I made on the Qt report after explaining the problems of doing it in the platform.

Wed, Aug 21, 3:57 PM · Plasma, VDG
ngraham updated the diff for D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to.

Rebase

Wed, Aug 21, 3:46 PM · Plasma
ngraham closed D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.
Wed, Aug 21, 3:40 PM · Plasma
kossebau added a comment to D23306: Add AppStream metadata file.

Hi @mak, so seems we appdata content creators are still unsure what to do, allow me to put the last question of last night again to your attention:

Wed, Aug 21, 3:28 PM · Plasma
ngraham closed D23320: Tell AppStream generators not to index Klipper .desktop files.
Wed, Aug 21, 3:26 PM · Plasma
ngraham closed D23306: Add AppStream metadata file.
Wed, Aug 21, 3:22 PM · Plasma
ngraham updated the diff for D23306: Add AppStream metadata file.

Remove unnecessary X-AppStream-Ignore property

Wed, Aug 21, 3:16 PM · Plasma
kossebau added inline comments to D23306: Add AppStream metadata file.
Wed, Aug 21, 3:08 PM · Plasma
apol accepted D23306: Add AppStream metadata file.
Wed, Aug 21, 2:57 PM · Plasma
apol accepted D23320: Tell AppStream generators not to index Klipper .desktop files.
Wed, Aug 21, 2:57 PM · Plasma
ngraham requested review of D23320: Tell AppStream generators not to index Klipper .desktop files.
Wed, Aug 21, 2:55 PM · Plasma
ndavis closed D23319: Add dark theme icons.
Wed, Aug 21, 2:42 PM · Plasma
broulik accepted D23319: Add dark theme icons.
Wed, Aug 21, 2:40 PM · Plasma
ndavis requested review of D23319: Add dark theme icons.
Wed, Aug 21, 2:37 PM · Plasma
ognarb closed D23318: Add dark theme in the extension popup.
Wed, Aug 21, 2:19 PM · Plasma
broulik accepted D23318: Add dark theme in the extension popup.

Cool!

Wed, Aug 21, 2:16 PM · Plasma
ognarb requested review of D23318: Add dark theme in the extension popup.
Wed, Aug 21, 2:15 PM · Plasma
MrPepe added a comment to D23292: Make update page labels consistent with topUpdateComp.

Weird, I actually updated my git config before comitting. Will pay attention to it next time.
Thanks for landing it!

Wed, Aug 21, 2:14 PM · Plasma
broulik closed D23126: Add browser action for status reporting.
Wed, Aug 21, 2:00 PM · Plasma
russh added a comment to T10783: Right-click on touch.

can I request that some of the big cheeses (@ngraham @graesslin etc) have a discussion with the QT devs on this? It needs to be agreed where this belongs. I'd agree with @AndreyYashkin and put it in QT.. But no-one cares what I think!

Wed, Aug 21, 1:53 PM · Plasma, VDG
broulik added inline comments to D22513: Expose if we're still searching for more results.
Wed, Aug 21, 1:43 PM · Plasma