PlasmaProject
ActivePublic

Recent Activity

Today

ngraham added a comment to D25920: [KCMs/Night Color] Make activation criteria and times more obvious.

Suggestions:

"To reduce eye strain, Night Color makes the colors on the screen warmer at the time of your choosing"

Change to:

"Night Color makes the screen colors warmer to reduce eye strain"

Fri, Dec 13, 4:49 PM · Plasma
abetts added a comment to D25920: [KCMs/Night Color] Make activation criteria and times more obvious.

"To reduce eye strain, Night Color makes the colors on the screen warmer at the time of your choosing"

Fri, Dec 13, 4:38 PM · Plasma
ngraham accepted D25844: Don't compress tasks before grouping, when task manager is vertical.

Thanks, now the bug and the fix are very clear! LGTM!

Fri, Dec 13, 4:28 PM · Plasma
ngraham requested review of D25959: [applets/taskmanager] Add highlight effect for hovered tooltip.
Fri, Dec 13, 4:11 PM · Plasma
broulik closed D25936: [Desktop Containment] Hide tooltip while rotating the widget.
Fri, Dec 13, 3:57 PM · Plasma
broulik closed D25932: [Task Manager] Better align badge in tooltip.
Fri, Dec 13, 3:56 PM · Plasma
gvgeo updated the test plan for D25844: Don't compress tasks before grouping, when task manager is vertical.
Fri, Dec 13, 3:32 PM · Plasma
ngraham added a comment to D25950: Add specialized notification for Bluetooth battery.

Maybe this should be a critical notification? If it's your mouse or a device you're using to present with, that's not something you want to miss. :)

Fri, Dec 13, 2:27 PM · Plasma
ngraham requested review of D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail.
Fri, Dec 13, 2:22 PM · Plasma
broulik added a dependency for D25950: Add specialized notification for Bluetooth battery: D25951: Show peripheral low battery notification for NoCharge.
Fri, Dec 13, 1:52 PM · Plasma
broulik added a dependent revision for D25951: Show peripheral low battery notification for NoCharge: D25950: Add specialized notification for Bluetooth battery.
Fri, Dec 13, 1:52 PM · Plasma
broulik requested review of D25951: Show peripheral low battery notification for NoCharge.
Fri, Dec 13, 1:51 PM · Plasma
broulik updated the diff for D25950: Add specialized notification for Bluetooth battery.
  • Drop odd parentheses
Fri, Dec 13, 1:49 PM · Plasma
zzag updated the diff for D25947: Add applet for controlling Night Color.

Delete stray include.

Fri, Dec 13, 1:48 PM · Plasma
broulik requested review of D25950: Add specialized notification for Bluetooth battery.
Fri, Dec 13, 1:48 PM · Plasma
zzag added a comment to D25947: Add applet for controlling Night Color.

This patch depends on D25946 and D25786.

Fri, Dec 13, 1:25 PM · Plasma
zzag requested review of D25947: Add applet for controlling Night Color.
Fri, Dec 13, 1:23 PM · Plasma
ngraham updated the diff for D25920: [KCMs/Night Color] Make activation criteria and times more obvious.

Put the separator in the formlayout for more simplicity

Fri, Dec 13, 1:20 PM · Plasma
ngraham updated the diff for D25920: [KCMs/Night Color] Make activation criteria and times more obvious.

Restore original import order for timings view now that we don't need layouts anymore

Fri, Dec 13, 1:18 PM · Plasma
ngraham updated the diff for D25920: [KCMs/Night Color] Make activation criteria and times more obvious.

Put the labels back in a FormLayout to align the times, but don't align the formlayout
itself with the top one or else the whole thing is too far over to the left

Fri, Dec 13, 1:17 PM · Plasma
davidedmundson accepted D25920: [KCMs/Night Color] Make activation criteria and times more obvious.
Fri, Dec 13, 1:04 PM · Plasma
ngraham added a comment to D25920: [KCMs/Night Color] Make activation criteria and times more obvious.

This idea was to have a top-to-bottom flow. First you turn it on, then you select the activation mode, then you manipulate the controls specific to that mode (if applicable), then you see the times that result from those settings. I think it makes logical sense. If you have any suggestions for how to improve the presentation, I'm all ears. Also interested in VDG feedback.

Fri, Dec 13, 12:43 PM · Plasma
gikari added a reviewer for D25945: Sync dark theme preference for GTK3 applications: VDG.
Fri, Dec 13, 12:38 PM · Plasma
gikari added a dependent revision for D25872: Refactor GTK KCM code: D25945: Sync dark theme preference for GTK3 applications.
Fri, Dec 13, 12:37 PM · Plasma
gikari requested review of D25945: Sync dark theme preference for GTK3 applications.
Fri, Dec 13, 12:37 PM · Plasma
romangg added a comment to D25920: [KCMs/Night Color] Make activation criteria and times more obvious.

Sorry, but I don't like how the text is "hanging in the air" and how it is jumping around when changing the setting.

Fri, Dec 13, 12:04 PM · Plasma
ngraham added a comment to D25844: Don't compress tasks before grouping, when task manager is vertical.

I'm not sure how to reproduce the issue that this patch is fixing. Can you add more detail to the Test Plan section maybe?

Fri, Dec 13, 11:00 AM · Plasma
ngraham added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

I though that would just affect every app's titlebar without actually checking if the app has a toolbar, etc etc and just add/remove the divider everywhere and be done with it. However, if the app can actually send a hint to Kwin to make it hide or show the divider depending if it has a toolbar or not (or maybe through a window / app rule), then it's great

Fri, Dec 13, 10:56 AM · Plasma
ngraham added a comment to D25925: Mark applications that play audio, for all task icon sizes.

Yes, the second one looks the best out of those for sure. FDO = "FreeDesktop.org", in this case referring to the FreeDesktop spec for icon naming. It ensures that icon themes work (at least tolerably).

Fri, Dec 13, 10:48 AM · Plasma
ngraham updated the test plan for D25920: [KCMs/Night Color] Make activation criteria and times more obvious.
Fri, Dec 13, 10:16 AM · Plasma
ngraham updated the diff for D25920: [KCMs/Night Color] Make activation criteria and times more obvious.

Polish everything even more to ensure a consistent top-to-bottom workflow. To do this
I had to do a lot of refactoring that also has the side effect of making the UI a lot
more declarative.

Fri, Dec 13, 10:16 AM · Plasma
ahiemstra updated the summary of D25941: Add a page to display ActionToolBar and some of its features.
Fri, Dec 13, 10:15 AM · Kirigami, Plasma
ahiemstra requested review of D25941: Add a page to display ActionToolBar and some of its features.
Fri, Dec 13, 9:53 AM · Kirigami, Plasma
apol closed D25908: Lock screen by default, on mobile.
Fri, Dec 13, 9:47 AM · Plasma
gvgeo updated the summary of D25925: Mark applications that play audio, for all task icon sizes.
Fri, Dec 13, 9:42 AM · Plasma
apol accepted D25933: [applets/pager] Calculate full screen geometry.
Fri, Dec 13, 9:41 AM · Plasma
gvgeo added a comment to D25925: Mark applications that play audio, for all task icon sizes.

My main problem is, the difficulty to control the size of the icon.
While it appears to be a general icon issue, I hope that I'm doing something wrong.

Fri, Dec 13, 9:41 AM · Plasma
broulik updated the diff for D25917: [Notifications] Show hint if notifications aren't available or provided by someone else.
  • Restore condition
Fri, Dec 13, 9:30 AM · Plasma
broulik updated the diff for D25917: [Notifications] Show hint if notifications aren't available or provided by someone else.
  • Cleanup
Fri, Dec 13, 9:29 AM · Plasma
broulik added a reviewer for D25844: Don't compress tasks before grouping, when task manager is vertical: hein.
Fri, Dec 13, 8:52 AM · Plasma
romangg accepted D25920: [KCMs/Night Color] Make activation criteria and times more obvious.
Fri, Dec 13, 6:25 AM · Plasma
trmdi updated the test plan for D25807: Allow to set the available screen rect/region from outside through dbus.
Fri, Dec 13, 3:04 AM · Plasma
trmdi updated the diff for D25807: Allow to set the available screen rect/region from outside through dbus.
  • emit signals when setConnected
Fri, Dec 13, 2:53 AM · Plasma

Yesterday

ngraham accepted D25936: [Desktop Containment] Hide tooltip while rotating the widget.
Thu, Dec 12, 10:06 PM · Plasma
broulik requested review of D25936: [Desktop Containment] Hide tooltip while rotating the widget.
Thu, Dec 12, 9:39 PM · Plasma
ngraham added a comment to D25935: [Notifications] Add hint for showing a notification even in do not disturb mode.

All right, you've convinced me. :)

Thu, Dec 12, 9:27 PM · Plasma
broulik added a comment to D25935: [Notifications] Add hint for showing a notification even in do not disturb mode.

How is it, though? It is an internal hint on some DBus method no user will ever see. Internally it's all things like notificationsInhibitedUntil, even the (public) DBus API says "Inhibited"

Thu, Dec 12, 9:27 PM · Plasma
ngraham added a comment to D25935: [Notifications] Add hint for showing a notification even in do not disturb mode.

Yeah but this is a user-facing thing (well, sort of user-facing).

Thu, Dec 12, 9:25 PM · Plasma
ngraham updated the diff for D25920: [KCMs/Night Color] Make activation criteria and times more obvious.

Improve begin/end strings again

Thu, Dec 12, 9:24 PM · Plasma
broulik added a comment to D25935: [Notifications] Add hint for showing a notification even in do not disturb mode.

Internally it uses "inhibited" for that everywhere

Thu, Dec 12, 9:22 PM · Plasma