You can't commit yet as nobody accepted this patch.
Add some const & for things that return const & so there's no need to make a copy
For what it's worth, copy elision is guaranteed starting from C++17. \o/
There will anyways be one "big" change in the history, but normally git will be able to handle that well by ignoring space changes for blame or diff.
I don't think without the aligning the change will be much smaller.
I have Develop Account now. Is review finished or something more is needed? Can I push this change?
it seems ok for me.
Could also port entirely away from PlasmaComponents and PlasmaExtras without too much effort. I suppose that's best done on a separate patch though.
remove some more
Lets all follow up here: https://bugs.kde.org/show_bug.cgi?id=412913
@The-Feren-OS-Dev hello I read at a new article at https://medium.com/feren-os/a-whole-slew-of-updates-got-released-for-feren-os-next-6c880d6eedda that you are playing with Latte and more specific:
I think that makes sense.
Why isn't it managing to send the paste data to klipper before quitting?
This fixes the issue for the preview image of the currently-viewed theme, but not for the thumbnail images:
Sat, Oct 12
Looking at kmenuedit and dolphin settings dialog, the margin and spacing look comparable, so those setContentMargins and setSpacing calls aren't needed any more.
Actually on or just the config saying it was on?
I have updated two PCs and on both telemetry was on by default...
I don't claim to solve the whole problem, it's just a step forward.