PlasmaProject
ActivePublic

Recent Activity

Today

bero added a comment to D27514: Fix incorrect use of case statements in accountmodel.cpp.

Another option would be switching the code to use if instead of switch/case so the || operator would actually do what the code expected (and x || x, unlike duplicate case values, isn't an error)

Thu, Feb 20, 12:21 AM · Plasma
bero updated the diff for D27514: Fix incorrect use of case statements in accountmodel.cpp.

Probably best to just add a comment explaining what needs to be done if AccountModel::* roles ever diverge from DisplayRole/DecorationRole...

Thu, Feb 20, 12:19 AM · Plasma
bero added a comment to D27514: Fix incorrect use of case statements in accountmodel.cpp.

Actually the obvious fix doesn't work (thought it was so obvious that I submitted it before testing, sorry) because Qt::DisplayRole and AccountModel::FriendlyName are both 0 (-> duplicate case value) and Qt::DecorationRole and AccountModel::Face are both 1 (-> duplicate case value). Also explains why the bogus variant before "worked" - (Qt::DisplayRole || AccountModel::FriendlyName) = 0 || 0 = 0 = Qt::DisplayRole = AccountModel::FriendlyName and (Qt::DecorationRole || AccountModel::Face) = 1 || 1 = 1 = Qt::DecorationRole = AccountModel::Face

Thu, Feb 20, 12:11 AM · Plasma
davidedmundson accepted D27514: Fix incorrect use of case statements in accountmodel.cpp.
Thu, Feb 20, 12:04 AM · Plasma
bero edited reviewers for D27514: Fix incorrect use of case statements in accountmodel.cpp, added: Plasma; removed: Frameworks.
Thu, Feb 20, 12:02 AM · Plasma
bero requested review of D27514: Fix incorrect use of case statements in accountmodel.cpp.
Thu, Feb 20, 12:01 AM · Plasma

Yesterday

ngraham added a comment to D26946: Changed leftMargins to smallSpacing to be consistent.

So, with a left panel, I see the following:

Wed, Feb 19, 10:38 PM · Plasma
ngraham added a comment to D26945: Added smallSpacing to leftMargin.

Since this patch is for KScreen, you need to follow the commit message guidelines: https://cgit.kde.org/kscreen.git/tree/CONTRIBUTING.md#n22

Wed, Feb 19, 10:33 PM · Plasma
ngraham added a comment to D26992: [SystemTray] Use unified data model everywhere.

UI looks good except for one thing: the changes to show a highlight effect on hover in the popup are unrelated and should be done in a separate patch (preferably in coordination with VDG folks since we're moving towards the idea of using this in other places too).

Wed, Feb 19, 10:02 PM · Plasma
kmaterka updated the diff for D26992: [SystemTray] Use unified data model everywhere.

Second (and last) change extracted from this one is in master. Rebased, ready for review.

Wed, Feb 19, 9:36 PM · Plasma
kmaterka closed D27088: [applets/SystemTray] Implement sorting in the model.
Wed, Feb 19, 9:09 PM · Plasma
davidedmundson accepted D27088: [applets/SystemTray] Implement sorting in the model.
Wed, Feb 19, 9:07 PM · Plasma
kmaterka updated the diff for D27088: [applets/SystemTray] Implement sorting in the model.

Review fixes

Wed, Feb 19, 9:04 PM · Plasma
davidre added a reviewer for D27421: [Cuttleffish] Use proper QSortFilterProxyModel: Plasma.
Wed, Feb 19, 8:24 PM · Plasma
niccolove updated the diff for D26945: Added smallSpacing to leftMargin.
Wed, Feb 19, 8:15 PM · Plasma
niccolove updated the diff for D26946: Changed leftMargins to smallSpacing to be consistent.

Rebase

Wed, Feb 19, 8:14 PM · Plasma
alex updated the diff for D27513: Kill Runner: Remove duplicate function calls and refactor.

Remove QDebug include, add license

Wed, Feb 19, 8:07 PM · Plasma
alex requested review of D27513: Kill Runner: Remove duplicate function calls and refactor.
Wed, Feb 19, 7:58 PM · Plasma
niccolove reclaimed D26945: Added smallSpacing to leftMargin.
Wed, Feb 19, 7:23 PM · Plasma
niccolove reclaimed D26946: Changed leftMargins to smallSpacing to be consistent.
Wed, Feb 19, 7:23 PM · Plasma
ngraham added a comment to D26946: Changed leftMargins to smallSpacing to be consistent.

All right, feel free to re-open it and re-base on current master (there has been a lot of work to these applets lately).

Wed, Feb 19, 7:21 PM · Plasma
apol abandoned D27346: emojier: Improve resizing performance.

Solved as https://commits.kde.org/plasma-desktop/91c446e0c4430289369963bf44e64228add67d18

Wed, Feb 19, 6:59 PM · Plasma
davidedmundson added a comment to D27083: [PC2]Give Label integer width..

In my opinion the Plasma Controls need fix

Wed, Feb 19, 6:34 PM · Frameworks, Plasma
niccolove added a comment to D26946: Changed leftMargins to smallSpacing to be consistent.

What I care about is that the margins are consistent and things are properly left-aligned by default. That is to say, nothing should have to override the default margins to have everything perfectly aligned.

Wed, Feb 19, 6:28 PM · Plasma
ngraham added a comment to D27083: [PC2]Give Label integer width..

Probably frameworks-plasma | components

Wed, Feb 19, 6:22 PM · Frameworks, Plasma
manueljlin accepted D26806: [Applets/Power Manager] Update layout based on T10470.
Wed, Feb 19, 6:18 PM · Plasma
gvgeo added a comment to D27083: [PC2]Give Label integer width..

So the test needs to be fixed?

Wed, Feb 19, 6:08 PM · Frameworks, Plasma
gvgeo added a comment to D27422: [KCM]Update Device item layout based on applet.

I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows:

I cannot replicate this. And I cannot see how I could have created this. Or where to start.

Wed, Feb 19, 5:57 PM · Plasma
kmaterka added inline comments to D27088: [applets/SystemTray] Implement sorting in the model.
Wed, Feb 19, 5:34 PM · Plasma
davidedmundson requested review of D27509: Introduce ProcessDataModel.
Wed, Feb 19, 5:30 PM · Plasma
alex added reviewers for D27495: Remove unnecessary code and function calls: meven, Plasma.
Wed, Feb 19, 5:15 PM · Plasma
alex updated the diff for D27495: Remove unnecessary code and function calls.

Remove unnecessary Q_UNUSED macro

Wed, Feb 19, 5:13 PM · Plasma
ngraham added a comment to D27083: [PC2]Give Label integer width..

So the test needs to be fixed?

Wed, Feb 19, 3:43 PM · Frameworks, Plasma
ngraham added a comment to D27316: [Folder view]Make shadow scale aware.

You've got so many landed patches under your belt now that I think it's time to apply for a developer account. :)

Wed, Feb 19, 3:36 PM · Plasma
ngraham closed D27316: [Folder view]Make shadow scale aware.
Wed, Feb 19, 3:36 PM · Plasma
mart added a comment to D27481: Panel spacer that can center things.

I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but that can be done in the future if desired.

An idea could be to display something similiar to the icon on the "Add spacer" button on then or an arrow on each side

Wed, Feb 19, 3:30 PM · Plasma
crossi updated the diff for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.

Consider Kevin's comments

Wed, Feb 19, 3:07 PM · Plasma
davidedmundson added a comment to D27316: [Folder view]Make shadow scale aware.

we would not need to remove it

Wed, Feb 19, 3:06 PM · Plasma
davidre added a comment to D27481: Panel spacer that can center things.

I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but that can be done in the future if desired.

Wed, Feb 19, 3:01 PM · Plasma
ngraham added a comment to D27481: Panel spacer that can center things.

Yeah it would be nice to call this an "Expanding spacer" or something like that. That's the term that we use for the rough equivalent for KXMLGui toolbars.

Wed, Feb 19, 2:57 PM · Plasma
ngraham added a comment to D27422: [KCM]Update Device item layout based on applet.

I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows:

Wed, Feb 19, 2:55 PM · Plasma
meven added inline comments to D27495: Remove unnecessary code and function calls.
Wed, Feb 19, 2:34 PM · Plasma
ngraham added a comment to D27316: [Folder view]Make shadow scale aware.

So will we need to remove this multiplying by units.devicePixelRatio bit if and when we finally make plasmashell respect Qt scaling and fix https://bugs.kde.org/show_bug.cgi?id=356446?

Wed, Feb 19, 2:32 PM · Plasma
bport added a dependency for D27503: [KCM Spellchecking] port to KPropertySkeletonItem: D27502: Create ConfigView an unmanaged ConfigWidget.
Wed, Feb 19, 2:04 PM · Plasma
bport requested review of D27503: [KCM Spellchecking] port to KPropertySkeletonItem.
Wed, Feb 19, 2:03 PM · Plasma
davidre added a comment to D27481: Panel spacer that can center things.

I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but that can be done in the future if desired.

Wed, Feb 19, 1:27 PM · Plasma
mart updated the diff for D27481: Panel spacer that can center things.
  • bigger in edit mode
Wed, Feb 19, 12:56 PM · Plasma
mart retitled D27481: Panel spacer that can center things from [WIP]Panel spacer that can center things to Panel spacer that can center things.
Wed, Feb 19, 12:45 PM · Plasma
mart added a comment to D27481: Panel spacer that can center things.

demo of adding 2 spacers and centering mode

Wed, Feb 19, 12:45 PM · Plasma
mart updated the diff for D27481: Panel spacer that can center things.
  • put the second spacer at the beginning
Wed, Feb 19, 12:43 PM · Plasma