Add action to part.rc
Bump version to 40

In D18744#411599, @ngraham wrote:

Please test your changes. The new menu is not actually added to the Edit menu and the shortcut you chose conflicts with the print shortcut.

Remove unneeded comment

Add action and shortcut to select the current page
Remove triggering on mouseDoubleClick event

Restore Cancel button

@ngraham What about the code? Is it okay if you had a look?

@tcanabrava If you don't mind, can I take over this revision? I'm willing to complete it.

Ping?

What should I do to this revision? continue or abandon in favor of the other?

use rotateAt()

In D18816#409397, @aacid wrote:

Unless you have a bug that needs this fix, i really prefer if you don't touch event handling

In D18766#409139, @ngraham wrote:

Yes, let's land it. Please land it on the 5.15 branch and then merge to master. If you don't know how to do that, I can help you.

@ngraham Is it now behaving as it should?

Ping

In D18766#408901, @ngraham wrote:

Works for me, no segfault. I don't see any reason why this change could cause that. @shubham, does the segfault stop happening when you build Discover from source without this change?

It compiles but I could not test this. When I run the plasma-discover segmentation fault prevails.

Remove timeout period

Remove unneeded include

Rotate

Can somebody experienced review this?

@aacid stuck with what my inline message says.

Is it okay now?

Any piece of help would be appreciated, I m stuck.

I don't think we should present a dialog box because previously I have heard that dialog boxes are annoying to most users. @ngraham will know it.

@tcanabrava Are you still working on this, because I did not knew about this revision and created a new revision for the same feature
Please see D18606

Ping? Any comments, this patch is in review queue for almost 2 months now.

Um, why no Cancel button? As @emateli had shown this is usual. Is there a disadvantage to offer such button too?

Accept and ignore the event

@dhaumann I don't think using switch when there is only a single case a good thought. That's what if is for.

@hindenburg Are you okay with this after me and nate have explained it's pros? If not, I will abandon this.

I'm unsure how mouse click events of degree n can be handled. Maybe handle mouseDoubleClickEvent() nested inside another mouseDoubleClickEvent() ?

@apol about the timeout?

In D18744#406150, @aacidTriple-click is used for "select everything" in word processors, so perhaps we could take advantage of some familiarity there?

AFAICS triple-click is usually "select line" not "select all page/document"

Having triple click for "select line" would be actually a great improvement IMHO

I'm not sure you even need to add the timeout: line at all.

@bigpresh Humble sorry from my side if I sounded a bit too rude, which I didn't meant
@aacid Thanks for guiding, will keep that in mind in future.

When user is typing text, the tooltip continuosly shown above distracts and looks ugly

@apol I have noticed that the tooltip is seen even when there is text present, also the duration for which it appears is very long
I messed up with summary.

Use length

Caution: I did not do my video editing magic : )

@ngraham @loh.tar I don't think it is that big of a feature to be shown in the view menu. It is something which is natural, same as when you select a word(which also don't have any action defined). i'm okay anyways.

Remove unncessary <QDebug> include

Please ignore my above comments.

Most service providers don't have an icon.

Abandoned in favour of D18761

@broulik Adding icons to the .desktop files does not work, I tried.

Note: This is not a working version, see my inline comment. However, I can confirm that after fixing the seg fault error, it will become working since I have manually tested to select the entire page and then qDebug() the "text" gave same contents as that of the selected page.

@ngraham I had a look at KuriFilterData in frameworks, iconNameForPreferredSearchProvider() function is producing same icon name for all the entries ie. "text-html"

Add new line

Remove comment