Accept and ignore event
AbandonedPublic

Authored by shubham on Feb 7 2019, 2:48 PM.

Details

Reviewers
aacid
Summary

This does not do anything of the kind of fixing bug. It just accepts the event to tell that event receiver is interested in listening to it, and ignore just ignores the event for any specific scenario.

Diff Detail

Repository
R223 Okular
Branch
event
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7984
Build 8002: arc lint + arc unit
shubham created this revision.Feb 7 2019, 2:48 PM
Restricted Application added a project: Okular. · View Herald TranscriptFeb 7 2019, 2:48 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
shubham requested review of this revision.Feb 7 2019, 2:48 PM
ngraham added a subscriber: ngraham.Feb 7 2019, 2:51 PM

Context? What bug is this fixing? Why is this necessary?

That would be good information to put into the Summary section. :)

shubham edited the summary of this revision. (Show Details)Feb 7 2019, 3:38 PM
shubham edited the summary of this revision. (Show Details)
shubham edited the summary of this revision. (Show Details)Feb 7 2019, 4:16 PM
aacid added a comment.Feb 10 2019, 6:48 PM

Unless you have a bug that needs this fix, i really prefer if you don't touch event handling

Unless you have a bug that needs this fix, i really prefer if you don't touch event handling

I added these since they were handed the same way in ktexteditor.

aacid added a comment.Feb 25 2019, 7:12 PM

The ping is on your side, you still haven't explained why this is needed and what it fixes

The ping is on your side, you still haven't explained why this is needed and what it fixes

I told you in my previous comment that it was handled the same way in ktexteditor, that is why I added it.

aacid added a comment.Feb 26 2019, 9:23 PM

I know how to read, apparently you don't.

You have little conversation output, and I have little understanding of QEvent.

But lets start to explain why the event should not be propagated to another widget, although there was no annotation or the mouseMode is not TextSelect? Alternatively: Which other widget would need right/middle clicks?

And why does mouseDoubleClickEvent() ignore() events and mouseWheelEvent() not? Is there anything special with double clicks?

shubham abandoned this revision.Mar 13 2019, 2:10 PM