Differential D18816

Accept and ignore event
Needs ReviewPublic
Actions

Authored by shubham on Thu, Feb 7, 2:48 PM.

Details

Reviewers
aacid
Summary

This does not do anything of the kind of fixing bug. It just accepts the event to tell that event receiver is interested in listening to it, and ignore just ignores the event for any specific scenario.

Diff Detail

Repository
R223 Okular
Branch
event
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7984
Build 8002: arc lint + arc unit
shubham created this revision.Thu, Feb 7, 2:48 PM
Restricted Application added a project: Okular. · View Herald TranscriptThu, Feb 7, 2:48 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
shubham requested review of this revision.Thu, Feb 7, 2:48 PM
ngraham added a subscriber: ngraham.Thu, Feb 7, 2:51 PM

Context? What bug is this fixing? Why is this necessary?

That would be good information to put into the Summary section. :)

shubham edited the summary of this revision. (Show Details)Thu, Feb 7, 3:38 PM
shubham edited the summary of this revision. (Show Details)
shubham edited the summary of this revision. (Show Details)Thu, Feb 7, 4:16 PM
aacid added a comment.Sun, Feb 10, 6:48 PM

Unless you have a bug that needs this fix, i really prefer if you don't touch event handling

shubham added a comment.Tue, Feb 12, 8:20 AM
In D18816#409397, @aacid wrote:

Unless you have a bug that needs this fix, i really prefer if you don't touch event handling

I added these since they were handed the same way in ktexteditor.

Revision Contents
Changeset List

PathPackages
Mui/pageview.cpp (3 lines)

Diff 51103

View Options

ui/pageview.cpp

Loading...