loh.tar (loh tar)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 23 2018, 3:22 PM (39 w, 3 d)
Availability
Available

Recent Activity

Today

loh.tar updated the diff for D20815: Ensure highlighted folding marker after unfold.
  • Ensure cursor don't move when isssue toggleFoldingsInRange
Thu, Apr 25, 3:10 PM · Frameworks, Kate
loh.tar added a comment to D20815: Ensure highlighted folding marker after unfold.

I think about a patch to issue the foldingPreview in case of unfold when done by click on the icon bar. Unfortunately would that need some bigger changes at the toggleFolding functions to return what was done.

Thu, Apr 25, 2:34 PM · Frameworks, Kate
loh.tar requested review of D20815: Ensure highlighted folding marker after unfold.
Thu, Apr 25, 2:22 PM · Frameworks, Kate

Yesterday

loh.tar committed R39:0d70744ed67b: Fix broken InlineNoteTest (authored by loh.tar).
Fix broken InlineNoteTest
Wed, Apr 24, 1:42 PM
loh.tar closed D20697: Review IconBorder.
Wed, Apr 24, 1:42 PM · Frameworks, Kate

Tue, Apr 23

loh.tar added a comment to D20606: Add action to toggle folding of child ranges.

I would prefer a context menu that has this as action. This is much better discoverable and also extensible with more folding actions.

I agree. Right-click should show a context menu. Middle-click could toggle, if you need it.

Tue, Apr 23, 8:33 PM · Frameworks, Kate
loh.tar committed R39:57781f34d234: Review IconBorder (authored by loh.tar).
Review IconBorder
Tue, Apr 23, 7:48 PM
loh.tar closed D20697: Review IconBorder.
Tue, Apr 23, 7:48 PM · Frameworks, Kate
loh.tar updated the diff for D20697: Review IconBorder.

try to fix annotation issue

Tue, Apr 23, 7:20 PM · Frameworks, Kate

Mon, Apr 22

loh.tar added a comment to D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.

I'm sorry, I couldn't reproduce the crash to verify your patch. But at least cause it on the first sight no new crash here :-)

Mon, Apr 22, 8:35 PM · Kate
loh.tar committed R39:d9171c391267: Paint the folding marker in proper color and make it more visible (authored by loh.tar).
Paint the folding marker in proper color and make it more visible
Mon, Apr 22, 8:06 PM
loh.tar closed D20742: Paint the folding marker in propper color and make it more visible .
Mon, Apr 22, 8:06 PM · Frameworks, Kate
loh.tar requested review of D20742: Paint the folding marker in propper color and make it more visible .
Mon, Apr 22, 5:52 PM · Frameworks, Kate
loh.tar added a comment to D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.

hm, can't say much helpful to your patch. Send you my BT.
But from my point of view is this assert here redundant. When you dislike my check, you can drop the assert anyway.

Mon, Apr 22, 4:39 PM · Kate
loh.tar added a comment to D20697: Review IconBorder.

Did you test that the annotation border still works? You can do so in KDevelop by invoking git blame.

Mon, Apr 22, 7:40 AM · Frameworks, Kate
loh.tar added a comment to D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.

Out of the blue run I into this issue.
The only slightly unusual before was, that I had a confirmation box regarding an unsaved file while quit the session. Then, when I want to restart the same session, it crached always.
If you like I can submit the BT, but think it's not needed to approve this patch.

Mon, Apr 22, 7:39 AM · Kate
loh.tar requested review of D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.
Mon, Apr 22, 7:34 AM · Kate
loh.tar added a comment to D20697: Review IconBorder.

@dhaumann Beside these annotation stuff I think I'm done with this now. Should you, or someone else, not stop me in the next few days I may treat this as OK and push it.
There are still some issues in the mouse move handling but will try to fix that in some other patch

Mon, Apr 22, 5:48 AM · Frameworks, Kate
loh.tar updated the test plan for D20697: Review IconBorder.
Mon, Apr 22, 5:43 AM · Frameworks, Kate
loh.tar updated the diff for D20697: Review IconBorder.
  • Fix bookmark pixmap painting

Left before, right with fix

Mon, Apr 22, 5:40 AM · Frameworks, Kate
loh.tar updated the diff for D20697: Review IconBorder.
  • Add margin to the edit area, but I'm not sure if it should be done here. I guess renderer should do it
  • Simplify "additional folding highlighting", there is now the slightly gradient gone, bad?
  • Rename backGroundColor->iconBarColor to fit orig name, but that name sounds to me as it's only for the icon area of the border

Mon, Apr 22, 4:45 AM · Frameworks, Kate

Sun, Apr 21

loh.tar added a comment to D20264: Add test for "Auto Reload Document" option.

@dhaumann asked elsewhere

Sun, Apr 21, 9:18 AM · Frameworks, Kate
loh.tar updated the diff for D20697: Review IconBorder.
  • Fix missing printed background in proper theme color
  • Fix scroll past end of document
  • Fix less pushy paint unfolded icon in not dark themes and don't try to use currentLineNumberColor, the folded icon gets also not highligted
  • Some more cosmetic

Sun, Apr 21, 7:00 AM · Frameworks, Kate

Sat, Apr 20

loh.tar updated the test plan for D20697: Review IconBorder.
Sat, Apr 20, 12:34 PM · Frameworks, Kate
loh.tar requested review of D20697: Review IconBorder.
Sat, Apr 20, 12:29 PM · Frameworks, Kate
loh.tar abandoned D20565: Ensure not to fold the end marker.

Patch is part of D20606

Sat, Apr 20, 11:31 AM · Frameworks, Kate
loh.tar closed D20606: Add action to toggle folding of child ranges.
Sat, Apr 20, 11:27 AM · Frameworks, Kate
loh.tar committed R39:5c83e29561e3: Add action to toggle folding of child ranges (authored by loh.tar).
Add action to toggle folding of child ranges
Sat, Apr 20, 11:27 AM
loh.tar committed R39:f5f715ea1441: Add test for "Auto Reload Document" option (authored by loh.tar).
Add test for "Auto Reload Document" option
Sat, Apr 20, 11:27 AM
loh.tar closed D20264: Add test for "Auto Reload Document" option.
Sat, Apr 20, 11:27 AM · Frameworks, Kate

Thu, Apr 18

loh.tar updated the diff for D20606: Add action to toggle folding of child ranges.
  • Add menu action
  • Replace old two actions "Fold/Unfold Current Node" by "Toggle Current Node"
  • Move logic to ViewPrivate
  • KateBuffer: Add checks where they should be
Thu, Apr 18, 1:33 PM · Frameworks, Kate

Wed, Apr 17

loh.tar added a comment to D20606: Add action to toggle folding of child ranges.

hm, there is already a folding action in the View menu.
I understood Dominik so, not to add a context menu to the icon border, but to add the action to the context menu of the "edit range".
Whatever, as said I'm not in the mood for that, and it should be done in a 2nd patch, when needed.
But a context menu on the icon border would I very much dislike. Middle click is not so handy and perform atm "paste to begin of line"

Wed, Apr 17, 3:50 PM · Frameworks, Kate
loh.tar updated the diff for D20606: Add action to toggle folding of child ranges.
  • Add docu to header, not full happy with
  • Add desired adjustment checks
  • Make toggleFoldingInRange more action friendly
    • Add first try to unfold range itself into toggleFoldingInRange
    • Be a smart ass, minimize if nesting in mouseReleaseEvent
  • Fix to eager toggleFoldingInRange, don't fold else part when written on one line } else {
Wed, Apr 17, 3:35 PM · Frameworks, Kate

Tue, Apr 16

loh.tar added a comment to D20606: Add action to toggle folding of child ranges.

Oh, may that fit too?
Bug 352868 - Folding for all nodes (not just top-level) and/or siblings to current

Tue, Apr 16, 4:54 PM · Frameworks, Kate
loh.tar added a comment to D20606: Add action to toggle folding of child ranges.

A possible improvement could be to add slots to make the folding accessible by some keyboard action, but I'm not in the mood for that now.
Bug 343060 - global folding code keyboard shortcuts

Tue, Apr 16, 4:51 PM · Frameworks, Kate
loh.tar added a comment to D20606: Add action to toggle folding of child ranges.

This patch supersedes D20565

Tue, Apr 16, 4:39 PM · Frameworks, Kate
loh.tar requested review of D20606: Add action to toggle folding of child ranges.
Tue, Apr 16, 4:38 PM · Frameworks, Kate

Mon, Apr 15

loh.tar updated the diff for D20565: Ensure not to fold the end marker.
  • Adjust only on token based folding
Mon, Apr 15, 3:30 PM · Frameworks, Kate
loh.tar requested review of D20565: Ensure not to fold the end marker.
Mon, Apr 15, 5:04 AM · Frameworks, Kate

Sun, Apr 14

loh.tar added a comment to D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'.

Yes! A short test looked very promising.
Will play a little more, because had done some changes to this patch here :-/

Sun, Apr 14, 1:11 PM · Frameworks, Kate
loh.tar added a comment to D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'.

Looks to me a call to KateLayoutCache::updateViewCache may help at some point.
But have no idea where to place and with which parms.
In KateLayoutCache::displayViewLine is "limit=0" on second call.

Sun, Apr 14, 11:53 AM · Frameworks, Kate
loh.tar added a comment to D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'.

Did anyone tried this patch?
While coding my focus was only on behavior while enter text. Now I notice that the folding is "broken" in a way that the view jumps to the bottom :-S

Sun, Apr 14, 7:13 AM · Frameworks, Kate

Sat, Apr 13

loh.tar committed R39:78a2e5d1daa5: DocumentPrivate: Respect indention mode when block selection (authored by loh.tar).
DocumentPrivate: Respect indention mode when block selection
Sat, Apr 13, 6:11 PM
loh.tar closed D19450: DocumentPrivate: Respect indention mode when block selection.
Sat, Apr 13, 6:11 PM · Frameworks, Kate
loh.tar abandoned D19511: ViewPrivate: Disable read-only mode action when doc is modified.

To relieve the maintainer it's droped now.
But I still have the feeling there could be something improved at these "Read-Only Stuff"

Sat, Apr 13, 2:36 PM · Frameworks, Kate
loh.tar committed R39:cfb0af25bdfa: ViewInternal: Fix makeVisible(..) (authored by loh.tar).
ViewInternal: Fix makeVisible(..)
Sat, Apr 13, 2:20 PM
loh.tar closed D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'.
Sat, Apr 13, 2:20 PM · Frameworks, Kate
loh.tar updated the diff for D19450: DocumentPrivate: Respect indention mode when block selection.
  • Rebase on master
Sat, Apr 13, 8:39 AM · Frameworks, Kate
loh.tar committed R39:dc0e01ce0915: Fix testAutoBrackets (authored by loh.tar).
Fix testAutoBrackets
Sat, Apr 13, 7:26 AM
loh.tar updated the diff for D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.
  • Rebase on master to keep it compile
  • Not further investigated if changes by D19163 needs more tweeks here
Sat, Apr 13, 7:07 AM · Frameworks, Kate

Fri, Apr 12

loh.tar added a comment to D20264: Add test for "Auto Reload Document" option.

I spend a couple of time for this stuff.
Would be nice someone else could try it or do some investigation with tools I'm not familiar with, and don't want to be atm. Without feedback I will push it in the next few days.

Fri, Apr 12, 11:22 PM · Frameworks, Kate
loh.tar committed R39:8f0813f6c7ed: DocumentPrivate: Make bracket handling smart (authored by loh.tar).
DocumentPrivate: Make bracket handling smart
Fri, Apr 12, 10:34 PM
loh.tar closed D19608: DocumentPrivate: Make bracket handling smart.
Fri, Apr 12, 10:34 PM · Frameworks, Kate
loh.tar committed R39:1a0da40ae3da: ViewInternal: Review drop event (authored by loh.tar).
ViewInternal: Review drop event
Fri, Apr 12, 9:47 PM
loh.tar closed D19691: ViewInternal: Review drop event.
Fri, Apr 12, 9:47 PM · Frameworks, Kate
loh.tar added a comment to D20264: Add test for "Auto Reload Document" option.

I think KateViewInternal::updateView is called for cursor blinking for instance. May that be an issue?

Fri, Apr 12, 3:09 PM · Frameworks, Kate
loh.tar requested review of D20495: KateIconBorder: Fix folding popup width and height.
Fri, Apr 12, 2:50 PM · Frameworks, Kate

Thu, Apr 11

loh.tar committed R39:c95655f845da: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator (authored by loh.tar).
KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator
Thu, Apr 11, 12:32 PM
loh.tar closed D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator.
Thu, Apr 11, 12:32 PM · Frameworks, Kate
loh.tar committed R39:6ba329f8d451: KateIconBorder: Ensure Dyn Wrap Marker are shown (authored by loh.tar).
KateIconBorder: Ensure Dyn Wrap Marker are shown
Thu, Apr 11, 3:40 AM
loh.tar closed D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown.
Thu, Apr 11, 3:40 AM · Frameworks, Kate
loh.tar committed R39:6906368aa6b3: KateIconBorder: Code cosmetic (authored by loh.tar).
KateIconBorder: Code cosmetic
Thu, Apr 11, 3:40 AM
loh.tar closed D20425: KateIconBorder: Code cosmetic.
Thu, Apr 11, 3:40 AM · Frameworks, Kate, KTextEditor
loh.tar updated the diff for D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator.
  • Use unicode code point QChar constructor
  • Due to comment by @cfeck remove fallback/config hint and...
  • Init in header as const
  • Add hint about different char sizes
Thu, Apr 11, 3:21 AM · Frameworks, Kate

Wed, Apr 10

loh.tar added a comment to D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator.

Diff on top of D20425/D20431

Wed, Apr 10, 2:05 PM · Frameworks, Kate
loh.tar requested review of D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator.
Wed, Apr 10, 2:02 PM · Frameworks, Kate
loh.tar added a comment to D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown.

Diff on top of D20425, not sure if depend on

Wed, Apr 10, 1:42 PM · Frameworks, Kate
loh.tar requested review of D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown.
Wed, Apr 10, 1:42 PM · Frameworks, Kate
loh.tar requested review of D20425: KateIconBorder: Code cosmetic.
Wed, Apr 10, 5:20 AM · Frameworks, Kate, KTextEditor

Sun, Apr 7

loh.tar added a comment to D20343: fix handling of sub modules in git rely on ls-files --recurse-submodules, there since end of 2016.

Fix this Bug 398240 - Files appear twice in project view for some git projects ?
https://bugs.kde.org/show_bug.cgi?id=398240

Sun, Apr 7, 8:57 PM · Kate
loh.tar added a comment to D19926: Add Bookmark Handling.

a good compromise could be to put the "Bookmark" menu under the "Tools" menu.

Sun, Apr 7, 6:38 PM · Dolphin
loh.tar added a comment to D20357: Make buttons in seach bar nicer (icon, tooltip, autoselect).

I dislike tool tips :-(
Dolphin has only very few, and these are useful :-)

Sun, Apr 7, 6:33 PM · Dolphin
loh.tar committed R39:ad4cd4a72508: DocumentPrivate: Support auto bracket in block selection mode (authored by loh.tar).
DocumentPrivate: Support auto bracket in block selection mode
Sun, Apr 7, 2:01 PM
loh.tar closed D19446: DocumentPrivate: Support auto bracket in block selection mode.
Sun, Apr 7, 2:01 PM · Frameworks, Kate
loh.tar accepted D20343: fix handling of sub modules in git rely on ls-files --recurse-submodules, there since end of 2016.
Sun, Apr 7, 1:15 PM · Kate

Sat, Apr 6

loh.tar updated the diff for D20264: Add test for "Auto Reload Document" option.
  • Enhance the test by checks for proper cursor position
Sat, Apr 6, 4:27 PM · Frameworks, Kate

Fri, Apr 5

loh.tar added a comment to D19446: DocumentPrivate: Support auto bracket in block selection mode.

Edit: The issue is located here...

TextBlock::insertText(...)
...
        // special handling if cursor behind the real line, e.g. non-wrapping cursor in block selection mode
        else if (cursor->m_column < textOfLine.size()) {
            cursor->m_column = textOfLine.size();
        }
...
Fri, Apr 5, 1:20 PM · Frameworks, Kate
loh.tar requested review of D20264: Add test for "Auto Reload Document" option.
Fri, Apr 5, 12:53 PM · Frameworks, Kate

Thu, Apr 4

loh.tar added a comment to D19446: DocumentPrivate: Support auto bracket in block selection mode.

Feature or bug? Select in block mode from right->left on a single line after last char a block. The brackets are exchanged )( and placed at the end of the block

Hmm, I think this counts as a bug.

Have trouble to reproduce now. Was that fixed somewhere? Qt? Strange.

Thu, Apr 4, 1:26 PM · Frameworks, Kate

Wed, Apr 3

loh.tar updated the diff for D19446: DocumentPrivate: Support auto bracket in block selection mode.
  • Bring back call of view->slotTextInserted
Wed, Apr 3, 3:51 PM · Frameworks, Kate
loh.tar updated the diff for D19446: DocumentPrivate: Support auto bracket in block selection mode.
  • Ensure the new added brackets will not be part of the selection when selection was done from right->left
  • Enhance autotest
Wed, Apr 3, 2:51 PM · Frameworks, Kate

Tue, Apr 2

loh.tar updated the diff for D19446: DocumentPrivate: Support auto bracket in block selection mode.
  • Set proper start/end column independent from selection direction.
Tue, Apr 2, 7:32 PM · Frameworks, Kate
loh.tar committed R39:81a8d573ecaf: DocumentPrivate: Add option "Auto Reload Document" to View menu (authored by loh.tar).
DocumentPrivate: Add option "Auto Reload Document" to View menu
Tue, Apr 2, 5:50 PM
loh.tar closed D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt.
Tue, Apr 2, 5:50 PM · Frameworks, Kate
loh.tar updated the diff for D19446: DocumentPrivate: Support auto bracket in block selection mode.
  • QCOMPARE also the selection in tests
Tue, Apr 2, 2:41 PM · Frameworks, Kate
loh.tar added a comment to D19446: DocumentPrivate: Support auto bracket in block selection mode.

Feature or bug? Select in block mode from right->left on a single line after last char a block. The brackets are exchanged )( and placed at the end of the block

Hmm, I think this counts as a bug.

Tue, Apr 2, 2:31 PM · Frameworks, Kate
loh.tar updated the diff for D19446: DocumentPrivate: Support auto bracket in block selection mode.
  • Add some auto tests
Tue, Apr 2, 2:18 PM · Frameworks, Kate
loh.tar updated the diff for D19446: DocumentPrivate: Support auto bracket in block selection mode.
  • Rebase on master
Tue, Apr 2, 1:10 PM · Frameworks, Kate

Mon, Apr 1

loh.tar added a comment to D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt.

As you see, not only the menu is changed, so I update this diff for your approval.

Mon, Apr 1, 3:25 PM · Frameworks, Kate
loh.tar updated the diff for D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt.
  • Ensure the view jumps not back when user scrolls around
  • Don't reload while user scrolls
  • Fix missing connect to auto reload slot when enabled by modOnHdHandler
  • Change menu
Mon, Apr 1, 3:19 PM · Frameworks, Kate

Sun, Mar 31

loh.tar committed R39:135269639e70: Fix to previous commit eb90ca52 (authored by loh.tar).
Fix to previous commit eb90ca52
Sun, Mar 31, 2:18 PM
loh.tar committed R39:eb90ca5231f4: DocumentPrivate: Support to set dictionary on block selection (authored by loh.tar).
DocumentPrivate: Support to set dictionary on block selection
Sun, Mar 31, 1:04 PM
loh.tar closed D19425: DocumentPrivate: Support to set dictionary on block selection.
Sun, Mar 31, 1:04 PM · Frameworks, Kate
loh.tar added a comment to D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt.

Could the "view_auto_follow" be implemented in a second review after this is commited?

Sun, Mar 31, 12:36 PM · Frameworks, Kate

Thu, Mar 28

loh.tar added a comment to D20083: Multiple level of autobrace.

This patch looks similar to D12295
My suggestion to the issue D19608

Thu, Mar 28, 5:47 AM · Frameworks, Kate

Mar 26 2019

loh.tar committed R40:5d28eaaf9041: PreviewWidget: Avoid preview update when doc type is not supported (authored by loh.tar).
PreviewWidget: Avoid preview update when doc type is not supported
Mar 26 2019, 2:34 PM
loh.tar closed D19637: PreviewWidget: Avoid preview update when doc type is not supported.
Mar 26 2019, 2:34 PM · Kate

Mar 24 2019

loh.tar added a comment to D18793: Handle text completion with block selection mode.

Fix this patch also Bug 382213 ?

No, it doesn't fix it.

Mar 24 2019, 2:33 PM · Frameworks, Kate

Mar 17 2019

loh.tar added a comment to D19785: DocumentPrivate: Review del/backspace.

I had recently submit a patch which was also affected by RTL text D19621. Should this patch here be accepted I can upload my current state of the mentioned playing, which works similar as that D19621. It's for me very frustrating to test because I never know what is to be expect or what currently happens. Your Qt report make it even worse.

Mar 17 2019, 7:03 PM · Frameworks, Kate
loh.tar added a comment to D19771: Use placeholder instead of label.

Not answered are the questions about the removed label

The idea is that we don't need a label if there's appropriate placeholder text.

Mar 17 2019, 6:23 AM · Frameworks, Kate