loh.tar (loh tar)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 23 2018, 3:22 PM (29 w, 4 d)
Availability
Available

Recent Activity

Today

loh.tar requested review of D19051: [RFC]DocumentPrivate: Auto unwrap line when text is removed.
Fri, Feb 15, 7:11 PM · Frameworks, Kate

Yesterday

loh.tar updated the diff for D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable.
  • Add autotest
  • Don't wrap twice when static wrap is set to avoid bad result
Thu, Feb 14, 2:31 PM · Frameworks, Kate
loh.tar added inline comments to D18744: Add action in Edit menu to select the text on current page.
Thu, Feb 14, 6:26 AM · Documentation, Okular

Wed, Feb 13

loh.tar added a comment to D17599: Confirm closing muliple tabs..

Have other still issues with this patch?

Wed, Feb 13, 2:26 PM · Kate

Sun, Feb 10

loh.tar added a comment to D18894: [RFC] General config interface.

Contrary to my announcement to use an enum as key I chosed the string for maximum simplicity.
Yes, this way you notice a typo only at runtime, but in any case you have to know how some stuff has to be written. An enum key offer not only complile time checks but also to use QVector instead of QHash which may be more perfomand but need some more effort when add new stuff and probably longer longer keys, prefixed by namespace.

Sun, Feb 10, 4:17 PM · Frameworks, Kate
loh.tar requested review of D18894: [RFC] General config interface.
Sun, Feb 10, 9:21 AM · Frameworks, Kate

Wed, Feb 6

loh.tar added a comment to D18744: Add action in Edit menu to select the text on current page.

Here a link how it is done in Kate/KTextEditor
https://cgit.kde.org/ktexteditor.git/tree/src/view/kateviewinternal.cpp#n2710

Wed, Feb 6, 2:45 PM · Documentation, Okular

Tue, Feb 5

loh.tar added a comment to D18744: Add action in Edit menu to select the text on current page.

I suggest:

Tue, Feb 5, 4:22 PM · Documentation, Okular
loh.tar updated the diff for D18117: DocManager: Don't show load trouble popup messages .
  • rebase on master
Tue, Feb 5, 2:31 PM · Kate

Mon, Feb 4

loh.tar updated the diff for D18116: Add TODO KF6 note .
  • Move to correct function
Mon, Feb 4, 7:14 PM · Frameworks, Kate

Sun, Feb 3

loh.tar updated the diff for D18125: KateStatusBar: Add dictionary button.
  • Apply nullptr check
  • Add non preferred dict to menu chose by user
  • Reorder actions
  • Remove gone "Spellcheck Selection" action
Sun, Feb 3, 11:50 AM · Frameworks, Kate
loh.tar added a comment to D17599: Confirm closing muliple tabs..
  1. Remove "Cancel" button
Sun, Feb 3, 9:22 AM · Kate
loh.tar set the repository for D18117: DocManager: Don't show load trouble popup messages to R40 Kate.
Sun, Feb 3, 7:55 AM · Kate
loh.tar added a comment to D18116: Add TODO KF6 note .

Just to be sure:

We can apply D18117 and don't need to change here anything or?

Sun, Feb 3, 7:53 AM · Frameworks, Kate
loh.tar updated the diff for D18116: Add TODO KF6 note .
  • Revert all
  • Add TODO KF6 note to header
  • Update Summary
Sun, Feb 3, 7:50 AM · Frameworks, Kate

Sat, Feb 2

loh.tar added a comment to D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection".

For my taste could be "Spelling (from cursor)" the only offered action (logic). Always to check from the start is rarely useful, but I guess no one like that idea.

Sat, Feb 2, 8:42 AM · Frameworks, Kate
loh.tar requested review of D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection".
Sat, Feb 2, 8:35 AM · Frameworks, Kate

Fri, Feb 1

loh.tar updated the diff for D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable.
  • Move logic into document
  • Tiny docu fix + cosmettic
Fri, Feb 1, 2:46 PM · Frameworks, Kate

Wed, Jan 30

loh.tar added a comment to D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option.

I often struggle with QtCreator but I can't remember what happens there, sorry.

Wed, Jan 30, 6:20 PM · Frameworks, Kate
loh.tar added a comment to D18317: Display an error message if loading a dictionary fails.

My observations:

Wed, Jan 30, 3:20 PM · Frameworks

Fri, Jan 25

loh.tar added a comment to D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable.

also don't change the behavior of wordwrapping that is used by the view compared to what we would get by calling wordwrap on the document directly

Fri, Jan 25, 2:31 PM · Frameworks, Kate

Thu, Jan 24

loh.tar added a comment to D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection.

If you want to get this behavior for Markdown

Thu, Jan 24, 4:36 PM · Frameworks, Kate
loh.tar added a comment to D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection.

There is an enum KSyntaxHighlighting::Theme::TextStyle::Operator but I can't find a function to test for that.
Beside that I guess it would not work anyway. If it's an operator or not need a call to some "update highlight" to investigate the context.

Thu, Jan 24, 2:14 PM · Frameworks, Kate
loh.tar added a comment to D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection.

the selection becomes wrapped in two ? - is that right?

Thu, Jan 24, 6:29 AM · Frameworks, Kate

Wed, Jan 23

loh.tar updated the diff for D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable.
  • Update 'What's This' hint to reflect new behaviour and to be more precise
  • Update 'What's This' hint of dyn wrap too to be more precise
  • Update/clear Summary
Wed, Jan 23, 2:39 PM · Frameworks, Kate

Tue, Jan 22

loh.tar updated the diff for D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable.
  • Use std::unique_ptr for the cursor
  • Oops!? Use 'if' instead of unneeded 'while' loop which also avoid 'goto'
Tue, Jan 22, 8:13 PM · Frameworks, Kate
loh.tar updated the diff for D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection.
  • const QChar as value, not reference
  • Add , ; - + ^ ° § & just for completeness
Tue, Jan 22, 2:26 PM · Frameworks, Kate

Mon, Jan 21

loh.tar updated the diff for D18116: Add TODO KF6 note .
  • Don't set m_openingErrorMessage in KateBuffer::openFile
  • m_openingErrorMessage is now nowhere set
Mon, Jan 21, 9:34 PM · Frameworks, Kate
loh.tar updated the diff for D18117: DocManager: Don't show load trouble popup messages .
  • Only set "no success" when doc is empty
  • Remove unneded stuff
Mon, Jan 21, 9:26 PM · Kate
loh.tar added a comment to D18117: DocManager: Don't show load trouble popup messages .

> A really new file would be closed too.

Mon, Jan 21, 3:24 PM · Kate
loh.tar added a comment to D18117: DocManager: Don't show load trouble popup messages .

So, well, yes, without to change the logic in D18116 (but still apply that to remove unneded text) it work as needed.

Mon, Jan 21, 2:53 PM · Kate
loh.tar added a comment to D18117: DocManager: Don't show load trouble popup messages .
  • if we just keep the code in ktexteditor as is
  • we should just set openSuccess to false if we have an doc->openingError() and the document is empty
Mon, Jan 21, 6:15 AM · Kate
loh.tar added a comment to D18125: KateStatusBar: Add dictionary button.

m_dictionaryGroup->checkedAction() might be null.

Mon, Jan 21, 5:53 AM · Frameworks, Kate
loh.tar added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

are you interested in that challenge, too?

Mon, Jan 21, 5:34 AM · Frameworks, Kate
loh.tar added a comment to D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file.

But on the other side: how does one reproduce this?

Mon, Jan 21, 5:28 AM · Frameworks, Kate

Sat, Jan 19

loh.tar added a comment to D18317: Display an error message if loading a dictionary fails.

Well, I'm not a Sonnet Guru, more a normal user. Sorry if it sounds so. I can't give a detailed point how to solve some particular issue.

Sat, Jan 19, 3:29 PM · Frameworks

Fri, Jan 18

loh.tar added a comment to D18317: Display an error message if loading a dictionary fails.

Just my thoughts:

Fri, Jan 18, 2:11 PM · Frameworks

Thu, Jan 17

loh.tar updated the diff for D17459: SearchBar: Add Cancel button to stop long running tasks.
  • Fix to pass autotest
Thu, Jan 17, 9:15 PM · Frameworks, Kate

Jan 16 2019

loh.tar updated the diff for D18164: Review KateGotoBar.
  • Connect/Disconnect
  • Remove m_gotoRange->setFocus
Jan 16 2019, 8:00 PM · Frameworks, Kate
loh.tar updated the diff for D18164: Review KateGotoBar.
  • Morph updateData() into a slot
  • connect to Document::textChanged signal
Jan 16 2019, 4:32 PM · Frameworks, Kate
loh.tar added a comment to D18117: DocManager: Don't show load trouble popup messages .

I think this is not sufficient. These "openingError()" is somewhere used to change the document icon. So I believe there is a need to change this to an (u)int value, 0=good, 1=someTrouble, 3=seriousProblem=orphaned

Jan 16 2019, 4:12 PM · Kate
loh.tar updated subscribers of D18125: KateStatusBar: Add dictionary button.

@cullmann @dhaumann A short not how to progress would be nice.

Jan 16 2019, 4:01 PM · Frameworks, Kate
loh.tar updated the diff for D18164: Review KateGotoBar.
  • Fix typo of member vars
  • Add missing setView(m_view)
  • Remove FIXME hint about timer, however would a comment for me nice
  • Use QString()
Jan 16 2019, 2:21 PM · Frameworks, Kate
loh.tar added a comment to D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable.

Interesting. Didn't know that such function exist. Well, it may help to read the handbook...
Is there no GUI way to access such stuff? "Read the handbook" lala...

Jan 16 2019, 6:17 AM · Frameworks, Kate

Jan 15 2019

loh.tar added a comment to D18164: Review KateGotoBar.

I have the feeling it adds more clutter than it helps by default:

Jan 15 2019, 8:14 PM · Frameworks, Kate
loh.tar added a comment to T10281: Create an "Outline View".

Display other variables found in CMakeCache

Jan 15 2019, 3:34 PM · Kate
loh.tar added a comment to D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines.

can you please rephrase the title of this review to make it understandable?

Jan 15 2019, 3:24 PM · Frameworks, KTextEditor, Kate
loh.tar updated subscribers of D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable.

please add proper tests for this functionality

No idea how

Jan 15 2019, 3:08 PM · Frameworks, Kate
loh.tar added a comment to D18083: Search plugin: Extend tooltip for the Regular Expressions switch.

The search plugin is already cluttered with a lot of buttons...

Jan 15 2019, 2:27 PM · Kate
loh.tar updated the diff for D17852: ViewInternal: Fix 'Go to matching bracket' in override mode .

Add autotest

Jan 15 2019, 2:16 PM · Frameworks, Kate

Jan 14 2019

loh.tar updated the diff for D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection.
  • Add chars ´ ` _ . : | # @ ~ * ! ? $ % / \ = to special handling
  • Avoid chars[0]
Jan 14 2019, 3:50 PM · Frameworks, Kate
loh.tar added a comment to T10281: Create an "Outline View".

I discussed this name ("Outline View") with someone else and it should be fine. See for example...

Jan 14 2019, 1:59 PM · Kate

Jan 13 2019

loh.tar added a comment to T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search).

Your perception is clear, we have always some result to navigate in, make sense.

Jan 13 2019, 4:16 PM · KTextEditor
loh.tar added a comment to D18083: Search plugin: Extend tooltip for the Regular Expressions switch.

The shots are looking to me great! :-)
As said, that should be available at KDE scope, not only this plugin!

Jan 13 2019, 4:06 PM · Kate
loh.tar added a comment to T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search).

What do you think of the described idea to have a universal "next match" feature and shortcut?

Jan 13 2019, 3:46 PM · KTextEditor
loh.tar added a comment to T10320: Usage of the Build Plugin.

Hm, my workflow is somehow special too. So I guess the Gurus around here may chuckle. First, look at my plugin entries. So I think you have there something wrong.


To compile I hit my short-cut which will always run the market command. To start the new stuff I switch to a normal terminal where ONCE was "sourced" these script. That's all.

Jan 13 2019, 3:23 PM · Kate
loh.tar added a comment to D17443: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match.

Um, can't find here a hint that this is try to follow some "defined standard", like CUA. https://en.wikipedia.org/wiki/IBM_Common_User_Access

Jan 13 2019, 2:56 PM · Kate
loh.tar added a comment to D17730: Review KateStatusBar .

I like the new status bar.

Jan 13 2019, 6:12 AM · Frameworks, Kate
loh.tar added a comment to D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.

Sadly is the benefit, to reduce the menu entries, not "optimal". In the pics you have now 3 sub-entries for one "Variant" entry, effectively only 2 less per topic.

Jan 13 2019, 5:46 AM · Frameworks, Kate

Jan 12 2019

loh.tar added a comment to D18083: Search plugin: Extend tooltip for the Regular Expressions switch.

I didn't know this menu existed!

Jan 12 2019, 7:05 AM · Kate

Jan 11 2019

loh.tar added a comment to D18083: Search plugin: Extend tooltip for the Regular Expressions switch.

Can you make the RegExp tool-tip available only when we are in RegExp mode?

Jan 11 2019, 3:09 PM · Kate
loh.tar updated the diff for D18164: Review KateGotoBar.
  • Use 120 as wheel-delta threshold
  • Use member instead of static local
Jan 11 2019, 2:42 PM · Frameworks, Kate
loh.tar added a comment to D18164: Review KateGotoBar.

I was about to move StatusBarButton into kateviewhelpers, so that this button can used elsewhere too, like here. But got stuck. However, I think such button would be handy. Perhaps also a KateViewBarLayout.
Here shot regarding 'Change label text to be less redundant in conjunction with the "goto-button"' At least in German is that old text terrible.

Jan 11 2019, 6:26 AM · Frameworks, Kate

Jan 10 2019

loh.tar added a comment to D18125: KateStatusBar: Add dictionary button.

I'm very much against such a label, and against the full name.
"UTF-8" has also no label and that's good. The only stuff where a description label is needed are these line/column/word hints. Without a label are you almost lost to know which is what.

Jan 10 2019, 7:40 PM · Frameworks, Kate
loh.tar requested review of D18164: Review KateGotoBar.
Jan 10 2019, 6:52 PM · Frameworks, Kate

Jan 9 2019

loh.tar updated the diff for D18125: KateStatusBar: Add dictionary button.
  • Add missing signals to watch dict changes
  • Ensure button is set on first show
Jan 9 2019, 7:45 PM · Frameworks, Kate
loh.tar added a comment to D18125: KateStatusBar: Add dictionary button.

Isn't en_US too cryptic?

Well, yes.

Jan 9 2019, 5:03 PM · Frameworks, Kate
loh.tar added a comment to D18125: KateStatusBar: Add dictionary button.

The shown dictionary is sometimes "wrong"

Jan 9 2019, 3:25 PM · Frameworks, Kate
loh.tar requested review of D18125: KateStatusBar: Add dictionary button.
Jan 9 2019, 3:24 PM · Frameworks, Kate
loh.tar added a comment to D18117: DocManager: Don't show load trouble popup messages .

we can just skip the messaging always, we have always inline messages, I think that would be ok

Jan 9 2019, 5:56 AM · Kate

Jan 8 2019

loh.tar added a comment to D17852: ViewInternal: Fix 'Go to matching bracket' in override mode .

Nice trick ;-) Can't promise to do it, will see

Jan 8 2019, 8:03 PM · Frameworks, Kate
loh.tar added a comment to D17730: Review KateStatusBar .

It was stated that it broke tests, should this be addressed now?

Jan 8 2019, 8:00 PM · Frameworks, Kate
loh.tar requested review of D18117: DocManager: Don't show load trouble popup messages .
Jan 8 2019, 7:49 PM · Kate
loh.tar added a comment to D18116: Add TODO KF6 note .

I have it only poor tested with our big S&R file, so no test was made with other trouble causing stuff.
This need a patch in Kate, will try to link that

Jan 8 2019, 7:45 PM · Frameworks, Kate
loh.tar requested review of D18116: Add TODO KF6 note .
Jan 8 2019, 7:41 PM · Frameworks, Kate
loh.tar added a comment to D17999: ViewConfig: Add option to paste at cursor position by mouse.

"Paste by mouse at cursor position" should be ok, then I will push this, ok?

Jan 8 2019, 3:56 PM · Frameworks, Kate
loh.tar updated the diff for D17999: ViewConfig: Add option to paste at cursor position by mouse.

Back to "Paste by mouse at cursor position"

Jan 8 2019, 3:55 PM · Frameworks, Kate
loh.tar added a comment to D17999: ViewConfig: Add option to paste at cursor position by mouse.

Sure, can do it. Which one have it to be ?

  • Paste clipboard contents at cursor location
  • Paste clipboard contents at cursor position
  • Paste by mouse at cursor position (This one was liked by Dominik, IIRC)
Jan 8 2019, 3:47 PM · Frameworks, Kate
loh.tar added a comment to D17999: ViewConfig: Add option to paste at cursor position by mouse.

To avoid further comments I like to add that I don't like to do the requested change. Please improve it later, if needed.

Jan 8 2019, 3:32 PM · Frameworks, Kate
loh.tar added inline comments to D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines.
Jan 8 2019, 3:26 PM · Frameworks, KTextEditor, Kate
loh.tar updated the diff for D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines.

Try to be smart

Jan 8 2019, 3:19 PM · Frameworks, KTextEditor, Kate

Jan 7 2019

loh.tar added a comment to D17999: ViewConfig: Add option to paste at cursor position by mouse.

I agree, it's on the first sight pretty clear. But then can you force this "style" for every bool option. In the above linked pic is this obviously only used for Normal vs Vi-Mode [1]

Jan 7 2019, 10:21 PM · Frameworks, Kate
loh.tar added a comment to T10281: Create an "Outline View".

Yes, my English is bad. But "Outline View" sound to me less fitting than my "Index View". But when I look at your notes below CMake you seems to have in mind to traverse the directory and search some stuff. Obviously similar to the CTag plugin, which I have never tested. (Ha, only noted recently what it is due to its odd description in the Kate config page). So then may your name indeed fit better.

Jan 7 2019, 6:31 AM · Kate

Jan 6 2019

loh.tar added a comment to D17310: Use a Kile Icon that is similar to the original.

Yes looks nice.
Would be good as icon for the Kile Handbook, for the application I would omit/avoid the "Notebook" look.

Jan 6 2019, 5:32 PM · Frameworks
loh.tar updated the diff for D17730: Review KateStatusBar .
  • Remove not supported Rich Text from [BLOCK] hint
  • Add word count info to line label
Jan 6 2019, 5:26 PM · Frameworks, Kate
loh.tar added a comment to D12295: Supporting nested brackets for Kate autobrackets.

I didn't test it even more but think on it from time to time. If my slightly negative comment was OK or too fast judged. And yes it may.

Jan 6 2019, 2:03 PM · Frameworks, KTextEditor, Kate
loh.tar added a comment to D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection.

Will wait for further advice

Still waiting if I have to undo these reference stuff. (Yes your are busy. Just only wanted it to emphasize)
Besides, I like to add some more chars to this special handling:

_ : # @ ~ * ! $ % / \

Some of these may handy when write Markdown, some perhaps elsewhere

Jan 6 2019, 11:23 AM · Frameworks, Kate
loh.tar added a comment to D17999: ViewConfig: Add option to paste at cursor position by mouse.

Hm, didn't you switch the meaning...

Jan 6 2019, 10:57 AM · Frameworks, Kate
loh.tar updated the diff for D17730: Review KateStatusBar .

Allow StatusBarButton to shrink

Jan 6 2019, 6:16 AM · Frameworks, Kate
loh.tar updated the diff for D17999: ViewConfig: Add option to paste at cursor position by mouse.

Change checkbox text as suggested

Jan 6 2019, 4:54 AM · Frameworks, Kate

Jan 5 2019

loh.tar added a comment to D17999: ViewConfig: Add option to paste at cursor position by mouse.

Please provide also a tooltip/whats-this text, if useful. My QtDesigner did not show the needed widget stuff, so the text is not set.
A look at that bug report may give more hints/ideas

Jan 5 2019, 10:43 PM · Frameworks, Kate
loh.tar added a comment to D17730: Review KateStatusBar .

@zetazeta wrote

I find it annoying that the status bar imposes a limit on the minimum width of the window

Jan 5 2019, 10:28 PM · Frameworks, Kate
loh.tar requested review of D17999: ViewConfig: Add option to paste at cursor position by mouse.
Jan 5 2019, 9:45 PM · Frameworks, Kate
loh.tar updated the diff for D17978: QuickOpenSession: Indicate clearly the active session .

Make actions checkable. I think you also prefer this to an "extra star solution".

Jan 5 2019, 3:00 PM · Kate
loh.tar added a comment to D17970: Fix broken Emmet.

May I ask a stupid question? Is the entire function needed? That's looks to me somehow like image/picture stuff but I don't find picture stuff in the Tool->Emmet menu.

Jan 5 2019, 2:06 PM · Frameworks, Kate
loh.tar added a comment to D17730: Review KateStatusBar .

That can I not really imagine :-/ Wouldn't that not somehow to be notice in normal use?
Let's try this. Shot without bar, Now choose "Show bar", The window didn't change. (Sorry, no tool at hand to paste pics together)
The bar can shrink almost endless.

Jan 5 2019, 1:56 PM · Frameworks, Kate
loh.tar added a comment to D17978: QuickOpenSession: Indicate clearly the active session .

This patch is somehow a leftover from early days.
Should you think to remove the current active session is a bad idea, let us them at least disable.

Jan 5 2019, 6:00 AM · Kate
loh.tar requested review of D17978: QuickOpenSession: Indicate clearly the active session .
Jan 5 2019, 5:59 AM · Kate

Jan 4 2019

loh.tar added a comment to D17970: Fix broken Emmet.

Well, if it is fixed I can't say. At least the error is gone and "Increment/Decrement" works.
May some guru investigate if its fixed. Obviously is there a problem with these string constants.

Jan 4 2019, 8:23 PM · Frameworks, Kate
loh.tar requested review of D17970: Fix broken Emmet.
Jan 4 2019, 8:22 PM · Frameworks, Kate