loh.tar (loh tar)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 23 2018, 3:22 PM (20 w, 1 d)
Availability
Available

Recent Activity

Today

loh.tar updated the diff for D17459: SearchBar: Add Cancel button to stop long running tasks.
  • Code cosmetic
  • Add singleShot stuff
Tue, Dec 11, 3:41 PM · Frameworks, Kate
loh.tar added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

everything could have happened, e.g. the search bar got deleted because the view got delete

Tue, Dec 11, 6:25 AM · Frameworks, Kate
loh.tar added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

I would also advise against calling processEvents()
It is something that comes up every once a while, but has just proven to be a bad idea over the last ten-something years.

Tue, Dec 11, 6:16 AM · Frameworks, Kate

Yesterday

loh.tar added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

Hmpf! Some googling didn't help. Just some thoughts.

Mon, Dec 10, 5:15 PM · Frameworks, Kate
loh.tar added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

That always leads to evil things, like e.g. what happens if you press the X button of the view/window during that.

Mon, Dec 10, 2:43 PM · Frameworks, Kate
loh.tar updated the diff for D17459: SearchBar: Add Cancel button to stop long running tasks.
  • Check every 500 lines or 100 machtes, whatever is first
  • Fix false check due to wrong math as long no match was found
Mon, Dec 10, 2:42 PM · Frameworks, Kate
loh.tar added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

I would probably not make the button that big

Mon, Dec 10, 2:08 AM · Frameworks, Kate

Sun, Dec 9

loh.tar added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

Not well tested but looks so far pretty promising.

Sun, Dec 9, 7:21 PM · Frameworks, Kate
loh.tar requested review of D17459: SearchBar: Add Cancel button to stop long running tasks.
Sun, Dec 9, 7:20 PM · Frameworks, Kate
loh.tar added a comment to D17030: DictionaryComboBox: Keep user preferred dictionaries on top.

Um, I'm bit confused when I now look at the diff 1/2 here???

Sun, Dec 9, 5:40 PM · Frameworks
loh.tar updated the diff for D17030: DictionaryComboBox: Keep user preferred dictionaries on top.
  • Add @since hint to speller.h
  • Add some blank lines to speller.h to be looking a little bit nicer
Sun, Dec 9, 5:37 PM · Frameworks
loh.tar added a comment to D17030: DictionaryComboBox: Keep user preferred dictionaries on top.

Ah, one thing: Could you add some @since 5.xxx to the new function in speller.h?

Sun, Dec 9, 5:29 PM · Frameworks
loh.tar added a comment to D16336: BuildView: Avoid to show ToolView when build is invoked.

I used this patch now for a while and most of the time it works (for me) charming. But there is some odd behaviour when you try to do some "no normal build" stuff. Then is these auto-close feature a little bit annoying.
So any tip is appreciated. Will look at it some time later.

Sun, Dec 9, 3:37 PM · Kate
loh.tar added a comment to D17441: tune editing actions for large number of small edits.

Yes, there is now a limit for how many highlightings are done.
If its too much, we skip that, else the rendering will break everthing down ;=)

Sun, Dec 9, 3:08 PM · Frameworks, Kate
loh.tar added a comment to D17437: SearchBar: Avoid malfunction with very large files.

In this state was this patch only a simple attempt to avoid the worst case.
With your new improvements is it much less likely to happen, but still possible. I do not like to insist of this patch it's only an offer, which could be improved.

Sun, Dec 9, 2:58 PM · Frameworks, Kate
loh.tar added a comment to D17441: tune editing actions for large number of small edits.

This needs now some user testing ;=)

Sun, Dec 9, 2:41 PM · Frameworks, Kate
loh.tar added inline comments to D17441: tune editing actions for large number of small edits.
Sun, Dec 9, 1:53 PM · Frameworks, Kate
loh.tar added a comment to D17441: tune editing actions for large number of small edits.

I have tried this one. Yes, works much more better!
Nice to see that my own (unloved) patch wake your interest to dig into that issue :-)

Sun, Dec 9, 4:35 AM · Frameworks, Kate

Sat, Dec 8

loh.tar added a comment to D17437: SearchBar: Avoid malfunction with very large files.

Would be good you take the time and do that test @cullmann When you then think it is still useful to soften that limit let me know how.
To become that code more smart as you suggest I have right now not the mood, sorry.
I think this patch is good enough to avaoid the biggest trouble.

Sat, Dec 8, 5:59 PM · Frameworks, Kate
loh.tar added a comment to D17437: SearchBar: Avoid malfunction with very large files.
  • The mentioned crash could I not reproduce, but after 5 million hits and a felt eternity I had killed Kate
  • There is an issue now with the wrap message, where is now the same close button. Any ideas what's wrong?
  • I like to suggest to get rid of most of that S&R code and use instead code from the Search plugin. There is the S&R done in an own thread and did not block the UI.
Sat, Dec 8, 5:48 PM · Frameworks, Kate
loh.tar requested review of D17437: SearchBar: Avoid malfunction with very large files.
Sat, Dec 8, 5:37 PM · Frameworks, Kate
loh.tar added a comment to D17428: ViewManager: Fix I18n_ARGUMENT_MISSING hint in message box when open a very large file.

That line is a little bit long. Let me know if I should wrap them in shorter pieces.

Sat, Dec 8, 1:20 PM · Kate
loh.tar requested review of D17428: ViewManager: Fix I18n_ARGUMENT_MISSING hint in message box when open a very large file.
Sat, Dec 8, 1:18 PM · Kate
loh.tar added a comment to D17128: DocumentPrivate: Remove comment mark when joining lines.

Thanks for your input Dominik.
In the meanwhile I noticed (again) these "Smart-Return" function (I noticed, and used that a couple of years for a short time period, but forgot that somehow) A reverse version of that should be nice. And somehow the possibility to use that automatically without to todo some special key-stroke when join lines by simple remove the newline character by Del-Key.

Sat, Dec 8, 10:49 AM · Frameworks, Kate, KTextEditor
loh.tar added a comment to D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style.

sorry for the delay :(

Sat, Dec 8, 9:59 AM · Frameworks, Kate
loh.tar updated subscribers of D9077: Bug 377342 Question.

@cullmann I thing you could give a short hint

Sat, Dec 8, 8:10 AM · Frameworks, KTextEditor, Kate
loh.tar updated the summary of D17030: DictionaryComboBox: Keep user preferred dictionaries on top.
Sat, Dec 8, 6:43 AM · Frameworks

Fri, Dec 7

loh.tar added a comment to D17030: DictionaryComboBox: Keep user preferred dictionaries on top.

Frameworks Ping! (?)

Fri, Dec 7, 11:12 PM · Frameworks
loh.tar updated the summary of D17418: SearchView: Harmonize text in searchPlaceCombo.
Fri, Dec 7, 10:24 PM · Kate
loh.tar added a comment to D17418: SearchView: Harmonize text in searchPlaceCombo.

Please add

BUG: 389181

To its own line in the Summary section. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

Fri, Dec 7, 10:21 PM · Kate
loh.tar requested review of D17418: SearchView: Harmonize text in searchPlaceCombo.
Fri, Dec 7, 9:32 PM · Kate

Thu, Dec 6

loh.tar added a comment to D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style.

Without any special "Oh, that would be nice", I will stop now with further S&R

Thu, Dec 6, 3:34 PM · Frameworks, Kate
loh.tar requested review of D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style.
Thu, Dec 6, 3:02 PM · Frameworks, Kate

Wed, Dec 5

loh.tar added a comment to D17257: KateViewInternal: S&R.

@cullmann Did you notice this? The other patches did you apply very quick, so I hope I didn't unsettle you with my comments.

Wed, Dec 5, 2:26 PM · Frameworks, Kate
loh.tar added a comment to D17244: Edit Profile Dialog UI redesign.

Just a hint/question from someone who didn't try this particular patch.

Wed, Dec 5, 6:27 AM · Konsole

Tue, Dec 4

loh.tar added a comment to D17138: Kate: File menu: Put Save, Print and Export actions into submenus.

I like the approach to move much into a 2nd level menu because I'm easy annoyed by long menus where I have to scan and move a long way down.

Tue, Dec 4, 3:19 PM · Kate

Mon, Dec 3

loh.tar added a comment to D17339: BuildView: Fix broken load of project plugin targets.
In D17339#370901, @sars wrote:

It is maybe not optimal to "hide" a bug fix among a bunch of code cosmetics

Mon, Dec 3, 8:11 PM · Kate
loh.tar requested review of D17339: BuildView: Fix broken load of project plugin targets.
Mon, Dec 3, 7:29 PM · Kate
loh.tar updated the diff for D17297: BuildView: Improve user information when build fails.
  • Updated as accepted
  • Cleared Test Plan to avoid unneded stuff in commit message
Mon, Dec 3, 4:18 AM · Kate

Sun, Dec 2

loh.tar added a comment to D17297: BuildView: Improve user information when build fails.

I think the text could be "Cannot run command: %1\nWork path %2 does not exist."

No sure if that's a request to me to change that, or only a thought for further discusion.
My taste is not to include the argument into the sentence, so I offer a slightly modification. Nevertheless looks that to me a little long.

Sun, Dec 2, 4:08 PM · Kate
loh.tar added a comment to D17297: BuildView: Improve user information when build fails.

The text (the look) may OK but I think could be improved. Please give exact advice.

Sun, Dec 2, 9:37 AM · Kate
loh.tar requested review of D17297: BuildView: Improve user information when build fails.
Sun, Dec 2, 9:34 AM · Kate
loh.tar requested review of D17296: SearchView: Fix missing signal/slot connection to project plugin.
Sun, Dec 2, 8:46 AM · Kate

Sat, Dec 1

loh.tar added a comment to D17028: Loader: Avoid Q_FOREACH.

@cfeck wrote:

It looked strange on the list of names of all committers.

Sat, Dec 1, 5:54 AM · Frameworks

Fri, Nov 30

loh.tar added a comment to D17028: Loader: Avoid Q_FOREACH.
..but I cannot remember we didn't ask contributors for their real name for contributions.
Fri, Nov 30, 9:45 PM · Frameworks
loh.tar added a comment to D17028: Loader: Avoid Q_FOREACH.

Well, neither of that. My "online me" is loh.tar but that was rejected by Phabricator, so the dot had to go. Lastly used ngraham uppercase letters, what looks even more strange to me :-)

Fri, Nov 30, 5:52 PM · Frameworks
loh.tar added a comment to D17028: Loader: Avoid Q_FOREACH.

@davidedmundson
May I ask how does this here will progress? You seemed to request a change which was not clear to me, but it's anyway "green flagged".

Fri, Nov 30, 3:04 PM · Frameworks
loh.tar added a comment to D17257: KateViewInternal: S&R.

Only 'm_view->' => 'view()' has plenty of hits, the others only a few.

Fri, Nov 30, 2:21 PM · Frameworks, Kate
loh.tar requested review of D17257: KateViewInternal: S&R.
Fri, Nov 30, 2:11 PM · Frameworks, Kate

Thu, Nov 29

loh.tar added a comment to D17237: KTextEditor::ViewPrivate: S&R.

I can split it if you like in two diff

  • 'm_doc->' => 'doc()->' ~100 hits, perhaps not the best idea? A search for doc() has 24 hits (without this patch)
  • 'm_viewInternal->m_cursor' => 'cursorPosition()' ~10 hits
Thu, Nov 29, 4:20 PM · Frameworks, Kate
loh.tar requested review of D17237: KTextEditor::ViewPrivate: S&R.
Thu, Nov 29, 4:17 PM · Frameworks, Kate
loh.tar updated the diff for D17193: KateViewInternal: Remove unneeded functions.
  • Prefer function calls for member excess
  • Merge KateViewInternal::updateView with KateViewInternal::doUpdateView
  • Add documentation to related functions and some near by cosmetic. Well, "Better no docu than bad docu", so if that is to difficult to check now, I can remove it and ship as own diff
  • Complete commit message
  • Remove Testplan, I'm always surpsised to see that later in the commit message
Thu, Nov 29, 2:37 PM · Frameworks, Kate

Wed, Nov 28

loh.tar added a comment to D17030: DictionaryComboBox: Keep user preferred dictionaries on top.

Bug302689 - Impossible to delete unwanted dictionaries
https://bugs.kde.org/show_bug.cgi?id=302689

Wed, Nov 28, 9:03 PM · Frameworks
loh.tar added a comment to D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button .

No, but that's fine. One thing less where I can make mistakes :-)
Should your next question be regarding author ship, take a look at edbf2e36c805
Thanks.

Wed, Nov 28, 8:52 PM · Frameworks
loh.tar added a comment to D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button .

Um, no(?) In that case I would have named this patch "Add stretch to ensure Dump button is expanding"
Sorry, next time I try to describe the pics more precise.

Wed, Nov 28, 7:17 PM · Frameworks
loh.tar added a reviewer for D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button : VDG.
Wed, Nov 28, 5:14 PM · Frameworks
loh.tar updated the diff for D17193: KateViewInternal: Remove unneeded functions.

I think that's all.
Well, it looks less beneficial as previous anticipated by me, but I think it's still the right direction.

Wed, Nov 28, 3:04 PM · Frameworks, Kate
loh.tar added a comment to D16926: Review user interaction in session management.

we can have more improvements...in a new patch.

Wed, Nov 28, 1:37 PM · Kate

Tue, Nov 27

loh.tar added a comment to D17013: Show menu bar, how to re-enable, common shortcut dialog.

Hi, I accidentally went by.
How about to add an icon to some (main) toolbar, if any is present?
That would the need to show such a message reduce to cases where no tool bar is available. If that icon was added, and not already there, could that pop up a small tool tip to get some attention.
A quick search here in my browser give no hit for "isVisible". There should be no need to show such message when the action is somewhere seen.

Tue, Nov 27, 5:40 PM · Frameworks
loh.tar requested review of D17193: KateViewInternal: Remove unneeded functions.
Tue, Nov 27, 4:54 PM · Frameworks, Kate
loh.tar updated the diff for D16926: Review user interaction in session management.
  • Remove comments as requested
  • Change Button text and icons as requested
  • Avoid gab of Close button to the bottom when window is smaller
Tue, Nov 27, 2:36 PM · Kate

Mon, Nov 26

loh.tar added a comment to D16926: Review user interaction in session management.

Still one should take the additional input into consideration ;=)

Mon, Nov 26, 4:50 PM · Kate
loh.tar added a comment to D16926: Review user interaction in session management.

To me, "Duplicate..." sounds more natural, and I don't think I've seen "Copy As..." in English in very many user interfaces.

Mon, Nov 26, 4:21 PM · Kate
loh.tar added a reviewer for D17030: DictionaryComboBox: Keep user preferred dictionaries on top: VDG.
Mon, Nov 26, 3:36 PM · Frameworks
loh.tar added a comment to D16926: Review user interaction in session management.

@ngraham Thanks for the VDG/screenshot advice, will hopefully remember that the next time :-)

Mon, Nov 26, 2:59 PM · Kate

Sun, Nov 25

loh.tar added a comment to D17128: DocumentPrivate: Remove comment mark when joining lines.

I am not sure if the normal join lines should try to be that clever.

Sun, Nov 25, 9:16 AM · Frameworks, Kate, KTextEditor
loh.tar updated the diff for D16926: Review user interaction in session management.

Glad to read that :-)

Sun, Nov 25, 6:49 AM · Kate

Sat, Nov 24

loh.tar added a comment to D16926: Review user interaction in session management.

I would like to avoid these Arcanist. But every hint what I have to be aware of is much apricated.

Sat, Nov 24, 6:48 PM · Kate
loh.tar added a reviewer for D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox: Frameworks.
Sat, Nov 24, 6:06 PM · Frameworks
loh.tar added a reviewer for D17055: Avoid Q_FOREACH: davidedmundson.
Sat, Nov 24, 6:05 PM · Frameworks
loh.tar added a reviewer for D17030: DictionaryComboBox: Keep user preferred dictionaries on top: Frameworks.
Sat, Nov 24, 6:02 PM · Frameworks
loh.tar added a reviewer for D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button : Frameworks.
Sat, Nov 24, 6:01 PM · Frameworks

Fri, Nov 23

loh.tar added a comment to D17128: DocumentPrivate: Remove comment mark when joining lines.

This works so far in most cases I have tried.

Fri, Nov 23, 11:01 PM · Frameworks, Kate, KTextEditor
loh.tar requested review of D17128: DocumentPrivate: Remove comment mark when joining lines.
Fri, Nov 23, 11:00 PM · Frameworks, Kate, KTextEditor
loh.tar requested review of D17123: KTextEditor::ViewPrivate: Avoid warning "Text requested for invalid range".
Fri, Nov 23, 3:45 PM · Frameworks, Kate

Thu, Nov 22

loh.tar added a comment to D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox.

It would be nice someone could explain, or point me where to read, why there is no (more) direct use of Sonnet stuff in KTextEditor/Kate.

Thu, Nov 22, 3:19 PM · Frameworks, Kate, KTextEditor
loh.tar requested review of D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox.
Thu, Nov 22, 3:18 PM · Frameworks, Kate, KTextEditor

Tue, Nov 20

loh.tar added inline comments to D17028: Loader: Avoid Q_FOREACH.
Tue, Nov 20, 7:08 PM · Frameworks
loh.tar requested review of D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox.
Tue, Nov 20, 3:59 PM · Frameworks
loh.tar requested review of D17055: Avoid Q_FOREACH.
Tue, Nov 20, 3:54 PM · Frameworks
loh.tar added inline comments to D17028: Loader: Avoid Q_FOREACH.
Tue, Nov 20, 3:49 PM · Frameworks
loh.tar added a comment to D17028: Loader: Avoid Q_FOREACH.

@davidedmundson Wow, that was fast :-)

Tue, Nov 20, 6:01 AM · Frameworks

Mon, Nov 19

loh.tar added a comment to D16926: Review user interaction in session management.

Um, really 9999? I have used now 9

It just use big enough number to not have "Context not available."

Mon, Nov 19, 10:07 PM · Kate
loh.tar added a comment to D17030: DictionaryComboBox: Keep user preferred dictionaries on top.

The added stuff at the ConfigWidget looks to me not perfect but OK. Suggestions are welcome. Some thoughts/questions

Mon, Nov 19, 9:50 PM · Frameworks
loh.tar requested review of D17030: DictionaryComboBox: Keep user preferred dictionaries on top.
Mon, Nov 19, 9:44 PM · Frameworks
loh.tar requested review of D17028: Loader: Avoid Q_FOREACH.
Mon, Nov 19, 9:34 PM · Frameworks
loh.tar requested review of D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button .
Mon, Nov 19, 9:26 PM · Frameworks

Sun, Nov 18

loh.tar added a comment to D16926: Review user interaction in session management.
Sun, Nov 18, 8:58 AM · Kate
loh.tar updated the diff for D16926: Review user interaction in session management.
  • Remove preprocessor protection of QDBus availability
  • Increase kpartgui version to 84
Sun, Nov 18, 8:54 AM · Kate
loh.tar updated the diff for D16926: Review user interaction in session management.

Oops! - Fix to give anonymous session a name

  • Avoid own entry in window/task-manager
Sun, Nov 18, 5:54 AM · Kate

Fri, Nov 16

loh.tar added a comment to D16926: Review user interaction in session management.

Because this a little extensive patch, I guess you will need (and should take) some time for a review.

Fri, Nov 16, 4:22 PM · Kate
loh.tar requested review of D16926: Review user interaction in session management.
Fri, Nov 16, 4:20 PM · Kate

Nov 5 2018

loh.tar requested review of D16688: SessionManager: Close all split views before session restore.
Nov 5 2018, 4:43 PM · Kate
loh.tar requested review of D16687: SessionManager: Avoid to accumulate outdated entries in the session file.
Nov 5 2018, 4:14 PM · Kate

Nov 3 2018

loh.tar requested review of D16646: KateSessionManager: Sort the jump list actions alphabetical .
Nov 3 2018, 5:58 PM · Kate
loh.tar requested review of D16645: KateSessionManager: Sort the jump list actions by time not alphabetical .
Nov 3 2018, 5:51 PM · Kate
loh.tar requested review of D16644: KateSessionManager: Limit the number of referenced jump list actions .
Nov 3 2018, 5:47 PM · Kate

Oct 22 2018

loh.tar requested review of D16378: QuickOpen: Toggle back to view manager when when quick open is already shown.
Oct 22 2018, 8:59 PM · Kate

Oct 20 2018

loh.tar requested review of D16336: BuildView: Avoid to show ToolView when build is invoked.
Oct 20 2018, 4:28 PM · Kate

Aug 13 2018

loh.tar added a comment to D14659: SymbolView: Save view settings individual for each parser.

I would still would want to integrate get your Normal parser as a Markdown parser if you are OK with that.

Aug 13 2018, 3:35 PM · Kate