- User Since
- Jul 23 2018, 3:22 PM (29 w, 4 d)
- Add autotest
- Don't wrap twice when static wrap is set to avoid bad result
Wed, Feb 13
Have other still issues with this patch?
Sun, Feb 10
Contrary to my announcement to use an enum as key I chosed the string for maximum simplicity.
Yes, this way you notice a typo only at runtime, but in any case you have to know how some stuff has to be written. An enum key offer not only complile time checks but also to use QVector instead of QHash which may be more perfomand but need some more effort when add new stuff and probably longer longer keys, prefixed by namespace.
Wed, Feb 6
Here a link how it is done in Kate/KTextEditor
Tue, Feb 5
- rebase on master
Mon, Feb 4
- Move to correct function
Sun, Feb 3
- Apply nullptr check
- Add non preferred dict to menu chose by user
- Reorder actions
- Remove gone "Spellcheck Selection" action
- Revert all
- Add TODO KF6 note to header
- Update Summary
Sat, Feb 2
For my taste could be "Spelling (from cursor)" the only offered action (logic). Always to check from the start is rarely useful, but I guess no one like that idea.
Fri, Feb 1
- Move logic into document
- Tiny docu fix + cosmettic
Wed, Jan 30
I often struggle with QtCreator but I can't remember what happens there, sorry.
Fri, Jan 25
also don't change the behavior of wordwrapping that is used by the view compared to what we would get by calling wordwrap on the document directly
Thu, Jan 24
If you want to get this behavior for Markdown
There is an enum KSyntaxHighlighting::Theme::TextStyle::Operator but I can't find a function to test for that.
Beside that I guess it would not work anyway. If it's an operator or not need a call to some "update highlight" to investigate the context.
the selection becomes wrapped in two ? - is that right?
Wed, Jan 23
- Update 'What's This' hint to reflect new behaviour and to be more precise
- Update 'What's This' hint of dyn wrap too to be more precise
- Update/clear Summary
Tue, Jan 22
- Use std::unique_ptr for the cursor
- Oops!? Use 'if' instead of unneeded 'while' loop which also avoid 'goto'
- const QChar as value, not reference
- Add , ; - + ^ ° § & just for completeness
Mon, Jan 21
- Don't set m_openingErrorMessage in KateBuffer::openFile
- m_openingErrorMessage is now nowhere set
- Only set "no success" when doc is empty
- Remove unneded stuff
> A really new file would be closed too.
So, well, yes, without to change the logic in D18116 (but still apply that to remove unneded text) it work as needed.
- if we just keep the code in ktexteditor as is
- we should just set openSuccess to false if we have an doc->openingError() and the document is empty
m_dictionaryGroup->checkedAction() might be null.
are you interested in that challenge, too?
But on the other side: how does one reproduce this?
Sat, Jan 19
Well, I'm not a Sonnet Guru, more a normal user. Sorry if it sounds so. I can't give a detailed point how to solve some particular issue.
Fri, Jan 18
Just my thoughts:
Thu, Jan 17
- Fix to pass autotest
Jan 16 2019
- Remove m_gotoRange->setFocus
- Morph updateData() into a slot
- connect to Document::textChanged signal
I think this is not sufficient. These "openingError()" is somewhere used to change the document icon. So I believe there is a need to change this to an (u)int value, 0=good, 1=someTrouble, 3=seriousProblem=orphaned
- Fix typo of member vars
- Add missing setView(m_view)
- Remove FIXME hint about timer, however would a comment for me nice
- Use QString()
Interesting. Didn't know that such function exist. Well, it may help to read the handbook...
Is there no GUI way to access such stuff? "Read the handbook" lala...
Jan 15 2019
I have the feeling it adds more clutter than it helps by default:
Display other variables found in CMakeCache
can you please rephrase the title of this review to make it understandable?
please add proper tests for this functionality
No idea how
The search plugin is already cluttered with a lot of buttons...
Jan 14 2019
- Add chars ´ ` _ . : | # @ ~ * ! ? $ % / \ = to special handling
- Avoid chars
I discussed this name ("Outline View") with someone else and it should be fine. See for example...
Jan 13 2019
Your perception is clear, we have always some result to navigate in, make sense.
The shots are looking to me great! :-)
As said, that should be available at KDE scope, not only this plugin!
What do you think of the described idea to have a universal "next match" feature and shortcut?
Hm, my workflow is somehow special too. So I guess the Gurus around here may chuckle. First, look at my plugin entries. So I think you have there something wrong.
To compile I hit my short-cut which will always run the market command. To start the new stuff I switch to a normal terminal where ONCE was "sourced" these script. That's all.
Um, can't find here a hint that this is try to follow some "defined standard", like CUA. https://en.wikipedia.org/wiki/IBM_Common_User_Access
I like the new status bar.
Sadly is the benefit, to reduce the menu entries, not "optimal". In the pics you have now 3 sub-entries for one "Variant" entry, effectively only 2 less per topic.
Jan 12 2019
I didn't know this menu existed!
Jan 11 2019
Can you make the RegExp tool-tip available only when we are in RegExp mode?
- Use 120 as wheel-delta threshold
- Use member instead of static local
I was about to move StatusBarButton into kateviewhelpers, so that this button can used elsewhere too, like here. But got stuck. However, I think such button would be handy. Perhaps also a KateViewBarLayout.
Here shot regarding 'Change label text to be less redundant in conjunction with the "goto-button"' At least in German is that old text terrible.
Jan 10 2019
I'm very much against such a label, and against the full name.
"UTF-8" has also no label and that's good. The only stuff where a description label is needed are these line/column/word hints. Without a label are you almost lost to know which is what.
Jan 9 2019
- Add missing signals to watch dict changes
- Ensure button is set on first show
Isn't en_US too cryptic?
The shown dictionary is sometimes "wrong"
we can just skip the messaging always, we have always inline messages, I think that would be ok
Jan 8 2019
Nice trick ;-) Can't promise to do it, will see
It was stated that it broke tests, should this be addressed now?
I have it only poor tested with our big S&R file, so no test was made with other trouble causing stuff.
This need a patch in Kate, will try to link that
Back to "Paste by mouse at cursor position"
Sure, can do it. Which one have it to be ?
- Paste clipboard contents at cursor location
- Paste clipboard contents at cursor position
- Paste by mouse at cursor position (This one was liked by Dominik, IIRC)
To avoid further comments I like to add that I don't like to do the requested change. Please improve it later, if needed.
Try to be smart
Jan 7 2019
I agree, it's on the first sight pretty clear. But then can you force this "style" for every bool option. In the above linked pic is this obviously only used for Normal vs Vi-Mode 
Yes, my English is bad. But "Outline View" sound to me less fitting than my "Index View". But when I look at your notes below CMake you seems to have in mind to traverse the directory and search some stuff. Obviously similar to the CTag plugin, which I have never tested. (Ha, only noted recently what it is due to its odd description in the Kate config page). So then may your name indeed fit better.
Jan 6 2019
Yes looks nice.
Would be good as icon for the Kile Handbook, for the application I would omit/avoid the "Notebook" look.
- Remove not supported Rich Text from [BLOCK] hint
- Add word count info to line label
I didn't test it even more but think on it from time to time. If my slightly negative comment was OK or too fast judged. And yes it may.
Will wait for further advice
Still waiting if I have to undo these reference stuff. (Yes your are busy. Just only wanted it to emphasize)
Besides, I like to add some more chars to this special handling:
_ : # @ ~ * ! $ % / \
Some of these may handy when write Markdown, some perhaps elsewhere
Allow StatusBarButton to shrink
Change checkbox text as suggested
Jan 5 2019
Please provide also a tooltip/whats-this text, if useful. My QtDesigner did not show the needed widget stuff, so the text is not set.
A look at that bug report may give more hints/ideas
I find it annoying that the status bar imposes a limit on the minimum width of the window
Make actions checkable. I think you also prefer this to an "extra star solution".
May I ask a stupid question? Is the entire function needed? That's looks to me somehow like image/picture stuff but I don't find picture stuff in the Tool->Emmet menu.
That can I not really imagine :-/ Wouldn't that not somehow to be notice in normal use?
Let's try this. Shot without bar, Now choose "Show bar", The window didn't change. (Sorry, no tool at hand to paste pics together)
The bar can shrink almost endless.
This patch is somehow a leftover from early days.
Should you think to remove the current active session is a bad idea, let us them at least disable.
Jan 4 2019
Well, if it is fixed I can't say. At least the error is gone and "Increment/Decrement" works.
May some guru investigate if its fixed. Obviously is there a problem with these string constants.