loh.tar (loh tar)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 23 2018, 3:22 PM (46 w, 5 d)
Availability
Available

Recent Activity

Tue, May 28

loh.tar committed R39:7e739920fd23: Don't delete entire previous line by backspace in pos 0 (authored by loh.tar).
Don't delete entire previous line by backspace in pos 0
Tue, May 28, 3:56 PM
loh.tar closed D19785: DocumentPrivate: Review del/backspace.
Tue, May 28, 3:56 PM · Frameworks, Kate
loh.tar added a comment to D19785: DocumentPrivate: Review del/backspace.

That may fix it.

diff --git a/src/document/katedocument.cpp b/src/document/katedocument.cpp
index e365c380..7c24f67f 100644
--- a/src/document/katedocument.cpp
+++ b/src/document/katedocument.cpp
@@ -3350,7 +3350,9 @@ void KTextEditor::DocumentPrivate::backspace(KTextEditor::ViewPrivate *view, con
Tue, May 28, 1:44 PM · Frameworks, Kate

Sun, May 26

loh.tar added a comment to D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.

What would be the concrete content of the combobox then?

What? Which box? These box can became these 4th "Smart" option but the code should then only work on spaces....to be "correct/right".

Sun, May 26, 1:42 PM · Frameworks, Kate
loh.tar added a comment to D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.

Given we already have now some enum for the show spaces stuff (None/Trailing/All) I would just vote to have some "Smart" 4th variant inside

Sun, May 26, 1:27 PM · Frameworks, Kate
loh.tar committed R39:bcba89914136: Review del/backspace (authored by loh.tar).
Review del/backspace
Sun, May 26, 12:52 PM
loh.tar closed D19785: DocumentPrivate: Review del/backspace.
Sun, May 26, 12:52 PM · Frameworks, Kate
loh.tar added a comment to D21409: KWrite: Implement skeleton KTextEditor::Application.

I thought it should try to quit the app not only close one window.

Sun, May 26, 5:23 AM · Kate

Thu, May 23

loh.tar closed D20815: Ensure highlighted folding marker after unfold.
Thu, May 23, 6:35 PM · Frameworks, Kate
loh.tar committed R39:e539697f5cbd: Ensure highlighted range begin/end marker after unfold (authored by loh.tar).
Ensure highlighted range begin/end marker after unfold
Thu, May 23, 6:35 PM
loh.tar added a comment to D20815: Ensure highlighted folding marker after unfold.

And why is the delete not useful?

Thu, May 23, 12:30 PM · Frameworks, Kate
loh.tar added a comment to D19771: Use placeholder instead of label.

Hi, any more feedback on this?

Thu, May 23, 5:23 AM · Frameworks, Kate
loh.tar added a comment to D21287: Try to find always an unique visible document name without a number suffix.

the path is appended behind the document name. What about this solution?

Thu, May 23, 5:15 AM · Frameworks, Kate

Sun, May 19

loh.tar updated the test plan for D21287: Try to find always an unique visible document name without a number suffix.
Sun, May 19, 3:45 PM · Frameworks, Kate
loh.tar added a comment to D21287: Try to find always an unique visible document name without a number suffix.

PS: The tab switcher also has something similar to make a distiction between files with the same name D16054

Sun, May 19, 3:43 PM · Frameworks, Kate
loh.tar requested review of D21287: Try to find always an unique visible document name without a number suffix.
Sun, May 19, 11:16 AM · Frameworks, Kate

May 8 2019

loh.tar added a comment to D17693: Add option to treat some chars also as "auto bracket" only when we have a selection.

Well, I'm also not full convinced about the current way, but how else?

May 8 2019, 6:17 PM · Frameworks, Kate
loh.tar committed R39:783647154a0e: Avoid infinite loop in "Toggle Contained Nodes" action (authored by loh.tar).
Avoid infinite loop in "Toggle Contained Nodes" action
May 8 2019, 6:07 PM
loh.tar closed D21078: Avoid infinite loop in "Toggle Contained Nodes" action.
May 8 2019, 6:07 PM · Frameworks, Kate
loh.tar added a comment to D20958: New menu of syntax highlighting in the status bar.

I could add a "Recent" section to the beginning of the menu, it would be useful.

Nice! Just to be clear. That should to be work over session borders, not only the current one.

May 8 2019, 12:42 PM · Frameworks, Kate
loh.tar requested review of D21078: Avoid infinite loop in "Toggle Contained Nodes" action.
May 8 2019, 4:51 AM · Frameworks, Kate

May 7 2019

loh.tar updated the diff for D17693: Add option to treat some chars also as "auto bracket" only when we have a selection.
  • Make feature configurable
May 7 2019, 7:09 PM · Frameworks, Kate
loh.tar committed R40:f42f5b1137aa: Clear konsole command-line before send cd command (authored by loh.tar).
Clear konsole command-line before send cd command
May 7 2019, 2:13 PM
loh.tar closed D20974: Clear konsole command-line before send cd command.
May 7 2019, 2:13 PM · Kate

May 6 2019

loh.tar updated the diff for D20974: Clear konsole command-line before send cd command.
  • Move code to cd function
  • Add Ctrl-E as suggested
May 6 2019, 1:29 PM · Kate

May 5 2019

loh.tar updated the diff for D16336: BuildView: Add config page with some options.
  • Add config page with some options, more may follow
  • "Autohide" works now slightly smart
  • Chose new icon which for my taste more fit
  • Add an ascii progess bar to the info message to solve size issues...and to be a little fancy :-)
May 5 2019, 8:36 AM · Kate

May 4 2019

loh.tar committed R39:2af8bdae9ae2: Review kate config pages to improve maintenance friendliness (authored by loh.tar).
Review kate config pages to improve maintenance friendliness
May 4 2019, 6:58 AM
loh.tar closed D21007: Review kate config pages to improve maintenance friendliness.
May 4 2019, 6:58 AM · Frameworks, Kate
loh.tar requested review of D21007: Review kate config pages to improve maintenance friendliness.
May 4 2019, 5:53 AM · Frameworks, Kate

May 3 2019

loh.tar added a comment to D20958: New menu of syntax highlighting in the status bar.

I could add a "Recent" section to the beginning of the menu, it would be useful.

May 3 2019, 2:04 PM · Frameworks, Kate
loh.tar added a comment to D20974: Clear konsole command-line before send cd command.

Does that obsolete the other patch

May 3 2019, 1:57 AM · Kate
loh.tar committed R39:d572d3276358: Code cosmetic (authored by loh.tar).
Code cosmetic
May 3 2019, 1:23 AM
loh.tar closed D20963: Code cosmetic.
May 3 2019, 1:23 AM · Frameworks, Kate

May 2 2019

loh.tar requested review of D20974: Clear konsole command-line before send cd command.
May 2 2019, 9:06 PM · Kate
loh.tar added a comment to D20958: New menu of syntax highlighting in the status bar.

When the menu is opened, clear any text in the search field left over from a prior search

May 2 2019, 7:15 PM · Frameworks, Kate
loh.tar added a comment to D20958: New menu of syntax highlighting in the status bar.

Wow, look very nice :-)
The only thing I would like to have is an auto generated "most often used" list. That was also suggested somewhere. This way you could quickly change between preferred styles instead to search for them.

May 2 2019, 3:55 PM · Frameworks, Kate
loh.tar requested review of D20963: Code cosmetic.
May 2 2019, 2:19 PM · Frameworks, Kate
loh.tar committed R39:743cbe13fda0: ViewConfig: Use new generic config interface (authored by loh.tar).
ViewConfig: Use new generic config interface
May 2 2019, 1:16 PM
loh.tar closed D20924: ViewConfig: Use new generic config interface .
May 2 2019, 1:16 PM · Frameworks, Kate
loh.tar updated the diff for D20924: ViewConfig: Use new generic config interface .
  • Last missed settings
  • Some cleanup
May 2 2019, 4:31 AM · Frameworks, Kate

May 1 2019

loh.tar updated the diff for D20924: ViewConfig: Use new generic config interface .

7 more and we are done :-/

May 1 2019, 9:18 PM · Frameworks, Kate
loh.tar updated the diff for D20924: ViewConfig: Use new generic config interface .
  • Use the power of new the interface in DocumentPrivate::setViewVariable
  • ShowFoldingPreview
  • ShowLineModification
  • ShowFoldingBar
May 1 2019, 3:55 PM · Frameworks, Kate
loh.tar updated the diff for D20924: ViewConfig: Use new generic config interface .
  • Use the power of new the interface in ViewPrivate::setConfigValue
  • Add missed finalizeConfigEntries() call
  • Add check to finalizeConfigEntries() for key to be unique
  • ShowIconBar
  • ShowScrollbars
May 1 2019, 12:18 PM · Frameworks, Kate
loh.tar updated the diff for D20924: ViewConfig: Use new generic config interface .
  • Rebase on master
May 1 2019, 7:27 AM · Frameworks, Kate
loh.tar added inline comments to D20924: ViewConfig: Use new generic config interface .
May 1 2019, 7:22 AM · Frameworks, Kate

Apr 30 2019

loh.tar updated the diff for D20924: ViewConfig: Use new generic config interface .
  • ShowScrollBarPreview
  • ShowScrollBarMarks
  • ShowLineNumbers
  • Add some validator functions, please look at them
Apr 30 2019, 8:58 PM · Frameworks, Kate
loh.tar added a comment to D20924: ViewConfig: Use new generic config interface .

Ah, last hint: The diff is not against master. Should you really like to try it, I can fix that earlier, otherwise will do it when I'm done

Apr 30 2019, 6:46 PM · Frameworks, Kate
loh.tar requested review of D20924: ViewConfig: Use new generic config interface .
Apr 30 2019, 6:42 PM · Frameworks, Kate
loh.tar committed R39:08d1537b7565: Fix bookmark pixmap painting on icon bar (authored by loh.tar).
Fix bookmark pixmap painting on icon bar
Apr 30 2019, 1:30 PM
loh.tar closed D20903: Fix bookmark pixmap painting on icon bar.
Apr 30 2019, 1:30 PM · Frameworks, Kate
loh.tar committed R39:34fec148d283: Ensure the left border miss no change of the count of line number digits (authored by loh.tar).
Ensure the left border miss no change of the count of line number digits
Apr 30 2019, 1:27 PM
loh.tar closed D20897: Ensure the left border miss no change of the count of line number digits.
Apr 30 2019, 1:27 PM · Frameworks, Kate

Apr 29 2019

loh.tar updated the test plan for D20903: Fix bookmark pixmap painting on icon bar.
Apr 29 2019, 6:57 PM · Frameworks, Kate
loh.tar requested review of D20903: Fix bookmark pixmap painting on icon bar.
Apr 29 2019, 4:17 PM · Frameworks, Kate
loh.tar updated the diff for D17693: Add option to treat some chars also as "auto bracket" only when we have a selection.
  • Remove special angle bracket check, will be back in a smarter may later (hopefully)
  • Move getter config functions into header
Apr 29 2019, 3:03 PM · Frameworks, Kate
loh.tar requested review of D20897: Ensure the left border miss no change of the count of line number digits.
Apr 29 2019, 1:43 PM · Frameworks, Kate

Apr 28 2019

loh.tar updated the diff for D17693: Add option to treat some chars also as "auto bracket" only when we have a selection.
  • Make feature optional by new config interface
  • Make feature independent from auto bracket option
  • Remove redundant const QChar typedChar
  • Use dummy config value from dialog
Apr 28 2019, 11:14 AM · Frameworks, Kate

Apr 27 2019

loh.tar committed R39:710a951d3053: Fix vimode_keys AltGr test (authored by loh.tar).
Fix vimode_keys AltGr test
Apr 27 2019, 4:48 PM
loh.tar closed D20870: Fix vimode_keys AltGr test.
Apr 27 2019, 4:48 PM · Frameworks, Kate
loh.tar updated the test plan for D20870: Fix vimode_keys AltGr test.
Apr 27 2019, 3:21 PM · Frameworks, Kate
loh.tar requested review of D20870: Fix vimode_keys AltGr test.
Apr 27 2019, 3:11 PM · Frameworks, Kate
loh.tar committed R39:ece2425de0ce: Fix kateview_test testDragAndDrop (authored by loh.tar).
Fix kateview_test testDragAndDrop
Apr 27 2019, 2:09 PM
loh.tar committed R39:2c2e345d4fbf: Fix to show folding preview when move the mouse from bottom to top (authored by loh.tar).
Fix to show folding preview when move the mouse from bottom to top
Apr 27 2019, 2:09 PM
loh.tar closed D20852: Fix to show folding preview when move the mouse from bottom to top.
Apr 27 2019, 2:09 PM · Frameworks, Kate
loh.tar added a comment to D20852: Fix to show folding preview when move the mouse from bottom to top.

> Have the feeling kateview_test testDragAndDrop fails more and more often. Have already spend a lot of time in look at that but without success

Apr 27 2019, 9:57 AM · Frameworks, Kate
loh.tar updated the diff for D20852: Fix to show folding preview when move the mouse from bottom to top.
  • Fix missing cleanup in case of unvalid mouse position
  • Give members more fitting names
  • Remove unneeded m_nextHighlightBlock
  • Remove repaint()
  • Remove commented event filter hint
Apr 27 2019, 5:57 AM · Frameworks, Kate

Apr 26 2019

loh.tar requested review of D20852: Fix to show folding preview when move the mouse from bottom to top.
Apr 26 2019, 6:57 PM · Frameworks, Kate
loh.tar updated the diff for D20815: Ensure highlighted folding marker after unfold.
  • Fix jump of big unfold II :-/
Apr 26 2019, 5:15 AM · Frameworks, Kate

Apr 25 2019

loh.tar updated the diff for D20815: Ensure highlighted folding marker after unfold.
  • Ensure cursor don't move when isssue toggleFoldingsInRange
Apr 25 2019, 3:10 PM · Frameworks, Kate
loh.tar added a comment to D20815: Ensure highlighted folding marker after unfold.

I think about a patch to issue the foldingPreview in case of unfold when done by click on the icon bar. Unfortunately would that need some bigger changes at the toggleFolding functions to return what was done.

Apr 25 2019, 2:34 PM · Frameworks, Kate
loh.tar requested review of D20815: Ensure highlighted folding marker after unfold.
Apr 25 2019, 2:22 PM · Frameworks, Kate

Apr 24 2019

loh.tar committed R39:0d70744ed67b: Fix broken InlineNoteTest (authored by loh.tar).
Fix broken InlineNoteTest
Apr 24 2019, 1:42 PM
loh.tar closed D20697: Review IconBorder.
Apr 24 2019, 1:42 PM · Frameworks, Kate

Apr 23 2019

loh.tar added a comment to D20606: Add action to toggle folding of child ranges.

I would prefer a context menu that has this as action. This is much better discoverable and also extensible with more folding actions.

I agree. Right-click should show a context menu. Middle-click could toggle, if you need it.

Apr 23 2019, 8:33 PM · Frameworks, Kate
loh.tar committed R39:57781f34d234: Review IconBorder (authored by loh.tar).
Review IconBorder
Apr 23 2019, 7:48 PM
loh.tar closed D20697: Review IconBorder.
Apr 23 2019, 7:48 PM · Frameworks, Kate
loh.tar updated the diff for D20697: Review IconBorder.

try to fix annotation issue

Apr 23 2019, 7:20 PM · Frameworks, Kate

Apr 22 2019

loh.tar added a comment to D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.

I'm sorry, I couldn't reproduce the crash to verify your patch. But at least cause it on the first sight no new crash here :-)

Apr 22 2019, 8:35 PM · Kate
loh.tar committed R39:d9171c391267: Paint the folding marker in proper color and make it more visible (authored by loh.tar).
Paint the folding marker in proper color and make it more visible
Apr 22 2019, 8:06 PM
loh.tar closed D20742: Paint the folding marker in propper color and make it more visible .
Apr 22 2019, 8:06 PM · Frameworks, Kate
loh.tar requested review of D20742: Paint the folding marker in propper color and make it more visible .
Apr 22 2019, 5:52 PM · Frameworks, Kate
loh.tar added a comment to D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.

hm, can't say much helpful to your patch. Send you my BT.
But from my point of view is this assert here redundant. When you dislike my check, you can drop the assert anyway.

Apr 22 2019, 4:39 PM · Kate
loh.tar added a comment to D20697: Review IconBorder.

Did you test that the annotation border still works? You can do so in KDevelop by invoking git blame.

Apr 22 2019, 7:40 AM · Frameworks, Kate
loh.tar added a comment to D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.

Out of the blue run I into this issue.
The only slightly unusual before was, that I had a confirmation box regarding an unsaved file while quit the session. Then, when I want to restart the same session, it crached always.
If you like I can submit the BT, but think it's not needed to approve this patch.

Apr 22 2019, 7:39 AM · Kate
loh.tar requested review of D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab.
Apr 22 2019, 7:34 AM · Kate
loh.tar added a comment to D20697: Review IconBorder.

@dhaumann Beside these annotation stuff I think I'm done with this now. Should you, or someone else, not stop me in the next few days I may treat this as OK and push it.
There are still some issues in the mouse move handling but will try to fix that in some other patch

Apr 22 2019, 5:48 AM · Frameworks, Kate
loh.tar updated the test plan for D20697: Review IconBorder.
Apr 22 2019, 5:43 AM · Frameworks, Kate
loh.tar updated the diff for D20697: Review IconBorder.
  • Fix bookmark pixmap painting

Left before, right with fix

Apr 22 2019, 5:40 AM · Frameworks, Kate
loh.tar updated the diff for D20697: Review IconBorder.
  • Add margin to the edit area, but I'm not sure if it should be done here. I guess renderer should do it
  • Simplify "additional folding highlighting", there is now the slightly gradient gone, bad?
  • Rename backGroundColor->iconBarColor to fit orig name, but that name sounds to me as it's only for the icon area of the border

Apr 22 2019, 4:45 AM · Frameworks, Kate

Apr 21 2019

loh.tar added a comment to D20264: Add test for "Auto Reload Document" option.

@dhaumann asked elsewhere

Apr 21 2019, 9:18 AM · Frameworks, Kate
loh.tar updated the diff for D20697: Review IconBorder.
  • Fix missing printed background in proper theme color
  • Fix scroll past end of document
  • Fix less pushy paint unfolded icon in not dark themes and don't try to use currentLineNumberColor, the folded icon gets also not highligted
  • Some more cosmetic

Apr 21 2019, 7:00 AM · Frameworks, Kate

Apr 20 2019

loh.tar updated the test plan for D20697: Review IconBorder.
Apr 20 2019, 12:34 PM · Frameworks, Kate
loh.tar requested review of D20697: Review IconBorder.
Apr 20 2019, 12:29 PM · Frameworks, Kate
loh.tar abandoned D20565: Ensure not to fold the end marker.

Patch is part of D20606

Apr 20 2019, 11:31 AM · Frameworks, Kate
loh.tar closed D20606: Add action to toggle folding of child ranges.
Apr 20 2019, 11:27 AM · Frameworks, Kate
loh.tar committed R39:5c83e29561e3: Add action to toggle folding of child ranges (authored by loh.tar).
Add action to toggle folding of child ranges
Apr 20 2019, 11:27 AM
loh.tar committed R39:f5f715ea1441: Add test for "Auto Reload Document" option (authored by loh.tar).
Add test for "Auto Reload Document" option
Apr 20 2019, 11:27 AM
loh.tar closed D20264: Add test for "Auto Reload Document" option.
Apr 20 2019, 11:27 AM · Frameworks, Kate

Apr 18 2019

loh.tar updated the diff for D20606: Add action to toggle folding of child ranges.
  • Add menu action
  • Replace old two actions "Fold/Unfold Current Node" by "Toggle Current Node"
  • Move logic to ViewPrivate
  • KateBuffer: Add checks where they should be
Apr 18 2019, 1:33 PM · Frameworks, Kate

Apr 17 2019

loh.tar added a comment to D20606: Add action to toggle folding of child ranges.

hm, there is already a folding action in the View menu.
I understood Dominik so, not to add a context menu to the icon border, but to add the action to the context menu of the "edit range".
Whatever, as said I'm not in the mood for that, and it should be done in a 2nd patch, when needed.
But a context menu on the icon border would I very much dislike. Middle click is not so handy and perform atm "paste to begin of line"

Apr 17 2019, 3:50 PM · Frameworks, Kate