Earlier, the tooltip was continuosly shown even though search field had text.
Details
Hover over search field
Diff Detail
- Repository
- R134 Discover Software Store
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
the tooltip should be shown especially when the view is empty.
Also the timeout is set already by the style.
I don't understand what you are trying to fix.
discover/qml/SearchField.qml | ||
---|---|---|
47 | Prefer using length as that avoids copying a string into JS space |
@apol I have noticed that the tooltip is seen even when there is text present, also the duration for which it appears is very long
I messed up with summary.
When user is typing text, the tooltip continuosly shown above distracts and looks ugly
Agreed. There's no need to see the keyboard shortcut to focus the search field after the user has already focused it and is currently using it.
However this is currently very broken: the tooltip always disappears after like a quarter of a second now. That won't fly. Please test for behavior as well as code before publishing a patch. I'm not sure you even need to add the timeout: line at all.
I'm not sure you even need to add the timeout: line at all.
A tooltip with a negative timeout does not hide automatically. The default value is -1.
It compiles but I could not test this. When I run the plasma-discover segmentation fault prevails.
Works for me, no segfault. I don't see any reason why this change could cause that. @shubham, does the segfault stop happening when you build Discover from source without this change?
I should have told that the segafault is unrelated to this change. Even without this change, some kind of segafault appears, because of some dependencies etc maybe.
Yes, let's land it. Please land it on the 5.15 branch and then merge to master. If you don't know how to do that, I can help you.
Here are the instructions: https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22
Let me know if anything is unclear.