BUG: 307224
Details
Diff Detail
- Repository
- R223 Okular
- Branch
- page
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8205 Build 8223: arc lint + arc unit
part.cpp | ||
---|---|---|
2452 | This gives error, any help how could I access rotateAt() function of private API without actually making PagePrivate *d in Page as public (Though it is a wrong way to do so)? |
If your patch doesn't work yet and you need help with it, it's customary to put [RFC] or [WIP] at the beginning of the title.
+1 on the feature though. People ask for this quite a bit.
part.cpp | ||
---|---|---|
2451 | This is valid statement, but why does this produce error? |
Don't use the private class, what made you think you can use the private class? it's *private* so obviously it's non usable (unless you know what you're doing and you have reasons for it).
I already told you on IRC how to fix it a long time ago, if you need the functionality, just make it accessible in Page.
By the way does this mean you haven't tested this code at all to see if it actually does anything at all?
core/page.h | ||
---|---|---|
397 | This change is totally unacceptable. |
Sometimes I think it makes sense to move the context menu to the widget it belongs to. That widget would accept the context menu event, and create a context menu. Basically the same context menu that is currently created by Part.
Because PageView will create the context menu then, it should be possible to access Page correctly.
Just a thought...