Feed Advanced Search

Today

shubham added inline comments to D21340: [RFC]Add unit test for RAID.
Fri, May 24, 2:53 AM · KDE Partition Manager
shubham added a comment to D21340: [RFC]Add unit test for RAID.

@stikonas Does the rest looks sensible?

Fri, May 24, 2:51 AM · KDE Partition Manager

Yesterday

shubham updated the diff for D21340: [RFC]Add unit test for RAID.

Add condition in whihc partition size can not be computed

Thu, May 23, 11:12 AM · KDE Partition Manager
shubham committed R16:41b3b833356b: Cleanup and constantify (authored by shubham).
Cleanup and constantify
Thu, May 23, 11:07 AM

Wed, May 22

shubham updated the diff for D21340: [RFC]Add unit test for RAID.
Wed, May 22, 5:06 PM · KDE Partition Manager
shubham updated the diff for D21340: [RFC]Add unit test for RAID.

Remove extra line

Wed, May 22, 2:17 PM · KDE Partition Manager
shubham added a project to D21340: [RFC]Add unit test for RAID: KDE Partition Manager.
Wed, May 22, 2:16 PM · KDE Partition Manager
shubham updated the diff for D21340: [RFC]Add unit test for RAID.
Wed, May 22, 2:13 PM · KDE Partition Manager
shubham requested review of D21340: [RFC]Add unit test for RAID.
Wed, May 22, 1:56 PM · KDE Partition Manager

Tue, May 21

shubham added inline comments to D21301: Add a TerminalHeader when using splits.
Tue, May 21, 4:07 PM · Konsole

Mon, May 20

shubham updated the diff for D20626: Rely upon QSysInfo to retrieve the system details.
Mon, May 20, 2:56 PM · Frameworks
shubham added a comment to D20626: Rely upon QSysInfo to retrieve the system details.
Mon, May 20, 2:53 PM · Frameworks
shubham updated the diff for D20626: Rely upon QSysInfo to retrieve the system details.

proper rebase

Mon, May 20, 12:41 PM · Frameworks
shubham updated the test plan for D20626: Rely upon QSysInfo to retrieve the system details.
Mon, May 20, 12:38 PM · Frameworks
shubham updated the diff for D20626: Rely upon QSysInfo to retrieve the system details.

Rely upon QSysInfo to retrieve the system details

Mon, May 20, 12:37 PM · Frameworks

Sun, May 19

shubham committed R16:a7532d4041de: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough (authored by shubham).
Scrap Public Key Cryptography code based on QCA as QDbus is secure enough
Sun, May 19, 5:23 PM
shubham closed D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough.
Sun, May 19, 5:23 PM · KDE Partition Manager
shubham updated the test plan for D20626: Rely upon QSysInfo to retrieve the system details.
Sun, May 19, 5:02 PM · Frameworks
shubham updated the diff for D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough.

Do not remove qca-qt5 from CMakeLists.txt

Sun, May 19, 2:38 PM · KDE Partition Manager

Sat, May 18

shubham committed R16:54f0c98dc09b: Comment out (authored by shubham).
Comment out
Sat, May 18, 7:31 PM
shubham committed R16:3675a199bf1c: Comment out (authored by shubham).
Comment out
Sat, May 18, 7:22 PM
shubham added a project to D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough: KDE Partition Manager.
Sat, May 18, 6:53 PM · KDE Partition Manager
shubham requested review of D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough.
Sat, May 18, 6:52 PM · KDE Partition Manager
shubham committed R16:07b2ce305412: Remove superflous variables (authored by shubham).
Remove superflous variables
Sat, May 18, 1:24 PM
shubham closed D21272: Remove superflous variables.
Sat, May 18, 1:24 PM · KDE Partition Manager
shubham added a project to D21272: Remove superflous variables: KDE Partition Manager.
Sat, May 18, 1:16 PM · KDE Partition Manager
shubham requested review of D21272: Remove superflous variables.
Sat, May 18, 1:16 PM · KDE Partition Manager

Fri, May 17

shubham updated the diff for D21261: Prevent resizing read-only mounted file systems.

Shift common code to filesystem class

Fri, May 17, 7:58 PM · KDE Partition Manager
shubham added a project to D21261: Prevent resizing read-only mounted file systems: KDE Partition Manager.
Fri, May 17, 7:31 PM · KDE Partition Manager
shubham requested review of D21261: Prevent resizing read-only mounted file systems.
Fri, May 17, 7:30 PM · KDE Partition Manager
shubham abandoned D21244: Make it a pointer since memory is allocated on heap.

I assume it is not required anymore.

Fri, May 17, 5:55 PM · KDE Partition Manager
shubham added a comment to D21244: Make it a pointer since memory is allocated on heap.

@stikonas any comments?

Fri, May 17, 5:42 PM · KDE Partition Manager
shubham committed R16:73a21e673957: Simplify test conditions (authored by shubham).
Simplify test conditions
Fri, May 17, 5:33 PM
shubham closed D21241: Simplify test conditions.
Fri, May 17, 5:33 PM · KDE Partition Manager
shubham committed R16:997f425030b4: Remove redundant include (authored by shubham).
Remove redundant include
Fri, May 17, 5:31 PM
shubham closed D21251: Remove redundant include.
Fri, May 17, 5:31 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

Yesterday I tried for putting theses revisions over gitLab. but could not succeed. I tried doing git push origin master and it said access denied. So what should I do now to push it remote and the merge? Thanks

Fri, May 17, 5:11 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

I have commit access, but It says access denied. Remember you had said it is hosted on remote server.

Fri, May 17, 5:07 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

Oh, I do by running kdesrc-build script, which takes care of removing old build directory.

Fri, May 17, 5:05 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

please test that it builds in a clean build dir.

I do not know what do you mean? tests?

Fri, May 17, 5:02 PM · KDE Partition Manager
shubham updated the diff for D21251: Remove redundant include.

Do not remove <memory>

Fri, May 17, 5:01 PM · KDE Partition Manager
shubham abandoned D21258: Move slot under Q_SLOTS.
Fri, May 17, 4:57 PM · KDE Partition Manager
shubham added a project to D21258: Move slot under Q_SLOTS: KDE Partition Manager.
Fri, May 17, 4:52 PM · KDE Partition Manager
shubham requested review of D21258: Move slot under Q_SLOTS.
Fri, May 17, 4:52 PM · KDE Partition Manager
shubham updated the diff for D21251: Remove redundant include.

More redundant include

Fri, May 17, 3:57 PM · KDE Partition Manager
shubham added a project to D21251: Remove redundant include: KDE Partition Manager.
Fri, May 17, 3:33 PM · KDE Partition Manager
shubham requested review of D21251: Remove redundant include.
Fri, May 17, 3:32 PM · KDE Partition Manager
shubham added inline comments to D21244: Make it a pointer since memory is allocated on heap.
Fri, May 17, 5:18 AM · KDE Partition Manager

Thu, May 16

shubham added a project to D21244: Make it a pointer since memory is allocated on heap: KDE Partition Manager.
Thu, May 16, 7:57 PM · KDE Partition Manager
shubham requested review of D21244: Make it a pointer since memory is allocated on heap.
Thu, May 16, 7:56 PM · KDE Partition Manager
shubham updated the diff for D21241: Simplify test conditions.

Take few more instances into account

Thu, May 16, 7:36 PM · KDE Partition Manager
shubham added inline comments to D21241: Simplify test conditions.
Thu, May 16, 7:17 PM · KDE Partition Manager
shubham added a project to D21241: Simplify test conditions: KDE Partition Manager.
Thu, May 16, 7:17 PM · KDE Partition Manager
shubham requested review of D21241: Simplify test conditions.
Thu, May 16, 7:15 PM · KDE Partition Manager

Tue, May 14

shubham added a comment to R32:bbd5d4812d87: Merge remote-tracking branch 'origin/5.3'.

@kfunk This have probably caused a failure in CI.
https://invent.kde.org/kde/kdevelop/-/jobs/6878

Tue, May 14, 6:30 PM

Sun, May 5

shubham added inline comments to D20985: Set compression to 50 is the format is png.
Sun, May 5, 3:30 AM · Spectacle

Thu, May 2

shubham updated the diff for D20735: [KPropertiesDialog] Add octal permissions.

constantanize permissions

Thu, May 2, 5:59 AM · Frameworks
shubham updated the diff for D20735: [KPropertiesDialog] Add octal permissions.

No type casting

Thu, May 2, 5:55 AM · Frameworks

Wed, May 1

shubham added a comment to D20735: [KPropertiesDialog] Add octal permissions.

Ping?

Wed, May 1, 1:57 PM · Frameworks

Thu, Apr 25

shubham added inline comments to D20670: automatically hide undo notification 3 seconds after it has been shown.
Thu, Apr 25, 3:22 PM
shubham updated the test plan for D20735: [KPropertiesDialog] Add octal permissions.
Thu, Apr 25, 3:19 PM · Frameworks
shubham updated the diff for D20735: [KPropertiesDialog] Add octal permissions.
  1. Use mode_t to get the permissions
  2. Position the octal permissions inside "Advanced Permissions" tab
Thu, Apr 25, 3:18 PM · Frameworks
shubham added inline comments to D20670: automatically hide undo notification 3 seconds after it has been shown.
Thu, Apr 25, 2:21 PM
shubham added inline comments to D20804: RFC: Try getting the X keyboard grab multiple times.
Thu, Apr 25, 11:18 AM · Plasma

Apr 24 2019

shubham added a comment to D20626: Rely upon QSysInfo to retrieve the system details.

@dfaure Ping?

Apr 24 2019, 3:50 PM · Frameworks
shubham updated the summary of D20626: Rely upon QSysInfo to retrieve the system details.
Apr 24 2019, 3:50 PM · Frameworks

Apr 22 2019

shubham added a reviewer for D20745: Open new terminal in the same directory: hein.
Apr 22 2019, 6:45 PM
shubham added a comment to D20735: [KPropertiesDialog] Add octal permissions.
In D20735#454263, @pino wrote:

Tried to print it as octal-based value?

No, now I get that those permissions were base 10.
How to print it as octal?

Apr 22 2019, 4:21 PM · Frameworks
shubham added a comment to D20735: [KPropertiesDialog] Add octal permissions.

I had used permission() to get the mode_t variable, which I later type casted to qint64, still the permissions resulted were completed wrong. Any suggestions, how this may be done better in efficient manner?

Apr 22 2019, 3:58 PM · Frameworks
shubham updated the summary of D20735: [KPropertiesDialog] Add octal permissions.
Apr 22 2019, 2:16 PM · Frameworks
shubham updated the test plan for D20735: [KPropertiesDialog] Add octal permissions.
Apr 22 2019, 12:03 PM · Frameworks
shubham requested review of D20735: [KPropertiesDialog] Add octal permissions.
Apr 22 2019, 12:02 PM · Frameworks

Apr 20 2019

shubham closed D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.
Apr 20 2019, 2:22 PM · Frameworks
shubham committed R245:b63c2a236faf: Fix no member named 'setTime_t' in 'QDateTime' error while building (authored by shubham).
Fix no member named 'setTime_t' in 'QDateTime' error while building
Apr 20 2019, 2:22 PM
shubham updated the diff for D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.

Fix unintentional mode change

Apr 20 2019, 1:49 PM · Frameworks
shubham updated the summary of D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.
Apr 20 2019, 6:40 AM · Frameworks
shubham requested review of D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.
Apr 20 2019, 6:38 AM · Frameworks

Apr 19 2019

shubham updated the test plan for D20626: Rely upon QSysInfo to retrieve the system details.
Apr 19 2019, 8:25 AM · Frameworks
shubham updated the test plan for D20626: Rely upon QSysInfo to retrieve the system details.
Apr 19 2019, 8:16 AM · Frameworks

Apr 18 2019

shubham committed R241:8eddb63b0460: Merge branch 'master' of https://anongit.kde.org/kio (authored by shubham).
Merge branch 'master' of https://anongit.kde.org/kio
Apr 18 2019, 8:09 AM
shubham committed R241:eb99a363724f: Remove TODO (authored by shubham).
Remove TODO
Apr 18 2019, 8:09 AM
shubham abandoned D20639: Remove TODO.
Apr 18 2019, 3:17 AM · Frameworks

Apr 17 2019

shubham requested review of D20639: Remove TODO.
Apr 17 2019, 5:27 PM · Frameworks
shubham added a comment to D20625: Truncate trailing forward slashes(/).

@dfaure Intention was just to fix the TODO

Apr 17 2019, 4:35 PM · Frameworks
shubham committed R241:acc6b9b71b51: Truncate trailing forward slashes(/) (authored by shubham).
Truncate trailing forward slashes(/)
Apr 17 2019, 4:34 PM
shubham closed D20625: Truncate trailing forward slashes(/).
Apr 17 2019, 4:34 PM · Frameworks
shubham updated the test plan for D20625: Truncate trailing forward slashes(/).
Apr 17 2019, 2:02 PM · Frameworks
shubham updated the diff for D20625: Truncate trailing forward slashes(/).

Correcty chop trailing slash

Apr 17 2019, 2:01 PM · Frameworks
shubham requested review of D20626: Rely upon QSysInfo to retrieve the system details.
Apr 17 2019, 8:20 AM · Frameworks
shubham added a reviewer for D20625: Truncate trailing forward slashes(/): dfaure.
Apr 17 2019, 7:58 AM · Frameworks
shubham requested review of D20625: Truncate trailing forward slashes(/).
Apr 17 2019, 7:56 AM · Frameworks

Apr 16 2019

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

@ngraham @aacid Ping?

Apr 16 2019, 6:39 AM · Documentation, Okular

Apr 12 2019

shubham added a comment to D18384: Allow creating directory named '~' and throw a warning before creating it..

@ngraham Are you still working on this?

Apr 12 2019, 6:12 AM · Frameworks
shubham added a comment to D18563: Don't create directory tree when a new folder has a '/' in the name.

@ngraham Are you working on it?

Apr 12 2019, 6:11 AM · Frameworks

Apr 8 2019

shubham updated the test plan for D18744: Add action in Edit menu to select the text on current page.
Apr 8 2019, 4:10 PM · Documentation, Okular
shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Do not copy to clipboard

Apr 8 2019, 4:09 PM · Documentation, Okular
shubham updated the test plan for D18744: Add action in Edit menu to select the text on current page.
Apr 8 2019, 4:06 PM · Documentation, Okular

Apr 6 2019

shubham added a comment to D20269: Fix typo and constantify arguments.

Looks alright, although I wouldn't call that thing a typo. Variable names in C++ doesn't have to match in function header and implementation, although, it's probably less confusing if they match. But sometimes one can simply omit names in header and just have types.

Apr 6 2019, 4:20 AM · KDE Partition Manager

Apr 5 2019

shubham added a project to D20269: Fix typo and constantify arguments: KDE Partition Manager.
Apr 5 2019, 2:35 PM · KDE Partition Manager
shubham requested review of D20269: Fix typo and constantify arguments.
Apr 5 2019, 2:34 PM · KDE Partition Manager