Details
Diff Detail
- Repository
- R353 KCalc
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Could you change the UI to have three columns? It already uses a grid layout, so you can insert a third column.
Button colors
Functions: [FG] [BG]
Numbers: [FG] {BG]etc.
This way it is easier to see the color combinations.
| kcalc.cpp | ||
|---|---|---|
| 2146 | No need to create a color scheme twice. Please reuse schemeButtons for button and text color. | |
| 2153 | Please change casts to qobject_cast (here and below). | |
| kcalc_button.cpp | ||
| 160 | This change can be reverted. The palette.setColor() call below is sufficient. | |
| 163–167 | textColor() returns a QColor, so the cast is not needed. | |
| 228 | Color does not affect the size. Can be removed. | |
| kcalc_button.h | ||
| 70 | QColor textColor() const | |
| 91 | Please rename to text_color_ to make it consistent with other member variables. | |
There is a usability issue with the MR button when the memory is empty. Setting the text color overrides the lighter color that is used for disabled buttons.
I suggest to use something like setAlphaF(0.7) on the color for disabled() buttons before modifying the context's palette.
Hi, I was trying to tell that I removed that code because it was making the configuration not being applied asap when the user clicks the ok button.
| kcalc.cpp | ||
|---|---|---|
| 2146 | Hi, I removed because It was affecting the config behaviour. You can reproduce by changing colors and saving. The application will only change when you restart it. This way, no need to restart anymore. | |