Pushed via 27114916412ad20321cc63af5651a301455bf79a

I'll wait until v5.45 got branched off. No need to hurry with this.

That's just for reading & storing the state of the *document* (i.e. indentation settings, etc. pp.). My patch adds support for reading & storing the state of the *view*, too.

LGTM in general, but please do see my remark.

• Please remove unused code altogether, don't just comment
• Please use Q_UNUSED(var) to mark var as an unused parameter

@antonanikin Yes, that sounds like the best solution.

Please check this, right now we get:

/home/kfunk/devel/src/kf5/kio-extras/thumbnail/thumbnail.cpp:666:5: warning: 'KIO_VERSION' is not defined, evaluates to 0 [-Wundef]
#if KIO_VERSION >= QT_VERSION_CHECK(5, 40, 0)
    ^
1 warning generated.

@huguesmorisset We also need your email address so we can commit this using proper author information. Thanks!

@ematirov Might want to have a look at these and related changes

New version also allows us to add mechanism for temporarily blocking (disabling) some widgets for example "Full Update" button when model reset is started. This now done with using ProblemModel::featuresChanged signal which emitted by cppcheck plugin at start and at the end of analysis.

I have/had no problems with KActionMenu, to be honest. Not sure whether the new ActionMenu is an improvement -- a lot of code will be added which doesn't have a significant impact (I don't find the QComboBox solution appealing either).

In D11278#224484, @kfunk wrote:

Looks like you don't need the member at all? Otherwise late-init wouldn't work this way.

m_configWidget seems only used in showConfig(). Let's remove the member altogether?

Looks like you don't need the member at all? Otherwise late-init wouldn't work this way.

In D10306#201002, @dhaumann wrote:

@kfunk Do you need such a patch in the KDevelop document switcher plugin as well? This code comes from your code after all...

LGTM