ematirov (Mikhail Ivchenko)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2015, 10:52 AM (188 w, 5 d)
Availability
Available

Recent Activity

Sep 25 2017

ematirov committed R59:459750170b33: Update GoBuildSystem implementation (authored by huguesmorisset).
Update GoBuildSystem implementation
Sep 25 2017, 10:37 PM
ematirov closed D7911: Update GoBuildSystem implementation.

Thank you!

Sep 25 2017, 8:16 PM

Aug 19 2017

ematirov committed R59:19ca68dc98b7: Create uses of struct fields in struct literals even when type has complex id (authored by ematirov).
Create uses of struct fields in struct literals even when type has complex id
Aug 19 2017, 5:04 PM

Aug 18 2017

ematirov committed R59:eb2348a35079: Embedd anonymous fields even if they are not pointers (authored by ematirov).
Embedd anonymous fields even if they are not pointers
Aug 18 2017, 7:47 PM
ematirov committed R59:8db80a4c44b3: Create uses of struct fields in struct literals (authored by ematirov).
Create uses of struct fields in struct literals
Aug 18 2017, 7:47 PM

Aug 16 2017

ematirov committed R59:d9ff694cc424: Correctly handle redeclarations - do not redeclare if in same context (authored by ematirov).
Correctly handle redeclarations - do not redeclare if in same context
Aug 16 2017, 6:53 PM

Aug 14 2017

ematirov committed R59:70a1fb2e72c5: Fix handling of literal values inside assignments and declarations (authored by ematirov).
Fix handling of literal values inside assignments and declarations
Aug 14 2017, 7:01 PM
ematirov committed R59:77be5523588a: Better type matching for channels. (authored by ematirov).
Better type matching for channels.
Aug 14 2017, 7:01 PM
ematirov committed R59:e57a6339c07d: Add type matching for sending to channel (authored by ematirov).
Add type matching for sending to channel
Aug 14 2017, 7:01 PM

Aug 8 2017

ematirov committed R32:be735d44a5ad: Setup QCollator into ctor instead of lessThan. Also, remove unneeded includes. (authored by ematirov).
Setup QCollator into ctor instead of lessThan. Also, remove unneeded includes.
Aug 8 2017, 4:59 PM
ematirov committed R32:f3bbf469f42c: [GCI] Add buttons "jump to first (last) item" to… (authored by ematirov).
[GCI] Add buttons "jump to first (last) item" to…
Aug 8 2017, 4:58 PM
ematirov committed R32:02d8e5cec23b: Fix test. Due to latest change OutputWidget have 10 actions by default. (authored by ematirov).
Fix test. Due to latest change OutputWidget have 10 actions by default.
Aug 8 2017, 4:58 PM
ematirov closed D750: [GCI] Add buttons "jump to first (last) item" to standardoutputview/outputwidget. by committing R32:f3bbf469f42c: [GCI] Add buttons "jump to first (last) item" to….
Aug 8 2017, 4:58 PM · KDevelop

Aug 6 2017

ematirov committed R59:9c1e0e5531f3: Fix match quality - 10 is maximum (authored by ematirov).
Fix match quality - 10 is maximum
Aug 6 2017, 6:40 PM
ematirov committed R59:ff780b4e6b8c: Add type matching to code completion on indexed access (arrays, maps) (authored by ematirov).
Add type matching to code completion on indexed access (arrays, maps)
Aug 6 2017, 6:40 PM
ematirov committed R59:5e121060844f: Add type matching to code completion on short var declaration (authored by ematirov).
Add type matching to code completion on short var declaration
Aug 6 2017, 6:40 PM

Aug 3 2017

ematirov committed R59:a2ad294aa8bc: Add multiple return args function completion for multiple assignments (authored by ematirov).
Add multiple return args function completion for multiple assignments
Aug 3 2017, 5:54 PM

Aug 1 2017

ematirov committed R59:574fc474e9f8: Refactor code completion type matching. Match type on multi-assignments. (authored by ematirov).
Refactor code completion type matching. Match type on multi-assignments.
Aug 1 2017, 5:55 PM
ematirov committed R59:6b94724d62bb: Add possibility to search in parent contexts in helper (authored by ematirov).
Add possibility to search in parent contexts in helper
Aug 1 2017, 5:55 PM
ematirov committed R59:761386be9803: Add members completion even if continuing on another line (authored by ematirov).
Add members completion even if continuing on another line
Aug 1 2017, 5:55 PM

Jul 26 2017

ematirov committed R59:8fd0b34ea362: Fix handling function declaration \ definition in htmlFunction (authored by ematirov).
Fix handling function declaration \ definition in htmlFunction
Jul 26 2017, 6:26 PM

Jul 25 2017

ematirov committed R59:1a57b386b73e: Fix clang build (authored by ematirov).
Fix clang build
Jul 25 2017, 4:55 PM
ematirov committed R59:f74c5a4a803a: Fix build (authored by ematirov).
Fix build
Jul 25 2017, 2:53 PM
ematirov committed R59:1d6833c30e6b: Add support for linting via Go Meta Linter (authored by ematirov).
Add support for linting via Go Meta Linter
Jul 25 2017, 2:37 PM
ematirov committed R59:93db9146083a: Fix struct handling. (authored by ematirov).
Fix struct handling.
Jul 25 2017, 2:37 PM
ematirov committed R59:fab7ebd6e6e6: Fix some issues in retrieving args\return args (authored by ematirov).
Fix some issues in retrieving args\return args
Jul 25 2017, 2:37 PM

Jul 19 2017

ematirov committed R59:092b0f48eedb: Fix tabs misuse in whole repository (authored by ematirov).
Fix tabs misuse in whole repository
Jul 19 2017, 6:44 PM
ematirov committed R59:fe8a6dfbcfce: Update README.md (authored by ematirov).
Update README.md
Jul 19 2017, 6:44 PM
ematirov committed R59:8d271225f55e: Update modification revision while parsing (authored by ematirov).
Update modification revision while parsing
Jul 19 2017, 6:44 PM

Jul 18 2017

ematirov committed R59:8271acce0fb1: Add predefined source formatter style for customscript - Go fmt (authored by ematirov).
Add predefined source formatter style for customscript - Go fmt
Jul 18 2017, 6:23 PM
ematirov committed R59:93d1b13a46ed: Create use of method reciever (authored by ematirov).
Create use of method reciever
Jul 18 2017, 6:23 PM

Jul 16 2017

ematirov committed R59:c39aa4208116: Add support for launching and configuring build directory (authored by ematirov).
Add support for launching and configuring build directory
Jul 16 2017, 4:47 PM

Jul 13 2017

ematirov committed R59:3f66aa484e89: Initialize GoFunctionDefinitionData in constructor (authored by ematirov).
Initialize GoFunctionDefinitionData in constructor
Jul 13 2017, 7:00 PM
ematirov committed R59:3d7f8687b017: Refactor method handling. Make it more correct. (authored by ematirov).
Refactor method handling. Make it more correct.
Jul 13 2017, 5:49 PM
ematirov committed R59:d140f46853fa: Fix calling lexer.at with index = -1 (authored by ematirov).
Fix calling lexer.at with index = -1
Jul 13 2017, 5:49 PM

Jul 6 2017

ematirov committed R59:c105a9ed778e: Fix multi-line strings in tests (authored by ematirov).
Fix multi-line strings in tests
Jul 6 2017, 5:42 PM

Jul 5 2017

ematirov added a comment to D6316: Add codecompletion from embedded structs.

Doesn't that become a problem when you extend the range during editing?

Oh, got it. Yeah, there is some problems with method declaration context if I don't update range. Syntax highlighting works fine but there is problems with code browsers, looks like it cannot find correct context by range. Updating range by currentContext()->setRange(editorFindRange(node, 0)); helps but I'm not sure that it's correct since there could be some other declarations not related to that type between type declaration and method declaration; although, looks like it works.

Jul 5 2017, 6:27 PM · KDevelop
ematirov added a comment to D6316: Add codecompletion from embedded structs.

No, I was thinking that the next block with the openContext(...) should automatically re-use the internalContext() of the declaration if that is indeed the same. In any case, when looking at it like this, don't you need to set the new range on the context? Doesn't that become a problem when you extend the range during editing?

Jul 5 2017, 4:15 PM · KDevelop

Jul 4 2017

ematirov added inline comments to D6316: Add codecompletion from embedded structs.
Jul 4 2017, 6:27 PM · KDevelop
ematirov committed R59:7ef32afca55c: Fix context handling and improve code completion. (authored by ematirov).
Fix context handling and improve code completion.
Jul 4 2017, 6:27 PM
ematirov closed D6316: Add codecompletion from embedded structs by committing R59:7ef32afca55c: Fix context handling and improve code completion..
Jul 4 2017, 6:27 PM · KDevelop

Jul 2 2017

ematirov committed R59:a61ed96f2688: Refactor and fix DU-Chain creation (authored by ematirov).
Refactor and fix DU-Chain creation
Jul 2 2017, 6:02 PM
ematirov closed D6412: Refactor and fix DU-Chain creation by committing R59:a61ed96f2688: Refactor and fix DU-Chain creation.
Jul 2 2017, 6:02 PM · KDevelop
ematirov committed R59:32e1f712ae0b: Fix test (authored by ematirov).
Fix test
Jul 2 2017, 5:00 PM
ematirov committed R59:bc634f810a50: Create function context even if it's declared as member of struct (authored by ematirov).
Create function context even if it's declared as member of struct
Jul 2 2017, 4:36 PM

Jun 28 2017

ematirov updated the diff for D6316: Add codecompletion from embedded structs.

Updated. Based on https://phabricator.kde.org/D6412 work. Now code highlighting works correctly too.

Jun 28 2017, 7:43 PM · KDevelop
ematirov added a comment to D6412: Refactor and fix DU-Chain creation.

Thank you for your review!

Jun 28 2017, 9:47 AM · KDevelop
ematirov updated the diff for D6412: Refactor and fix DU-Chain creation.

Use review suggestion.

Jun 28 2017, 9:39 AM · KDevelop

Jun 27 2017

ematirov created D6412: Refactor and fix DU-Chain creation.
Jun 27 2017, 7:51 PM · KDevelop

Jun 26 2017

ematirov added a comment to D6316: Add codecompletion from embedded structs.

Yeah, looks like there is problem with reusing but not because of 2 runs - visitMethodDeclaration opens new declaration for type :-/
See code and resulting DU-Chain: https://paste.kde.org/pmjuqk7ld (declarations on lines 14 and 15)
I tried to:

Jun 26 2017, 1:42 PM · KDevelop

Jun 25 2017

ematirov added a comment to D6316: Add codecompletion from embedded structs.

If I do that inside

Jun 25 2017, 7:21 PM · KDevelop
ematirov added a comment to D6316: Add codecompletion from embedded structs.

I wonder -- is this the right place for that logic? Does it work in highlighting, for example?

Jun 25 2017, 6:19 PM · KDevelop

Jun 24 2017

ematirov committed R59:937b33eaeef7: Add uses to correct context (authored by ematirov).
Add uses to correct context
Jun 24 2017, 1:57 PM

Jun 23 2017

ematirov committed R59:9d1412a26d41: Add simple console app template (authored by ematirov).
Add simple console app template
Jun 23 2017, 6:21 PM
ematirov committed R59:26783010c7b3: Report parse errors as problems (authored by ematirov).
Report parse errors as problems
Jun 23 2017, 6:21 PM

Jun 21 2017

ematirov created D6316: Add codecompletion from embedded structs.
Jun 21 2017, 3:11 PM · KDevelop

Jun 19 2017

ematirov committed R59:4e9d59706608: Declare variables in parameters of function literals (authored by ematirov).
Declare variables in parameters of function literals
Jun 19 2017, 7:14 PM
ematirov closed D6272: Declare variables in parameters of function literals by committing R59:4e9d59706608: Declare variables in parameters of function literals.
Jun 19 2017, 7:14 PM · KDevelop
ematirov created D6272: Declare variables in parameters of function literals.
Jun 19 2017, 12:41 PM · KDevelop
ematirov committed R59:b4de161565e9: Basic support for building Go projects. (authored by ematirov).
Basic support for building Go projects.
Jun 19 2017, 12:28 PM
ematirov closed D5188: [WIP] Basic support for building Go projects. by committing R59:b4de161565e9: Basic support for building Go projects..
Jun 19 2017, 12:28 PM
ematirov added a comment to D5188: [WIP] Basic support for building Go projects..
In D5188#117158, @apol wrote:

What needs to happen to have this merged?

Jun 19 2017, 12:19 PM

Jun 17 2017

ematirov committed R59:7d576419f3e8: Fix multiline strings behavior (authored by ematirov).
Fix multiline strings behavior
Jun 17 2017, 4:19 PM
ematirov closed D6219: Add tests for multi-line strings and fix them. by committing R59:7d576419f3e8: Fix multiline strings behavior.
Jun 17 2017, 4:19 PM · KDevelop
ematirov committed R59:1ccba14fb380: Add tests for multiline strings (authored by ematirov).
Add tests for multiline strings
Jun 17 2017, 4:18 PM
ematirov committed R59:8575b935f2ad: Fix runes parsing. (authored by ematirov).
Fix runes parsing.
Jun 17 2017, 4:18 PM
ematirov committed R59:dde11815bf89: Add tests for loops (authored by ematirov).
Add tests for loops
Jun 17 2017, 4:18 PM
ematirov closed D6218: Fix runes parsing. by committing R59:8575b935f2ad: Fix runes parsing..
Jun 17 2017, 4:18 PM · KDevelop
ematirov committed R59:5500d0dbbcff: Add tests for short variable declarations (authored by ematirov).
Add tests for short variable declarations
Jun 17 2017, 4:18 PM
ematirov committed R59:94e5a3429b53: Document comments skipping in lexer (authored by ematirov).
Document comments skipping in lexer
Jun 17 2017, 4:18 PM
ematirov closed D6217: Add tests by committing R59:dde11815bf89: Add tests for loops.
Jun 17 2017, 4:18 PM · KDevelop
ematirov committed R59:877b7ca14bbb: Add tests for numbers (authored by ematirov).
Add tests for numbers
Jun 17 2017, 4:18 PM
ematirov committed R59:1859c4a7467c: Use Go tool for obtaining GOPATH (authored by ematirov).
Use Go tool for obtaining GOPATH
Jun 17 2017, 3:08 PM
ematirov committed R59:89f22135792f: Fix duplicates in navigation widget (authored by ematirov).
Fix duplicates in navigation widget
Jun 17 2017, 3:08 PM

Jun 14 2017

ematirov updated the diff for D6217: Add tests.

Add tests for loops.

Jun 14 2017, 6:36 PM · KDevelop
ematirov added inline comments to D6218: Fix runes parsing..
Jun 14 2017, 12:20 PM · KDevelop
ematirov updated the diff for D6218: Fix runes parsing..

Remove unneeded comment.

Jun 14 2017, 12:18 PM · KDevelop

Jun 13 2017

ematirov added inline comments to D6218: Fix runes parsing..
Jun 13 2017, 6:13 PM · KDevelop
ematirov updated the diff for D5188: [WIP] Basic support for building Go projects..

Set tool view for build job.
Add project files filter

Jun 13 2017, 5:26 PM
ematirov created D6219: Add tests for multi-line strings and fix them..
Jun 13 2017, 5:05 PM · KDevelop
ematirov created D6218: Fix runes parsing..
Jun 13 2017, 4:59 PM · KDevelop
ematirov created D6217: Add tests.
Jun 13 2017, 4:55 PM · KDevelop

May 16 2017

ematirov added a comment to D5188: [WIP] Basic support for building Go projects..
In D5188#110166, @arrowdodger wrote:

There is no "project file" in Go, but specifying "*.go" as mimetype works perfect.

Doesn't Go has its own build system? This should serve as "project file", like Makefiles or CMakeLists.txt for C/C++.

May 16 2017, 7:09 PM
ematirov added a comment to D5188: [WIP] Basic support for building Go projects..

Ping? I think other than the mimetype issue, this is OK to get merged. Do you have commit rights?

May 16 2017, 5:36 PM

Mar 30 2017

ematirov added inline comments to D5122: Allow users to install via a custom root installation command.
Mar 30 2017, 5:04 PM · KDevelop

Mar 29 2017

ematirov updated the diff for D5188: [WIP] Basic support for building Go projects..

Fix review suggestions. Make folders of project buildable by right-clicking.
Suggestions about naming are welcome - I renamed folder to buildsystem but classes should have Go prefix I think, for easier debug \ etc. (It looks strange to make break BuildSystem::methodName without prefix IMHO). However, I'm not sure if files should contains that "Go" prefix.

Mar 29 2017, 6:31 PM

Mar 26 2017

ematirov created D5188: [WIP] Basic support for building Go projects..
Mar 26 2017, 6:53 PM
ematirov committed R59:2a3a31152207: Adapt to kdevplatform changes. (authored by ematirov).
Adapt to kdevplatform changes.
Mar 26 2017, 6:02 PM
ematirov closed D5176: Adapt to kdevplatform changes. by committing R59:2a3a31152207: Adapt to kdevplatform changes..
Mar 26 2017, 6:02 PM

Mar 25 2017

ematirov created D5176: Adapt to kdevplatform changes..
Mar 25 2017, 5:06 PM

Feb 24 2017

ematirov committed R32:5276b1b4ea39: Add path escaping to cmake completion. (authored by ematirov).
Add path escaping to cmake completion.
Feb 24 2017, 5:19 PM
ematirov closed D4760: Add path escaping to cmake completion. by committing R32:5276b1b4ea39: Add path escaping to cmake completion..
Feb 24 2017, 5:19 PM
ematirov updated the diff for D4760: Add path escaping to cmake completion..
Feb 24 2017, 2:40 PM
ematirov updated the summary of D4760: Add path escaping to cmake completion..
Feb 24 2017, 2:04 PM
ematirov created D4760: Add path escaping to cmake completion..
Feb 24 2017, 2:02 PM

Dec 5 2016

ematirov added a comment to D3597: Investigate warnings and fix them [3].

LGTM, thanks.

Dec 5 2016, 6:49 PM
ematirov added inline comments to D3597: Investigate warnings and fix them [3].
Dec 5 2016, 5:19 PM

Dec 3 2016

ematirov added a comment to D3580: Investigate warnings and fix where it's possible and needed (kdevplatform) [1].

LGTM!
Thanks, good work.

Dec 3 2016, 7:30 PM
ematirov added inline comments to D3580: Investigate warnings and fix where it's possible and needed (kdevplatform) [1].
Dec 3 2016, 5:12 PM
ematirov added a comment to D3580: Investigate warnings and fix where it's possible and needed (kdevplatform) [1].

Thanks! Just some more nitpicks.

Dec 3 2016, 4:53 PM