Differential D9831

Add Windows notes for network related test applications
ClosedPublic
Actions

Authored by habacker on Jan 11 2018, 9:48 PM.

Details

Reviewers
dfaure
kfunk
Commits
R239:a874b6a67643: Add Windows notes for network related test applications
Test Plan

verified hints by cross compiled installation

Diff Detail

Repository
R239 KDELibs4Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
habacker requested review of this revision.Jan 11 2018, 9:48 PM
habacker created this revision.
kfunk accepted this revision.Jan 19 2018, 12:11 AM
This revision is now accepted and ready to land.Jan 19 2018, 12:11 AM
kfunk requested changes to this revision.Jan 19 2018, 12:13 AM

Well, at least keep the same Markdown style in the file (## vs. ---...)

Actually, I'd also rather move that note to tests/README.md. The information in the root README.md is for consumers of kdelibs4support, not for developers working on it.

This revision now requires changes to proceed.Jan 19 2018, 12:13 AM
habacker updated this revision to Diff 25661.Jan 19 2018, 10:27 PM
habacker retitled this revision from Add Windows notes collected on finding issues in network related test applications to Add Windows notes for network related test applications.
  • moved notes to tests/README.md
kfunk accepted this revision.Jan 19 2018, 11:07 PM

LGTM

This revision is now accepted and ready to land.Jan 19 2018, 11:07 PM
dfaure accepted this revision.Jan 21 2018, 9:29 PM
Closed by commit R239:a874b6a67643: Add Windows notes for network related test applications (authored by habacker). · Explain WhyJan 22 2018, 11:41 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 22 2018, 11:41 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript

Revision Contents
Changeset List

PathPackages
AMtests/README.md (13 lines)

Diff 25747

View Options

tests/README.md

Loading...