clang-tidy: modernize-use-default-member-init run
ClosedPublic

Authored by kfunk on Mar 23 2018, 12:46 PM.

Details

Summary

Playing a bit around with clang-tidy's new checkers.

Please have a thorough review. I didn't find anything wrong in the patch, but another pair of eyes won't hurt.

Test Plan

No new test failures in a ctest run. However some vimode related unit tests before & after failed for me:

The following tests FAILED:
         63 - vimode_modes (Failed)
         67 - vimode_emulatedcommandbar (Failed)

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Mar 23 2018, 12:46 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMar 23 2018, 12:46 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
kfunk requested review of this revision.Mar 23 2018, 12:46 PM
kfunk edited the summary of this revision. (Show Details)Mar 23 2018, 12:55 PM
kfunk edited the test plan for this revision. (Show Details)

I like this a lot, but have not done a review yet. Will do later.

dhaumann accepted this revision.Mar 24 2018, 8:44 AM

The patch looks good. Please commit this weekend, or wait until next Saturday's v5.45 branch.

This revision is now accepted and ready to land.Mar 24 2018, 8:44 AM
kfunk added a comment.Mar 25 2018, 8:07 PM

I'll wait until v5.45 got branched off. No need to hurry with this.

Btw, I messed up the dates. Tag is next Saturday after today...

This revision was automatically updated to reflect the committed changes.