Feed Advanced Search

Fri, Jan 19

kfunk accepted D9831: Add Windows notes for network related test applications.

LGTM

Fri, Jan 19, 11:07 PM · Frameworks
kfunk committed R53:622613e0256b: cmake: Search for KDevPlatform config files only (authored by kfunk).
cmake: Search for KDevPlatform config files only
Fri, Jan 19, 9:41 PM
kfunk committed R52:de7ce6c291bf: cmake: Search for KDevPlatform config files only (authored by kfunk).
cmake: Search for KDevPlatform config files only
Fri, Jan 19, 9:40 PM
kfunk committed R32:1599bbe2946f: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Fri, Jan 19, 9:36 PM
kfunk requested changes to D9831: Add Windows notes for network related test applications.

Well, at least keep the same Markdown style in the file (## vs. ---...)

Fri, Jan 19, 12:13 AM · Frameworks
kfunk accepted D9831: Add Windows notes for network related test applications.
Fri, Jan 19, 12:11 AM · Frameworks

Thu, Jan 18

kfunk closed D9901: Search&Replace: Make exclude filter work on the relative subdirs.

Closing, as this Diff got pushed already. See https://commits.kde.org/kate/749fa3b25f0b26c61e0c15004d490d77ce21dea0

Thu, Jan 18, 9:32 PM · Kate
kfunk committed R32:57e452e5a16b: debuggercommon: Remove number of lines printed (authored by kfunk).
debuggercommon: Remove number of lines printed
Thu, Jan 18, 1:51 PM
kfunk committed R877:159bf6f0dbf2: Add blueprint for labplot (authored by kfunk).
Add blueprint for labplot
Thu, Jan 18, 11:14 AM
kfunk committed R32:7f437abd05d0: Attempt to work-around GCC 4.7 bug (authored by kfunk).
Attempt to work-around GCC 4.7 bug
Thu, Jan 18, 10:46 AM
kfunk added a comment to D9766: Use at least the requested width for the argument hint tree.

Whoops. Sorry for accidentally reopening it to begin with.

Thu, Jan 18, 10:32 AM · Frameworks, Kate
kfunk committed R32:39c110e3fdb0: Link against KF5::Purpose if it's available (authored by mwolff).
Link against KF5::Purpose if it's available
Thu, Jan 18, 10:25 AM
kfunk committed R32:51233ccddf0c: Fix ctestsuites unit test (authored by mihac).
Fix ctestsuites unit test
Thu, Jan 18, 10:25 AM
kfunk committed R877:4a8599379dc7: kdevelop: Default to v5.2.1 (authored by kfunk).
kdevelop: Default to v5.2.1
Thu, Jan 18, 9:47 AM

Wed, Jan 17

kfunk committed R877:64ac9d8688f8: okteta: Don't ignore qca while packaging (authored by kfunk).
okteta: Don't ignore qca while packaging
Wed, Jan 17, 2:35 PM
kfunk committed R877:6c8bf201aea9: Okteta: Requires QCA, too (authored by kfunk).
Okteta: Requires QCA, too
Wed, Jan 17, 2:26 PM
kfunk committed R32:59a0edf7552e: test_documentcontroller: Speed up test (authored by kfunk).
test_documentcontroller: Speed up test
Wed, Jan 17, 9:53 AM
kfunk committed R32:1c2334df0626: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Wed, Jan 17, 8:37 AM
kfunk committed R32:6e1ed6699780: test_shell*: Speed up tests (authored by kfunk).
test_shell*: Speed up tests
Wed, Jan 17, 8:36 AM

Tue, Jan 16

kfunk committed R32:2e7407940956: test_compilerprovider: Do not load all plugins (authored by kfunk).
test_compilerprovider: Do not load all plugins
Tue, Jan 16, 11:04 PM
kfunk committed R32:8d47edae98b6: test_gdb: Don't hang in GdbTest::testCoreFile (authored by kfunk).
test_gdb: Don't hang in GdbTest::testCoreFile
Tue, Jan 16, 10:59 PM
kfunk committed R32:c6f68e54af89: test_path: Fix unit tests (authored by kfunk).
test_path: Fix unit tests
Tue, Jan 16, 10:47 PM
kfunk committed R32:ad2348149278: Properly quote expected string value in lldb formatter unittests (authored by Peifeng Yu <peifeng@umich.edu>).
Properly quote expected string value in lldb formatter unittests
Tue, Jan 16, 10:19 PM
kfunk accepted D9929: Properly quote expected string value in lldb formatter unittests.
Tue, Jan 16, 6:38 PM
kfunk reopened D9766: Use at least the requested width for the argument hint tree.

Just a had a quick look at the appearance of the popup before vs. after the patch when doing code completion inside the a function call parameter list. Looks more consisten now, thanks!

Tue, Jan 16, 2:51 PM · Frameworks, Kate
kfunk committed R32:8a4df7951a15: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Tue, Jan 16, 2:36 PM
kfunk committed R32:a2a4632e9401: Unbreak the GDB QUrl pretty printer test (authored by mwolff).
Unbreak the GDB QUrl pretty printer test
Tue, Jan 16, 2:32 PM
kfunk committed R32:7a47aa5cc869: Unbreak QtPrintersTest::testQString (authored by mwolff).
Unbreak QtPrintersTest::testQString
Tue, Jan 16, 2:32 PM
kfunk committed R32:7add59d4e142: Also unbreak QtPrintersTest::testQByteArray (authored by mwolff).
Also unbreak QtPrintersTest::testQByteArray
Tue, Jan 16, 2:32 PM
kfunk accepted D9924: Also unbreak QtPrintersTest::testQByteArray.
Tue, Jan 16, 1:41 PM
kfunk accepted D9923: Unbreak QtPrintersTest::testQString.
Tue, Jan 16, 1:40 PM
kfunk accepted D9922: Unbreak the GDB QUrl pretty printer test.
Tue, Jan 16, 1:40 PM
kfunk accepted D9918: GDB Qt pretty printers: print size of container.

I like the idea in general, but not really the string representation of the size.

Tue, Jan 16, 1:10 PM
kfunk committed R134:d2ed573fe073: cmake: Prefer CONFIG in find_package where possible (authored by kfunk).
cmake: Prefer CONFIG in find_package where possible
Tue, Jan 16, 1:00 PM

Mon, Jan 15

kfunk committed R32:e6ee67c23ae3: work around bug in kLineEdit (authored by dweatherill).
work around bug in kLineEdit
Mon, Jan 15, 8:06 PM
kfunk closed D9809: work around bug in kLineEdit.
Mon, Jan 15, 8:06 PM · KDevelop
kfunk committed R32:2adeca0d03f3: Minor: Fix -Wunused-lambda-capture warning (authored by kfunk).
Minor: Fix -Wunused-lambda-capture warning
Mon, Jan 15, 12:11 PM
kfunk committed R32:f0fbcb7e6f52: fix crash when stopping process (authored by brauch).
fix crash when stopping process
Mon, Jan 15, 12:11 PM

Thu, Jan 11

kfunk committed R68:767615929cc8: Do not crash if there is still pending connections (authored by wcancino).
Do not crash if there is still pending connections
Thu, Jan 11, 7:38 PM
kfunk closed D9034: Do not crash if there is still pending connections .
Thu, Jan 11, 7:38 PM

Wed, Jan 10

kfunk accepted D9772: Cache ProblemPointers per translation unit.

To 5.2 branch please.

Wed, Jan 10, 10:28 AM
kfunk committed R32:3881efbda3e7: Remove unused file (authored by mlaurent).
Remove unused file
Wed, Jan 10, 10:24 AM
kfunk committed R32:64c125114edb: Remove unused file (authored by mlaurent).
Remove unused file
Wed, Jan 10, 10:24 AM
kfunk accepted D9783: Performance: Reuse the global icon loader.

Whoop.s My code. Sorry.

Wed, Jan 10, 10:13 AM
kfunk accepted D9778: Only set CMAKE_AUTOMOC_MACRO_NAMES with KF5 < 5.42.
Wed, Jan 10, 8:37 AM

Tue, Jan 9

kfunk accepted D9760: Fix kded dbus name in solid-networking howto.
Tue, Jan 9, 1:21 PM · Frameworks
kfunk accepted D9760: Fix kded dbus name in solid-networking howto.

src/solid-networkstatus/DESIGN also still references org.kde.kded. Please update, too.

Tue, Jan 9, 1:03 PM · Frameworks
kfunk requested changes to D9624: Install parser headers and cmake config files to support client packages.
Tue, Jan 9, 1:00 PM
kfunk abandoned D4411: UnknownDeclarationProblem: scan headers on a background thread to preserve GUI responsiveness (WIP).

Abandoning as this is clearly not the right way to fix the issue at hand.

Tue, Jan 9, 11:55 AM · KDevelop
kfunk commandeered D4411: UnknownDeclarationProblem: scan headers on a background thread to preserve GUI responsiveness (WIP).
Tue, Jan 9, 11:54 AM · KDevelop
kfunk accepted D9725: clang: Improve argument hint code completion.

Nice changes!

Tue, Jan 9, 8:26 AM
kfunk committed R32:9761e029d65c: Format comments before setting them on the DUChain (authored by mwolff).
Format comments before setting them on the DUChain
Tue, Jan 9, 8:23 AM
kfunk committed R32:2f2ac007eaca: Format comments before setting them on the DUChain (authored by mwolff).
Format comments before setting them on the DUChain
Tue, Jan 9, 8:23 AM
kfunk added a comment to D9750: ExpandingWidgetModel: find the right-most column based on location.

LGTM, but I'll let someone else approve.

Tue, Jan 9, 8:21 AM · Frameworks, Kate
kfunk accepted D9749: Simplify code: return early to reduce indentation depth.
Tue, Jan 9, 8:19 AM · Frameworks, Kate
kfunk committed R32:753d192afa5e: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Tue, Jan 9, 7:51 AM
kfunk committed R32:56416bdde632: Set toolbar/toolbutton font on quickopen line edit (authored by mwolff).
Set toolbar/toolbutton font on quickopen line edit
Tue, Jan 9, 7:49 AM
kfunk accepted D9745: Workaround: find declarations for constructor argument hints.
Tue, Jan 9, 7:32 AM
kfunk accepted D9744: Further extend the argument hint code completion test coverage.
Tue, Jan 9, 7:31 AM
kfunk accepted D9743: Extend test coverage for argument hint code completion.
Tue, Jan 9, 7:26 AM
kfunk accepted D9724: Fix: correct order of QCOMPARE(actual, expected).
Tue, Jan 9, 7:25 AM
kfunk accepted D9723: Unbreak most of the clang codecompletion test by passing file contents.
Tue, Jan 9, 7:25 AM
kfunk accepted D9722: Resume background parser when replacing TestCore's project controller.
Tue, Jan 9, 7:21 AM
kfunk accepted D9720: Cleanup: Reduce amount of ifdefs.
Tue, Jan 9, 7:20 AM
kfunk accepted D9747: Remove dead code.

+1 if it still compiles

Tue, Jan 9, 7:19 AM

Dec 22 2017

kfunk accepted D9469: Fix build of knotifications on Mac.

Thanks!

Dec 22 2017, 5:18 PM

Dec 20 2017

kfunk added a comment to D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'.

@dfaure Opinions?

Dec 20 2017, 4:55 PM · Frameworks
kfunk added a comment to D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'.
In D9423#181442, @kfunk wrote:

And I agree. There shouldn't be a need to use two different input files. That's the whole point of configure_file(...): the interpolation of values happens *inside* the input files.

This would be possible by using in the service file something like this

[D-BUS Service]
Name=org.kde.kiod5
Exec=@SOME_PREFIX@kiod5

Dec 20 2017, 4:54 PM · Frameworks
kfunk added a comment to D9424: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file.

Please let's discuss on https://phabricator.kde.org/D9423 exclusively. This is basically fixing the same issue in a different repository.

Dec 20 2017, 4:44 PM · Frameworks
kfunk requested changes to D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'.

And I agree. There shouldn't be a need to use two different input files. That's the whole point of configure_file(...): the interpolation of values happens *inside* the input files.

Dec 20 2017, 11:42 AM · Frameworks
kfunk added a comment to D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'.

Could you please squash the commits and just keep this review for all the changes in KIO? Doesn't make sense to have different Phab Diffs for that (makes it harder to review, harder to revert in case, etc.).

Dec 20 2017, 11:40 AM · Frameworks

Dec 19 2017

kfunk accepted D9210: Remove unused persistentsetmap.h.

this was used by oldcpp, and we could (should!) actually leverage this by kdev-clang to store more information about the parsing environment, such that we can later check whether it has changed and also show the user what was used. That said, maybe persisting a simple vector of strings is enough for that purpose...

Was that in some branch? Grepping with gitk in changes on the kdevelop repo did not have any hits, neither "PersistentSetMap" nor "persistentsetmap.h" (besides the introducing commit itself).

Dec 19 2017, 10:35 PM
kfunk accepted D9316: Remove KF5::ItemModels from public interface of KDevPlatformUtil.

Whatever. Go for it.

Dec 19 2017, 10:31 PM
kfunk committed R877:b62f4d840a6b: skrooge: Add more deps (authored by kfunk).
skrooge: Add more deps
Dec 19 2017, 5:16 PM
kfunk committed R320:5e6c6fe0c7a1: Fix TagLib detection and build on Windows (authored by kfunk).
Fix TagLib detection and build on Windows
Dec 19 2017, 12:30 PM
kfunk closed D9398: Fix TagLib detection and build on Windows.
Dec 19 2017, 12:30 PM
kfunk committed R877:0be2d6083a97: kirigami: Tarballs are still named kirigami2 (authored by kfunk).
kirigami: Tarballs are still named kirigami2
Dec 19 2017, 12:25 PM
kfunk created D9408: extractors: Hide warnings from system headers.
Dec 19 2017, 12:17 PM · Frameworks
kfunk committed R138:bf7668cc4cbf: Fix typo (authored by kfunk).
Fix typo
Dec 19 2017, 11:43 AM
kfunk committed R877:a2981f05d549: Move kirigami2 -> kirigami (authored by kfunk).
Move kirigami2 -> kirigami
Dec 19 2017, 11:41 AM
kfunk committed R39:d00275c443e5: Add missing include for std::array (authored by kfunk).
Add missing include for std::array
Dec 19 2017, 11:26 AM
kfunk committed R283:36b52b855a35: Fix CMake AUTOMOC warning (authored by kfunk).
Fix CMake AUTOMOC warning
Dec 19 2017, 10:14 AM
kfunk committed R245:f2be348e971d: Fix minor CMake warning (authored by kfunk).
Fix minor CMake warning
Dec 19 2017, 9:20 AM
kfunk committed R157:b242c85c4d98: Modernize: Use nullptr (authored by kfunk).
Modernize: Use nullptr
Dec 19 2017, 8:56 AM
kfunk committed R157:185a8114357a: Modernize: Use override everywhere (authored by kfunk).
Modernize: Use override everywhere
Dec 19 2017, 8:56 AM

Dec 18 2017

kfunk committed R320:575e25d3fb02: Fix some CMake AUTOMOC warnings (authored by kfunk).
Fix some CMake AUTOMOC warnings
Dec 18 2017, 10:41 PM
kfunk committed R320:355f89b466a2: Modernize: Use override (authored by kfunk).
Modernize: Use override
Dec 18 2017, 10:41 PM
kfunk committed R320:394dc54249e1: Modernize: Use nullptr (authored by kfunk).
Modernize: Use nullptr
Dec 18 2017, 10:41 PM
kfunk committed R320:7c75eef89158: CMake: Fix minor warning (authored by kfunk).
CMake: Fix minor warning
Dec 18 2017, 10:35 PM
kfunk committed R320:1859d5addaf4: Hide compiler warnings we are not interested in (authored by kfunk).
Hide compiler warnings we are not interested in
Dec 18 2017, 10:33 PM
kfunk accepted D9398: Fix TagLib detection and build on Windows.
Dec 18 2017, 10:29 PM

Dec 15 2017

kfunk added a comment to D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes.

Sorry for being late, but I didn't have time to follow up on this one.

Dec 15 2017, 3:58 PM · Build System, Frameworks

Dec 14 2017

kfunk committed R216:fb80c0549aed: Fix another CMake CMP0071 warning (authored by kfunk).
Fix another CMake CMP0071 warning
Dec 14 2017, 11:15 AM
kfunk closed D9321: Fix another CMake CMP0071 warning.
Dec 14 2017, 11:15 AM · Frameworks
kfunk added reviewers for D9321: Fix another CMake CMP0071 warning: mlaurent, dfaure.
Dec 14 2017, 8:51 AM · Frameworks
kfunk created D9321: Fix another CMake CMP0071 warning.
Dec 14 2017, 8:50 AM · Frameworks

Dec 13 2017

kfunk committed R32:f2ad67414318: Minor: Fix string, respect KDE HIG (authored by kfunk).
Minor: Fix string, respect KDE HIG
Dec 13 2017, 10:42 PM
kfunk committed R32:9956d5c6d941: test_astyle: Fix test after astyle upgrade (authored by kfunk).
test_astyle: Fix test after astyle upgrade
Dec 13 2017, 10:42 PM
kfunk committed R32:8086bbe04430: SourceFormatterSelectionEdit: Add a bit more debug (authored by kfunk).
SourceFormatterSelectionEdit: Add a bit more debug
Dec 13 2017, 10:42 PM
kfunk committed R32:aecd24c2f384: Update to astyle 2.06 to fix licensing issues (authored by kfunk).
Update to astyle 2.06 to fix licensing issues
Dec 13 2017, 10:42 PM