Sorry for my conservative thinking again: Debian Buster (10) is still /very/ fresh; it was just released a couple days ago. The former "oldest" supported distro was Debian Stretch (9) with Qt 5.7 and KF 5.28. That'll stick around for some time.
Fri, Jul 19
Thu, Jul 18
Wed, Jun 26
Oh, I usually squash my changes into the original commit before uploading the change (i.e. via arc diff). I do not use an extra branch either.
Huh? It's easier than that:
If you're not using arc you should have included the "Differential Revision" line in the commit so it would close automatically as stated in https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
I'll close this manually for you :)
In the phabricator guide it is suggested to push manually when the target branch in not master:
Wouldn't make more sense to do arc land --onto 5.3 (and then merge 5.3 into master)? In this way the Differential Revision would be closed automatically.
Mon, Jun 24
Jun 3 2019
May 29 2019
May 27 2019
Works fine for me on Ubuntu 19.04 -- lgtm!
May 23 2019
May 15 2019
It has been failing before: https://invent.kde.org/kde/kdevelop/-/jobs -- The error output suggests it's a different issue.
May 12 2019
May 10 2019
Apr 30 2019
Feel free to push it into the 5.3 branch then.
Apr 26 2019
Apr 25 2019
Apr 24 2019
Apr 15 2019
Thanks for fixing!
Apr 1 2019
As long as it integrates well with the rest of the KDevelop build I'm fine. Would probably just copy the QtPromise source tree into maybe kdevelop.git:3rdparty/ and create a CMakeLists.txt which creates a STATIC or OBJECT library for it? QtPromise looks easy enough to build.
This works, yes, I don't see how that change could break it.
Mar 13 2019
Note: It's Thibault North <firstname.lastname@example.org>
Mar 12 2019
Mar 7 2019
FTR: I think I experienced the same or a similar issue.
By the way, also see: https://stackoverflow.com/a/5195913 wrt why it is dangerous.
Mar 6 2019
Only had a brief look, but this looks good to me! Well, better than letting it bit-rot.
Feb 19 2019
Feb 8 2019
Feb 5 2019
Commit message ideally. Truncate the report where applicable.
Jan 25 2019
Jan 14 2019
Jan 12 2019
Jan 11 2019
Jan 9 2019
Could you give me your full name + email for attribution in the commit?
I think that looks fine. Didn't test though.
Looks good to me. Can you push to 5.3 branch yourself?
@apol Something for you.
5.3 only please. Someone else (or even you) can merge it into master afterwards.
Jan 8 2019
Fixed with dcd5886fd949042765b905b3c67f9f20b18fb028