Diffusion KIO Extras 8b6c4e393bb0

Use KIO::PreviewJob::defaultPlugins()
Needs Verification8b6c4e393bb0
Actions

Authored by ngraham on Oct 21 2017, 2:43 PM.

Description

Use KIO::PreviewJob::defaultPlugins()

Summary:
Use KIO::PreviewJob::defaultPlugins() instead of hardcoding plugin list.

Depends on D8347

Test Plan: Compiles fine in KDE Neon.

Reviewers: Frameworks, broulik, elvisangelaccio, markg

Reviewed By: Frameworks, elvisangelaccio, markg

Differential Revision: https://phabricator.kde.org/D8352

Details

Auditors
kfunk
Committed
ngrahamOct 21 2017, 4:25 PM
Reviewer
Frameworks
Differential Revision
D8352: Use KIO::PreviewJob::defaultPlugins()
Parents
R320:d257cf109c56: Merge branch 'Applications/17.08'
Branches
Unknown
Tags
Unknown
kfunk raised a concern with this commit.Mar 16 2018, 8:36 AM
kfunk added a subscriber: kfunk.

Please check this, right now we get:

/home/kfunk/devel/src/kf5/kio-extras/thumbnail/thumbnail.cpp:666:5: warning: 'KIO_VERSION' is not defined, evaluates to 0 [-Wundef]
#if KIO_VERSION >= QT_VERSION_CHECK(5, 40, 0)
    ^
1 warning generated.
This commit now has outstanding concerns.Mar 16 2018, 8:36 AM
ngraham requested verification of this commit.Jul 17 2018, 11:12 PM

Fixed in 75a3723c45e3cfeae6c57b7661e0a8864f42b51c. Code in question is no longer in master, 18.08, or 18.04 branch; 17.12 branch is obsolete.

This commit now requires verification by auditors.Jul 17 2018, 11:12 PM

Changes (1)

PathPackages
Mthumbnail/thumbnail.cpp

R320:8b6c4e393bb0

View Options

thumbnail/thumbnail.cpp

Loading...