Differential D10121

Refactor DeclarationBuilder::visitMethodDeclaration
Needs RevisionPublic
Actions

Authored by huguesmorisset on Jan 26 2018, 4:32 PM.

Details

Reviewers
kfunk
ematirov
Summary
  • Use unlock() method on DUChain*Locker object instead of using the unlock on destruction when falling out of context
  • Keep the write lock while opening the internal context to prevent a crash

Diff Detail

Repository
R59 KDevelop Go
Lint
Lint Skipped
Unit
Unit Tests Skipped
huguesmorisset created this revision.Jan 26 2018, 4:32 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 26 2018, 4:32 PM
huguesmorisset requested review of this revision.Jan 26 2018, 4:32 PM
mwolff added a subscriber: mwolff.Jan 30 2018, 3:27 PM

why? please give all your commit message clear explanations. usually it should be:

short what summary

longer text explaining what and why
and how you are changing stuff.
huguesmorisset retitled this revision from Divide visitMethodDeclaration into two method to Refactor DeclarationBuilder::visitMethodDeclaration.Feb 1 2018, 6:32 PM
huguesmorisset edited the summary of this revision. (Show Details)
kfunk requested changes to this revision.Mar 22 2018, 6:18 AM
This revision now requires changes to proceed.Mar 22 2018, 6:18 AM

Revision Contents
Changeset List

Diff 26007

View Options

duchain/builders/declarationbuilder.h

Loading...
View Options

duchain/builders/declarationbuilder.cpp

Loading...