Differential D10306

Tab switcher plugin: Escape hides switcher widget
ClosedPublic
Actions

Authored by dhaumann on Feb 4 2018, 8:12 PM.

Details

Reviewers
gregormi
ngraham
cullmann
Commits
R40:2641fc835e5f: Tab switcher plugin: Escape hides switcher widget
Summary

Allow to cancel the tab switching by pressing Escape.

BUG: 389484

Test Plan

make test

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Feb 4 2018, 8:12 PM
Restricted Application added a project: Kate. · View Herald TranscriptFeb 4 2018, 8:12 PM
dhaumann requested review of this revision.Feb 4 2018, 8:12 PM
ngraham accepted this revision.Feb 4 2018, 9:13 PM

Works fine!

This revision is now accepted and ready to land.Feb 4 2018, 9:13 PM
Closed by commit R40:2641fc835e5f: Tab switcher plugin: Escape hides switcher widget (authored by dhaumann). · Explain WhyFeb 4 2018, 9:33 PM
This revision was automatically updated to reflect the committed changes.
dhaumann added a subscriber: kfunk.Feb 4 2018, 9:35 PM

@kfunk Do you need such a patch in the KDevelop document switcher plugin as well? This code comes from your code after all...

kfunk added a comment.EditedFeb 6 2018, 1:13 PM
In D10306#201002, @dhaumann wrote:

@kfunk Do you need such a patch in the KDevelop document switcher plugin as well? This code comes from your code after all...

Thanks for the heads-up.

Patch integrated in KDevelop, too: https://phabricator.kde.org/R32:291158cd9e87e84dd07e4537d1414f2fe48dde66

Revision Contents
Changeset List

Diff 26539

View Options

addons/tabswitcher/tabswitchertreeview.h

Loading...
View Options

addons/tabswitcher/tabswitchertreeview.cpp

Loading...