Check declareVariable type exist
Needs RevisionPublic

Authored by huguesmorisset on Jan 26 2018, 4:34 PM.

Details

Reviewers
kfunk
ematirov

Diff Detail

Repository
R59 KDevelop Go
Lint
Lint Skipped
Unit
Unit Tests Skipped
huguesmorisset created this revision.Jan 26 2018, 4:34 PM
Restricted Application added a subscriber: kdevelop-devel. ยท View Herald TranscriptJan 26 2018, 4:34 PM
huguesmorisset requested review of this revision.Jan 26 2018, 4:34 PM
mwolff added a subscriber: mwolff.Jan 30 2018, 3:26 PM

this looks bogus, why do you not return a type? shouldn't you rather set some type higher up?

overall, this begs for a unit test and for a clearer commit message that explains _why_ you are doing this, not only _what_ you are doing.

You're absolutely right, this was only added because I add some random crash and this function was in the stacktrace.
This deals with the consequence but not the cause.

kfunk requested changes to this revision.Mar 22 2018, 6:17 AM
This revision now requires changes to proceed.Mar 22 2018, 6:17 AM