Differential D10739

Remove deprecated cmake code
ClosedPublic
Actions

Authored by vonreth on Feb 22 2018, 12:15 PM.

Details

Reviewers
kfunk
dfaure
vkrause
mlaurent
Commits
R246:8e51cbc03f72: Remove deprecated cmake code

Diff Detail

Repository
R246 Sonnet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vonreth created this revision.Feb 22 2018, 12:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 22 2018, 12:15 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
vonreth requested review of this revision.Feb 22 2018, 12:15 PM
apol added a subscriber: apol.Feb 22 2018, 12:20 PM
apol added inline comments.
data/CMakeLists.txt
20

Then this also needs to go? Or just set it if the variable is defined?

vonreth added inline comments.Feb 22 2018, 12:22 PM
data/CMakeLists.txt
20

That's how I understood the code, to allow to define a prebuild exe

kfunk accepted this revision.Mar 25 2018, 8:24 PM
This revision is now accepted and ready to land.Mar 25 2018, 8:24 PM
Closed by commit R246:8e51cbc03f72: Remove deprecated cmake code (authored by vonreth). · Explain WhyMar 25 2018, 8:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdata/CMakeLists.txt (6 lines)

Diff 30563

View Options

data/CMakeLists.txt

Loading...