- User Since
- Oct 13 2017, 7:22 AM (66 w, 4 d)
Wed, Jan 9
Tue, Jan 8
It is a followup and extension of https://phabricator.kde.org/D17682
- Don't reset the moved display position
Mon, Jan 7
I understand that, of course. I think the question is: is this an improvement or not? I think it is (not perfect, has problems, but an improvement), but if considered to be not, I will just abandon it, no hard feelings.
Ping? I'll push this if there are no strong objections.
Mon, Dec 24
Dec 19 2018
Abandoned in favor of https://phabricator.kde.org/D17686
Will fix first in 5.12 and merge to master, as per https://phabricator.kde.org/D17685
I have on for master and one for Plasma 5.12, as we want this in 5.12 as well, if approved. Should I keep only one of them?
Undo last change
- Show unconnected displayed at the left
Dec 18 2018
Dec 17 2018
Remove now for real
Remove code that was added by mistake to the review
Use title case
I perfectly agree with Frederik. There is room for improvement, but my intention was not to completely change it, just to make it slightly more clear what this is about. The rest can be fixed in a separate commit, if anyone is interested to do it. :)
Change the individual texts
Dec 16 2018
Yes, most questions can be answered with Yes/No, and still I'd say it is better to use Yes/No, instead of OK/Cancel. OK/Cancel is rather useless, although widely used, I know...
I made the question text bold now, and unfortunately as I said I don't want to spend more on this. The whole dialog is problematic as it poses both a question (activate/do not activate) and a side question (turn off gestures or not).
This is confusing by default, and for the users it was unclear what the dialog buttons do, as the original question was at the beginning and between the question and the action buttons there was the large explanation with the secondary action.
At least (IMO) now it is clear that the Yes/No buttons refer to the activate/deactivate question.
Make the question text bold
Dec 15 2018
All I can say that I use it since I've created the patch and Akregator never crashed when closing a tab. :)
I'm not a native speaker, but I don't see how OK/Cancel is better. The dialog shows a question that can be answered with Yes or No.
See also the HIG https://hig.kde.org/components/assistance/message.html
Dec 14 2018
Simplify and fix (hopefully) one of the random crash on exit in Kontact.
Improve dialog title as well
You can't change to Yes/No (that was my first try), as the question might be one of the following:
- "Activate foo ?"
- "Deactivate foo?"
- "Activate foo and deactivate bar?"
How it looked before:
How it looks now:
Remove unneeded destructor
Dec 13 2018
Removed member var
Backport to 5.12 branch
Dec 12 2018
Reworked, by reshuffling the dialog text, instead of renaming the buttons
Will have to rework, I missed some cases(the dialog might as to activate. deactivate or "activate some, deactivate others"), it is not as simple as I thought.
Accessibility bugfixes cherry picked from master
Dec 11 2018
Messed up a little and this got landed together with another patch https://cgit.kde.org/plasma-desktop.git/commit/?id=40b9e34ced6b421c8585f304d91a2da37f40c4d6