amantia (Andras Mantia)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 13 2017, 7:22 AM (66 w, 4 d)
Availability
Available

Recent Activity

Wed, Jan 9

amantia committed R104:1e9b93d4c23c: Merge branch 'Plasma/5.14' (authored by amantia).
Merge branch 'Plasma/5.14'
Wed, Jan 9, 1:27 PM
amantia committed R104:20178a39dbc1: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by amantia).
Merge branch 'Plasma/5.12' into Plasma/5.14
Wed, Jan 9, 1:25 PM
amantia committed R104:3e90b446c121: Don't lose the widget layout after Default is pressed (authored by amantia).
Don't lose the widget layout after Default is pressed
Wed, Jan 9, 1:25 PM
amantia closed D18121: Don't lose the widget layout after Default is pressed.
Wed, Jan 9, 1:25 PM · Plasma
amantia added reviewers for D18121: Don't lose the widget layout after Default is pressed: dvratil, Plasma.
Wed, Jan 9, 1:21 PM · Plasma
amantia requested review of D18121: Don't lose the widget layout after Default is pressed.
Wed, Jan 9, 1:20 PM · Plasma

Tue, Jan 8

amantia added a comment to D18093: Calculate screen scaling dynamically, so it always fits to the page.

It is a followup and extension of https://phabricator.kde.org/D17682

Tue, Jan 8, 7:22 PM · Plasma
Restricted Application added a project to D18101: Don't reset the moved display position: Plasma.
Tue, Jan 8, 3:57 PM · Plasma
amantia requested review of D18101: Don't reset the moved display position.
Tue, Jan 8, 3:57 PM · Plasma
amantia abandoned D18100: Calculate screen scaling dynamically, so it always fits to the page.
Tue, Jan 8, 3:55 PM · Plasma
amantia updated the diff for D18093: Calculate screen scaling dynamically, so it always fits to the page.

Restore

Tue, Jan 8, 3:54 PM · Plasma
amantia requested review of D18100: Calculate screen scaling dynamically, so it always fits to the page.
Tue, Jan 8, 3:53 PM · Plasma
amantia updated the diff for D18093: Calculate screen scaling dynamically, so it always fits to the page.
  • Don't reset the moved display position
Tue, Jan 8, 3:52 PM · Plasma
amantia committed R104:44309f105ee4: SVN_SILENT Small formatting fix (authored by amantia).
SVN_SILENT Small formatting fix
Tue, Jan 8, 2:56 PM
Restricted Application added a project to D18093: Calculate screen scaling dynamically, so it always fits to the page: Plasma.
Tue, Jan 8, 11:09 AM · Plasma
amantia requested review of D18093: Calculate screen scaling dynamically, so it always fits to the page.
Tue, Jan 8, 11:08 AM · Plasma
amantia abandoned D18092: Backport "Show unconnected displays at the right side of the main screen".
Tue, Jan 8, 11:07 AM · Plasma
amantia requested review of D18092: Backport "Show unconnected displays at the right side of the main screen".
Tue, Jan 8, 11:06 AM · Plasma
amantia added reviewers for D18091: Backport "Show unconnected displays at the right side of the main screen"https://phabricator.kde.org/D17682: Plasma, dvratil.
Tue, Jan 8, 11:06 AM · Plasma
amantia requested review of D18091: Backport "Show unconnected displays at the right side of the main screen"https://phabricator.kde.org/D17682.
Tue, Jan 8, 11:04 AM · Plasma

Mon, Jan 7

amantia added a comment to D17533: Make the button's purpose more clear.

I understand that, of course. I think the question is: is this an improvement or not? I think it is (not perfect, has problems, but an improvement), but if considered to be not, I will just abandon it, no hard feelings.

Mon, Jan 7, 10:55 AM · Plasma
amantia added a comment to D17533: Make the button's purpose more clear.

Ping? I'll push this if there are no strong objections.

Mon, Jan 7, 10:31 AM · Plasma
amantia committed R104:25083d97c8a6: Show unconnected displays at the right side of the main screen (authored by amantia).
Show unconnected displays at the right side of the main screen
Mon, Jan 7, 10:30 AM
amantia closed D17682: Show unconnected displays at the right side of the main screen.
Mon, Jan 7, 10:30 AM · Plasma

Mon, Dec 24

amantia updated the summary of D17682: Show unconnected displays at the right side of the main screen.
Mon, Dec 24, 12:10 PM · Plasma
amantia updated the summary of D17682: Show unconnected displays at the right side of the main screen.
Mon, Dec 24, 12:09 PM · Plasma
amantia updated the summary of D17682: Show unconnected displays at the right side of the main screen.
Mon, Dec 24, 12:07 PM · Plasma

Dec 19 2018

amantia abandoned D17658: Redraw the slider if modes have changed.

Abandoned in favor of https://phabricator.kde.org/D17686

Dec 19 2018, 5:46 PM · Plasma
amantia committed R104:e8016dda917f: Merge remote-tracking branch 'origin/Plasma/5.14' (authored by amantia).
Merge remote-tracking branch 'origin/Plasma/5.14'
Dec 19 2018, 5:46 PM
amantia committed R104:a3fee70ec2fa: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by amantia).
Merge branch 'Plasma/5.12' into Plasma/5.14
Dec 19 2018, 5:29 PM
amantia committed R104:32e95fad0d51: Redraw the slider if modes have changed (authored by amantia).
Redraw the slider if modes have changed
Dec 19 2018, 5:26 PM
amantia closed D17686: Redraw the slider if modes have changed.
Dec 19 2018, 5:26 PM · Plasma
amantia committed R110:f28546cfa695: Merge branch 'Plasma/5.14' (authored by amantia).
Merge branch 'Plasma/5.14'
Dec 19 2018, 5:23 PM
amantia committed R110:95c021e3fd74: Notify also if modes have changed (authored by amantia).
Notify also if modes have changed
Dec 19 2018, 5:23 PM
amantia committed R110:50b8b56701ff: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by amantia).
Merge branch 'Plasma/5.12' into Plasma/5.14
Dec 19 2018, 5:22 PM
amantia committed R110:5422a4a8b120: Notify also if modes have changed (authored by amantia).
Notify also if modes have changed
Dec 19 2018, 5:22 PM
amantia closed D17685: Notify also if modes have changed.
Dec 19 2018, 5:03 PM · Plasma
amantia abandoned D17657: Notify also if modes have changed.

Will fix first in 5.12 and merge to master, as per https://phabricator.kde.org/D17685

Dec 19 2018, 4:58 PM · Plasma
amantia added a comment to D17685: Notify also if modes have changed.

I have on for master and one for Plasma 5.12, as we want this in 5.12 as well, if approved. Should I keep only one of them?

Dec 19 2018, 1:50 PM · Plasma
amantia added reviewers for D17686: Redraw the slider if modes have changed: Plasma, dvratil.
Dec 19 2018, 1:31 PM · Plasma
amantia requested review of D17686: Redraw the slider if modes have changed.
Dec 19 2018, 1:31 PM · Plasma
amantia added a dependent revision for D17685: Notify also if modes have changed: D17686: Redraw the slider if modes have changed.
Dec 19 2018, 1:31 PM · Plasma
amantia added a dependent revision for D17657: Notify also if modes have changed: D17685: Notify also if modes have changed.
Dec 19 2018, 1:28 PM · Plasma
amantia added a dependency for D17685: Notify also if modes have changed: D17657: Notify also if modes have changed.
Dec 19 2018, 1:28 PM · Plasma
amantia requested review of D17685: Notify also if modes have changed.
Dec 19 2018, 1:27 PM · Plasma
Restricted Application added a project to D17682: Show unconnected displays at the right side of the main screen: Plasma.
Dec 19 2018, 9:51 AM · Plasma
amantia requested review of D17682: Show unconnected displays at the right side of the main screen.
Dec 19 2018, 9:50 AM · Plasma
amantia updated the diff for D17658: Redraw the slider if modes have changed.

Undo last change

Dec 19 2018, 9:49 AM · Plasma
amantia updated the diff for D17658: Redraw the slider if modes have changed.
  • Show unconnected displayed at the left
Dec 19 2018, 9:48 AM · Plasma

Dec 18 2018

amantia updated the diff for D17657: Notify also if modes have changed.

Simplify

Dec 18 2018, 6:55 PM · Plasma
amantia added inline comments to D17658: Redraw the slider if modes have changed.
Dec 18 2018, 6:51 PM · Plasma
amantia added inline comments to D17657: Notify also if modes have changed.
Dec 18 2018, 6:50 PM · Plasma
amantia added a reviewer for D17658: Redraw the slider if modes have changed: dvratil.
Dec 18 2018, 3:59 PM · Plasma
amantia added a reviewer for D17657: Notify also if modes have changed: dvratil.
Dec 18 2018, 3:59 PM · Plasma
amantia requested review of D17658: Redraw the slider if modes have changed.
Dec 18 2018, 3:58 PM · Plasma
amantia added a dependent revision for D17657: Notify also if modes have changed: D17658: Redraw the slider if modes have changed.
Dec 18 2018, 3:58 PM · Plasma
amantia requested review of D17657: Notify also if modes have changed.
Dec 18 2018, 3:56 PM · Plasma

Dec 17 2018

amantia closed D17638: Enable LocaStorage in webengine.
Dec 17 2018, 2:23 PM · KDE PIM
amantia committed R201:365d45a7dc1a: Enable LocaStorage in webengine (authored by amantia).
Enable LocaStorage in webengine
Dec 17 2018, 2:23 PM
amantia updated the diff for D17638: Enable LocaStorage in webengine.

Remove now for real

Dec 17 2018, 11:10 AM · KDE PIM
amantia updated the diff for D17638: Enable LocaStorage in webengine.

Remove code that was added by mistake to the review

Dec 17 2018, 11:09 AM · KDE PIM
amantia updated the diff for D17533: Make the button's purpose more clear.

Use title case

Dec 17 2018, 10:47 AM · Plasma
amantia added a comment to D17533: Make the button's purpose more clear.

I perfectly agree with Frederik. There is room for improvement, but my intention was not to completely change it, just to make it slightly more clear what this is about. The rest can be fixed in a separate commit, if anyone is interested to do it. :)

Dec 17 2018, 10:20 AM · Plasma
amantia updated the diff for D17533: Make the button's purpose more clear.

Change the individual texts

Dec 17 2018, 10:18 AM · Plasma
amantia added reviewers for D17638: Enable LocaStorage in webengine: KDE PIM, mlaurent.
Dec 17 2018, 9:36 AM · KDE PIM
amantia requested review of D17638: Enable LocaStorage in webengine.
Dec 17 2018, 9:35 AM · KDE PIM

Dec 16 2018

amantia reclaimed D17533: Make the button's purpose more clear.
Dec 16 2018, 9:38 PM · Plasma
amantia abandoned D17533: Make the button's purpose more clear.
Dec 16 2018, 9:35 PM · Plasma
amantia added a comment to D17533: Make the button's purpose more clear.

Yes, most questions can be answered with Yes/No, and still I'd say it is better to use Yes/No, instead of OK/Cancel. OK/Cancel is rather useless, although widely used, I know...
I made the question text bold now, and unfortunately as I said I don't want to spend more on this. The whole dialog is problematic as it poses both a question (activate/do not activate) and a side question (turn off gestures or not).
This is confusing by default, and for the users it was unclear what the dialog buttons do, as the original question was at the beginning and between the question and the action buttons there was the large explanation with the secondary action.
At least (IMO) now it is clear that the Yes/No buttons refer to the activate/deactivate question.

Dec 16 2018, 11:59 AM · Plasma
amantia updated the diff for D17533: Make the button's purpose more clear.

Make the question text bold

Dec 16 2018, 11:56 AM · Plasma

Dec 15 2018

amantia committed R201:af43acadd45b: Don't crash with Qt 5.11+ (authored by amantia).
Don't crash with Qt 5.11+
Dec 15 2018, 12:02 PM
amantia committed R201:91a4ab57a829: Don't crash with Qt 5.11+ (authored by amantia).
Don't crash with Qt 5.11+
Dec 15 2018, 11:59 AM
amantia closed D17563: Don't crash with Qt 5.11+.
Dec 15 2018, 11:59 AM · KDE PIM
amantia added a comment to D17563: Don't crash with Qt 5.11+.

All I can say that I use it since I've created the patch and Akregator never crashed when closing a tab. :)

Dec 15 2018, 8:55 AM · KDE PIM
amantia added a comment to D17533: Make the button's purpose more clear.

I'm not a native speaker, but I don't see how OK/Cancel is better. The dialog shows a question that can be answered with Yes or No.
See also the HIG https://hig.kde.org/components/assistance/message.html

Dec 15 2018, 7:21 AM · Plasma

Dec 14 2018

amantia updated the diff for D17563: Don't crash with Qt 5.11+.

Simplify and fix (hopefully) one of the random crash on exit in Kontact.

Dec 14 2018, 9:44 PM · KDE PIM
amantia updated the diff for D17533: Make the button's purpose more clear.

Improve dialog title as well

Dec 14 2018, 8:03 PM · Plasma
amantia added a comment to D17533: Make the button's purpose more clear.

You can't change to Yes/No (that was my first try), as the question might be one of the following:

  • "Activate foo ?"
  • "Deactivate foo?"
  • "Activate foo and deactivate bar?"
Dec 14 2018, 2:21 PM · Plasma
amantia added a comment to D17533: Make the button's purpose more clear.

How it looked before:


How it looks now:

Dec 14 2018, 12:52 PM · Plasma
amantia added inline comments to D17563: Don't crash with Qt 5.11+.
Dec 14 2018, 8:09 AM · KDE PIM
amantia updated the diff for D17563: Don't crash with Qt 5.11+.

Remove unneeded destructor

Dec 14 2018, 8:08 AM · KDE PIM

Dec 13 2018

amantia updated the diff for D17563: Don't crash with Qt 5.11+.

Add override

Dec 13 2018, 6:32 PM · KDE PIM
amantia updated the diff for D17563: Don't crash with Qt 5.11+.

Removed member var

Dec 13 2018, 6:31 PM · KDE PIM
amantia added inline comments to D17563: Don't crash with Qt 5.11+.
Dec 13 2018, 6:28 PM · KDE PIM
amantia added reviewers for D17563: Don't crash with Qt 5.11+: KDE PIM (Applications 18.12 (master)), mlaurent.
Dec 13 2018, 3:35 PM · KDE PIM
amantia requested review of D17563: Don't crash with Qt 5.11+.
Dec 13 2018, 3:33 PM · KDE PIM
amantia committed R119:36e724f1f458: Make accessibility warning dialog usable again and fix event handling (authored by amantia).
Make accessibility warning dialog usable again and fix event handling
Dec 13 2018, 11:37 AM
amantia closed D17536: Make accessibility warning dialog usable again and fix event handling.
Dec 13 2018, 11:37 AM · Plasma
amantia committed R119:611fc3079b24: Make accessibility warning dialog usable again (authored by amantia).
Make accessibility warning dialog usable again
Dec 13 2018, 11:25 AM
amantia closed D17557: Make accessibility warning dialog usable again.
Dec 13 2018, 11:25 AM · Plasma
amantia added a comment to D17557: Make accessibility warning dialog usable again.

Backport to 5.12 branch

Dec 13 2018, 10:51 AM · Plasma
amantia requested review of D17557: Make accessibility warning dialog usable again.
Dec 13 2018, 10:51 AM · Plasma

Dec 12 2018

amantia updated the diff for D17533: Make the button's purpose more clear.

Reworked, by reshuffling the dialog text, instead of renaming the buttons

Dec 12 2018, 1:06 PM · Plasma
amantia planned changes to D17533: Make the button's purpose more clear.

Will have to rework, I missed some cases(the dialog might as to activate. deactivate or "activate some, deactivate others"), it is not as simple as I thought.

Dec 12 2018, 12:54 PM · Plasma
amantia added a comment to D17536: Make accessibility warning dialog usable again and fix event handling.

Accessibility bugfixes cherry picked from master

Dec 12 2018, 11:42 AM · Plasma
amantia requested review of D17536: Make accessibility warning dialog usable again and fix event handling.
Dec 12 2018, 11:42 AM · Plasma
amantia added reviewers for D17533: Make the button's purpose more clear: Plasma Accessibility, davidedmundson, aacid.
Dec 12 2018, 11:16 AM · Plasma
amantia requested review of D17533: Make the button's purpose more clear.
Dec 12 2018, 11:15 AM · Plasma

Dec 11 2018

amantia closed D17415: Fix event type checking.

Messed up a little and this got landed together with another patch https://cgit.kde.org/plasma-desktop.git/commit/?id=40b9e34ced6b421c8585f304d91a2da37f40c4d6

Dec 11 2018, 6:17 PM · Plasma
amantia committed R119:40b9e34ced6b: Make accessibility warning dialog usable again (authored by amantia).
Make accessibility warning dialog usable again
Dec 11 2018, 6:15 PM