It crashes, you can see backtrace, start long-running analysis and close Kate before it finish.

I prefer to not having config on this. We can limit them to 4. I test with big projects using boost and Qt, ~2000 files, RAM is not an issue (~25 MB on process) but performance. By one job project is really not ending, takes more than hour, by increasing jobs things became more reliable.

Any objections on this?

There's no problem at all
http://doc.qt.io/qt-5/qprocess.html#dtor.QProcess

I'll commit it as soon you accept.

Use qAsConst

Isn't there. https://phabricator.kde.org/source/powerdevil/browse/master/daemon/backends/upower/xrandrbrightness.cpp$160 You can investigate on what backend it's used for you and it may set value only one output not to all.

To 18.12 ?

Ok, let not make whitespace commit. @ognarb just be more precise next time.

Ping

Kernel regression for sure.

@thsurrel try this patch, if it not help disable dim display from power saving configuration, is that help?

Ping

Ping

That's change in 1.14 i think, so right after state goes to ready on stream gstreamer triggers signal sync-message::buffering with percentage 0 that's cb_buffering on other hand we change immediately state to paused in, so gstreamer starts buffering again and when goes to 100% we end up with playing state.

I will push it in few days, since no activity.

+1

I have noticed it too, please to 18.12.

Ping

Ping

Yep, it's Qt bug.

It looks like the problem is in dimming.

So i like second one, it can still be fixed to 10K+ because it does not matter above.

In D17152#365975, @ndavis wrote:

Why not abbreviate the number? Instead of using "9,999+" for 11000, use "11K".

To commit it @mart @broulik ?

It's mostly one per day or accept configuration.

+1

@davidedmundson, i have more little fixes over applet did you see something suspicious here, i plan to commit them before 5.14.4 release.

You can't change parameters in methods or constructors, it's a BIC.

Whole point is to not change tooltip height, album art can be larger that entire screen or smaller than 16x16, so the solution is to scale image to current aspect ratio. Otherwise it can lead to inconsistency.

So i made simple script to test, it looks like the problem isn't that

xset dpms force off
sleep 1
cat /sys/class/backlight/intel_backlight/max_brightness
cat /sys/class/backlight/intel_backlight/brightness
cat /sys/class/backlight/intel_backlight/actual_brightness

Results:

187
22
0

But for some reason, on second Entries show warnings says: cannot call createObject on null object. Looks like it is treated as local object or something.

Done. BTW I had tried to change the order of the menu entries, without success (?)

You should increase version to 84 https://phabricator.kde.org/source/kate/browse/master/kate/data/kateui.rc$3 Also you can generate diffs like git diff -U9999 > file for context to present.

Better not change data engine

Weird. If configuration window stays open, clicks in systray work correct, when it's dismissed clicks are incorrect.

Fix diff

In D16721#356863, @bcooksley wrote:

Force pushes are generally reserved for pretty serious issues, couldn't the whitespace be corrected with a follow up commit to remove it?

But it's not only that https://phabricator.kde.org/R8:a7ee6f871af225fd5edc9458ee183604fabadc8a
Notice ~SectionLayout() and many others, you should use settings that trim whitespaces on file save. In Kate -> settings -> open/save -> Remove trailing spaces -> In entire document.

Please contact @bcooksley to remote all white space changes from you commit. Please be more precise when you commit, you introduce even more white spaces rather than to remove them.

Please, remove all white space changes before commit. It will be better if you test the patch some time without crash or other downsides. If you notice something wrong write here. If all is good you can commit in few days. Thank you for patch, other patches are welcome.

Can you add screenshots of horizontal and vertical version, add it to test, just to have how it looks. I see some gestures that i cannot test, did you can, touchscreen, tablet or something that this code works :)

Can you test my suggestions, it's looks good to me.

Config, if it's not set explicitly, <appname> + "rc" https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607

Return QObjects, if you have problems copy linker output here.

I'm adding Krita as reviewer, because Karbon is unmaintained and I hope someone at Krita as some experience with the toolbox

Shift + Pg Up/Down works for me and why it will set up esc key?