[Folder View] make file context menu consistent with Dolphin's
AcceptedPublic

Authored by ngraham on Thu, Dec 6, 9:16 PM.

Details

Reviewers
hein
ndavis
Group Reviewers
Plasma
VDG
Summary

BUG: 401652
FIXED-IN: 5.15.0

Test Plan

Before:

After:

It matches Dolphin:

Diff Detail

Repository
R119 Plasma Desktop
Branch
context-menu-consistency-with-dolphin (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5769
Build 5787: arc lint + arc unit
ngraham created this revision.Thu, Dec 6, 9:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Dec 6, 9:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Thu, Dec 6, 9:16 PM
ngraham edited the test plan for this revision. (Show Details)Thu, Dec 6, 9:17 PM
ngraham edited the test plan for this revision. (Show Details)Thu, Dec 6, 9:25 PM
ngraham added a reviewer: hein.
ngraham updated this revision to Diff 47003.Thu, Dec 6, 11:37 PM

Also give the Properties action a shortcut, so now the menu is 100% identical with Dolphin's

ngraham edited the test plan for this revision. (Show Details)Thu, Dec 6, 11:38 PM
janpr added a subscriber: janpr.Fri, Dec 7, 10:36 PM
hein added a comment.Sat, Dec 8, 11:54 AM

Can we patch Dolphin instead? I think the order there is pretty bad, with weird random dividers etc. (From the screenshots in the original user bug.) I prefer FV's.

Hmm, I prefer the Dolphin one for the following reasons:

  1. Having the the "open with" item near the top makes sense because it's likely the most commonly used item
  2. Having the "open" items grouped together makes sense, since they're both similar actions, and all other platforms I'm familiar with have their context menu's "open" items on the top too
  3. The greater use of separators is an asset, not a drawback: separators provide structure and help the mind distinguish between logical groups. In particular having cut/copy/paste separated from other items makes sense.
  4. The current FV menu has bugs:
    1. The top item is Open, but it uses an inappropriate icon and is duplicated by another superior Open with [app name] item buried in the middle of the context menu.
    2. It doesn't show the Paste item unless there's something to paste. This is a HIG violation; we don't recommend modifying the visibility of inapplicable menu items; instead they should be disabled.
    3. The Properties item doesn't have a keyboard shortcut

But if you're not convinced, perhaps we could ask VDG which of the following they prefer:

Current Folder View menu:

Current Dolphin menu:

janpr added a comment.Sat, Dec 8, 4:03 PM

I agree that Dolphin's menu makes more sense. If this turns out to be controversial, maybe the order should be easier to change, instead of having it hard coded...

mart added a subscriber: mart.Fri, Dec 14, 4:10 PM

important is that "open with $default" and "open with..." are grouped together.
apart from that i don't have much preferences for one or the other

ngraham added a reviewer: VDG.Fri, Dec 14, 4:16 PM
ngraham edited the test plan for this revision. (Show Details)
ndavis added a subscriber: ndavis.EditedFri, Dec 14, 5:02 PM

+1 to making the menus the same.

In D17393#373155, @hein wrote:

Can we patch Dolphin instead? I think the order there is pretty bad, with weird random dividers etc. (From the screenshots in the original user bug.) I prefer FV's.

To me, the folder view menu is the one with seemingly random dividers, and a lack of dividers. In the dolphin menu, I see a clear progression:

  1. Open section
  2. Clipboard section
  3. options that can affect other programs (missing files due to removal or name change)
    • It can be argued that Cut would belong here and I don't think it would be bad if clipboard actions, rename and delete were in the same section.
    • Another name for this section could be "File Operations" if the "Copy To" and "Move To" Commands were put here.
  4. Misc actions
    • Better organization might be a good idea, but that's out of scope here
  5. Properties
    • this option is always kind of special
ndavis accepted this revision.Fri, Dec 14, 8:04 PM
This revision is now accepted and ready to land.Fri, Dec 14, 8:04 PM

Since this is VDG-accepted and most of the comments seem to be slightly to strongly positive so far, if I don't get a formal Changes Requested status from someone in Plasma, I'll land on December 19th (or earlier if I get a formal Accept status instead).

hein accepted this revision.Sat, Dec 15, 4:16 AM

Alrighty, I'll go in with the majority opinion then. Consistency is certainly an improvement by itself. Go go go!