Differential D16971

Depend on KDE Frameworks 5.41
ClosedPublic
Actions

Authored by heikobecker on Nov 18 2018, 10:33 AM.

Details

Reviewers
marten
Commits
R345:b2f9810f38c6: Depend on KDE Frameworks 5.41
Summary

Allows us to drop the copied FindGLIB2 cmake module. 5.41.0 was
released in December 2017 and thus will be over a year old when
kmix 19.04 is planned to be released.
Also remove the distinction between minimal ECM and KF5 versions,
they are relesed with the same version since quite some time.

Diff Detail

Repository
R345 KMix
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker requested review of this revision.Nov 18 2018, 10:33 AM
heikobecker created this revision.
marten accepted this revision.Nov 18 2018, 12:48 PM

The same applies to the included FindPulseAudio module. Will you submit a separate review for that (if you are able to test with PA)?

This revision is now accepted and ready to land.Nov 18 2018, 12:48 PM
heikobecker updated this revision to Diff 45906.Nov 20 2018, 6:14 PM

Removed FindPulseAudio.cmake as well

heikobecker added a comment.Nov 20 2018, 6:16 PM
In D16971#361440, @marten wrote:

The same applies to the included FindPulseAudio module. Will you submit a separate review for that (if you are able to test with PA)?

Done. Tested with PA at build time.

anthonyfieroni added a subscriber: anthonyfieroni.Nov 20 2018, 6:28 PM
anthonyfieroni added inline comments.
CMakeLists.txt
9–10

Min version should be increased as well to 5.6 or higher. So that maybe should be done in frameworks internally, because now it's not noticeable.

heikobecker updated this revision to Diff 45911.Nov 20 2018, 6:56 PM

Additionally raised the Qt requirement

heikobecker marked an inline comment as done.Nov 20 2018, 6:57 PM
heikobecker added inline comments.
CMakeLists.txt
9–10

The requirement of 5.41.0 was 5.7.0 so I used that.

marten added a comment.Nov 20 2018, 7:18 PM

Elimination of FindPulseAudio and updated version checks fine by me.

Closed by commit R345:b2f9810f38c6: Depend on KDE Frameworks 5.41 (authored by heikobecker). · Explain WhyNov 20 2018, 7:31 PM
This revision was automatically updated to reflect the committed changes.
heikobecker marked an inline comment as done.

Revision Contents
Changeset List

Diff 45913

View Options

CMakeLists.txt

Loading...
View Options

cmake/modules/FindGLIB2.cmake

Loading...
View Options

cmake/modules/FindPulseAudio.cmake

Loading...