Differential D17504

[kateproject tool] Fine tune cppcheck
ClosedPublic
Actions

Authored by anthonyfieroni on Dec 11 2018, 1:40 PM.

Details

Reviewers
cullmann
dhaumann
Commits
R40:68e44b97d148: [kateproject tool] Fine tune cppcheck
R40:18be8b5886d1: [kateproject tool] Fine tune cppcheck
Summary
  1. Force resolve all headers
  2. Use jobs for faster complete

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anthonyfieroni created this revision.Dec 11 2018, 1:40 PM
Restricted Application added a project: Kate. · View Herald TranscriptDec 11 2018, 1:40 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
anthonyfieroni requested review of this revision.Dec 11 2018, 1:40 PM
anthonyfieroni retitled this revision from [project tool] Fine tune cppcheck to [kateproject tool] Fine tune cppcheck.Dec 11 2018, 1:43 PM
anthonyfieroni added a comment.Dec 11 2018, 6:05 PM

Any objections on this?

cullmann requested changes to this revision.Dec 11 2018, 6:25 PM

I am not sure if that is such a good idea.
cppcheck can use a lot of memory, many people with 8 (virtual) cores might not have it ;=)
For parallel levels, I think we should have somewhere an option.

This revision now requires changes to proceed.Dec 11 2018, 6:25 PM
anthonyfieroni added a comment.Dec 11 2018, 6:55 PM

I prefer to not having config on this. We can limit them to 4. I test with big projects using boost and Qt, ~2000 files, RAM is not an issue (~25 MB on process) but performance. By one job project is really not ending, takes more than hour, by increasing jobs things became more reliable.

cullmann accepted this revision.Dec 11 2018, 7:39 PM

Hmm, if it really takes that bit of memory, just commit as is, thanks.

This revision is now accepted and ready to land.Dec 11 2018, 7:39 PM
dhaumann accepted this revision.Dec 12 2018, 12:05 AM

Ok with me as well.

Closed by commit R40:68e44b97d148: [kateproject tool] Fine tune cppcheck (authored by anthonyfieroni). · Explain WhyDec 12 2018, 6:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47415

View Options

addons/project/tools/kateprojectcodeanalysistoolcppcheck.cpp

Loading...