Fixed comic widget crash
ClosedPublic

Authored by pavelmos on Thu, Nov 22, 9:23 AM.

Details

Summary

Crash happens on trying to load an unsupported format content such as video.
To prevent a crash, the patch blocks the loading of unsupported content (such as video) instead of a picture when switching comic strip.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pavelmos created this revision.Thu, Nov 22, 9:23 AM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Nov 22, 9:23 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
pavelmos requested review of this revision.Thu, Nov 22, 9:23 AM
anthonyfieroni added a subscriber: anthonyfieroni.
anthonyfieroni added inline comments.
applets/comic/comic.cpp
196

Just move this after brace.

pavelmos updated this revision to Diff 45996.Thu, Nov 22, 10:06 AM
pavelmos marked an inline comment as done.
pavelmos added inline comments.
applets/comic/comic.cpp
196

Yes, I agree. Your remark is true

mart accepted this revision.Fri, Nov 23, 11:11 AM
This revision is now accepted and ready to land.Fri, Nov 23, 11:11 AM

I have no commit access.

This revision was automatically updated to reflect the committed changes.

@anthonyfieroni these last few patches of Pavel's were landed with your authorship information, not his. In the future let's follow https://community.kde.org/Infrastructure/Phabricator#Landing_someone_else.27s_diff

Thanks!