Fixed comic widget context menu crash
ClosedPublic

Authored by pavelmos on Thu, Nov 22, 9:22 AM.

Details

Summary

Crash happens on trying to use the context menu of widget with no active comics.
The patch disables some items in this context menu to prevent crashes.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pavelmos created this revision.Thu, Nov 22, 9:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Nov 22, 9:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
pavelmos requested review of this revision.Thu, Nov 22, 9:22 AM
anthonyfieroni added inline comments.
applets/comic/comic.cpp
527

Check against nullptr like else branch?

pavelmos updated this revision to Diff 46064.Fri, Nov 23, 8:50 AM
pavelmos marked an inline comment as done.Fri, Nov 23, 9:05 AM
mart accepted this revision.Fri, Nov 23, 11:12 AM
This revision is now accepted and ready to land.Fri, Nov 23, 11:12 AM

I have no commit access.

ngraham added a subscriber: ngraham.

@anthonyfieroni, if this looks good to you now, would you mind landing it for Pavel? Thanks!

His authorship information is Pavel Mars <mars@basealt.ru>

This revision was automatically updated to reflect the committed changes.