Feed Advanced Search

Thu, Sep 24

romangg abandoned D24826: Enforce 100 chars line width.
Thu, Sep 24, 9:16 PM · Build System, Frameworks
romangg added a comment to D24826: Enforce 100 chars line width.

FYI I'm using a strict 100 chars limit nowadays on all my KWinFT projects (with the exception of KWinFT itself for now) and I'm very happy with this decision.

Thu, Sep 24, 9:16 PM · Build System, Frameworks

May 27 2020

romangg added a comment to T11601: Primary Clipboard (middle click) Support.

I see that @gladhorn has not commited since last september. Is anyone still working on this feature? @romangg , any insights on that subject?

May 27 2020, 9:03 AM · Plasma on Wayland

May 14 2020

romangg committed R104:07a261d0139d: docs: remove maintainer information (authored by romangg).
docs: remove maintainer information
May 14 2020, 11:18 PM
romangg abandoned D29024: feat(wayland): support multiple protocol extensions through plugin system.
May 14 2020, 11:16 PM · Plasma
romangg added a comment to D29024: feat(wayland): support multiple protocol extensions through plugin system.

If I may add my two cents here,

Hi Daniel, sorry for the late reply. But I was busy as I had to kick things off now with the libkscreen fork.

May 14 2020, 11:15 PM · Plasma

May 12 2020

romangg added a comment to D29024: feat(wayland): support multiple protocol extensions through plugin system.

Oh I nearly forgot: great work that you ignore everything else I wrote and only reply to the most unimportant statement in all of that. That's a great rhetorical trick. Every good politician must know about this one for distraction.

May 12 2020, 10:07 PM · Plasma
romangg added a comment to D29024: feat(wayland): support multiple protocol extensions through plugin system.

Show me where the documentation for this QtWaylandClientExtension is and where you documented that we "agreed" on using that in Plasma exclusively and we can talk about libkscreen using it in 5.20

It was documented here https://phabricator.kde.org/T11903 at the end and it was discussed in the meeting on # kwin that you were in.

May 12 2020, 9:59 PM · Plasma

May 11 2020

romangg added a comment to D29024: feat(wayland): support multiple protocol extensions through plugin system.

Note that I need to have this plugin system or something similar in for 5.19 or I will be forced to fork libkscreen permanently for KWinFT. I would like to avoid this and instead continue my work on libkscreen as a KDE project like I have worked on it in the last two years.

Nobody's forcing you to do anything.

May 11 2020, 8:13 PM · Plasma
romangg added a comment to D29024: feat(wayland): support multiple protocol extensions through plugin system.

These are not specific issues but some general complains about the overall concept chosen here without providing an alternative solution.

May 11 2020, 2:05 PM · Plasma
romangg added a comment to D29024: feat(wayland): support multiple protocol extensions through plugin system.

Since this has now the structure with exported headers as requested in D29028#653150 and D29028#654526 I'll push later today if there are no more specific issues pointed out in regards to the code.

May 11 2020, 11:21 AM · Plasma

May 8 2020

romangg abandoned D29028: feat(wayland): add Wrapland plugin.

Will become an external plugin with libkscreen Wayland headers being exported now.

May 8 2020, 3:50 PM · Plasma
romangg abandoned D29029: feat(wayland): add plugin for wlroots based compositors.

Will become an external plugin with libkscreen Wayland headers being exported now.

May 8 2020, 3:50 PM · Plasma
romangg added a comment to D29024: feat(wayland): support multiple protocol extensions through plugin system.

A separate library KScreenWayland is installed additionally to the runtime plugin, so that library can be linked against to create nested plugins for a Wayland session. These plugins must be installed in a certain directory (usually`/usr/lib/plugins/org.kde.libkscreen.backends/wayland/`) so they can be discovered at runtime after the Wayland plugin has been loaded. For each plugin a separate connection is established to the Wayland compositor as before and depending on reply the plugin is used or discarded.

May 8 2020, 1:45 PM · Plasma
romangg updated the diff for D29024: feat(wayland): support multiple protocol extensions through plugin system.
  • refactor: export Wayland plugins headers
May 8 2020, 1:40 PM · Plasma

May 1 2020

romangg updated the summary of D29340: fix(kcm): avoid recursive OpacityMask which leads to teardown crash.
May 1 2020, 3:37 PM · Plasma
romangg accepted D29340: fix(kcm): avoid recursive OpacityMask which leads to teardown crash.

Docs explicitly say this.

May 1 2020, 3:36 PM · Plasma

Apr 29 2020

romangg added a comment to D29272: Add support to keyboard shortcuts inhibitor.
In D29272#659619, @apol wrote:

Are we ok to let Meta key opening menu even if inhibitor is active ?

Wouldn't this do exactly what this patch is trying to prevent?

Apr 29 2020, 11:03 AM · KWin

Apr 27 2020

romangg added inline comments to D29231: Add keyboard_shortcuts_inhibit protocol.
Apr 27 2020, 5:39 PM · Frameworks
romangg placed T12351: Support all DRM hardware plane rotations up for grabs.
Apr 27 2020, 12:15 PM · Plasma on Wayland, KWin

Apr 24 2020

romangg added a comment to T4424: [kwin] Support updateXTime() on Xwayland.

I would recommend to create an overview where XTime is actually used in KWin and how other compositors deal with it. Then try to create a theoretic solution and present that.

Apr 24 2020, 2:57 PM · Plasma on Wayland
romangg added a comment to T4424: [kwin] Support updateXTime() on Xwayland.

Please confirm if that still stands.

Apr 24 2020, 2:17 PM · Plasma on Wayland

Apr 23 2020

romangg placed T4465: [kwin] Gamma correction up for grabs.
Apr 23 2020, 5:06 PM · KWin, Plasma on Wayland
romangg placed T5710: [kwin] Pageflips per output up for grabs.
Apr 23 2020, 5:06 PM · KWin
romangg placed T11886: Split KWin for Wayland and X11 at build level up for grabs.
Apr 23 2020, 5:06 PM · KWin
romangg placed T11140: Enable screen management with KScreen in Wayland nested sessions up for grabs.
Apr 23 2020, 5:05 PM · KWin
romangg placed T4426: [kwin] Scanout wl_buffer in DrmBackend up for grabs.
Apr 23 2020, 5:05 PM · KWin, Plasma on Wayland
romangg placed T9815: Improve touch/virtual keyboard up for grabs.
Apr 23 2020, 5:05 PM · KWin
romangg placed T11098: Replace Screens class up for grabs.
Apr 23 2020, 5:05 PM · KWin
romangg moved T4456: Implement viewporter protocol from Under Review to Backlog on the KWin board.
Apr 23 2020, 5:03 PM · KWin, Plasma on Wayland
romangg placed T4456: Implement viewporter protocol up for grabs.
Apr 23 2020, 5:03 PM · KWin, Plasma on Wayland
romangg closed T11475: Redesign orientation sensor as Resolved.
Apr 23 2020, 5:03 PM · KWin
romangg closed T11475: Redesign orientation sensor, a subtask of T11670: Improve Wayland output rotation, as Resolved.
Apr 23 2020, 5:03 PM · Plasma on Wayland, KWin
romangg moved T11670: Improve Wayland output rotation from Under Review to Backlog on the KWin board.
Apr 23 2020, 5:03 PM · Plasma on Wayland, KWin
romangg placed T11670: Improve Wayland output rotation up for grabs.
Apr 23 2020, 5:02 PM · Plasma on Wayland, KWin
romangg closed T11071: Rework compositing pipeline as Wontfix.
Apr 23 2020, 5:02 PM · KWin
romangg placed T11071: Rework compositing pipeline up for grabs.
Apr 23 2020, 5:01 PM · KWin

Apr 22 2020

romangg added a comment to D29028: feat(wayland): add Wrapland plugin.

A new dependency also needs to actually solve an actual problem.

If we say we should support wl_roots' protocol for wlroots users. Fair enough. There are some parts of Plasma used by 3rd parties.
I'd certainly be very happy for us both to switch to a new standard given they're upstreaming some stuff currently.

But we then have to answer the technical question of why does that require a library with a different implementation of ConnectionThread/Registry and every client protocol in order to do so? Compared to using one technology throughout. Otherwise you're not really solving the original problem of having it available to users.

Apr 22 2020, 12:40 PM · Plasma
romangg added a comment to D29028: feat(wayland): add Wrapland plugin.
In D29028#653192, @apol wrote:

I don't really see why we'd want to support something that is not offering ABI stability and doesn't push Plasma in any direction.

It is offering in the same way ABI stability as most other components of Plasma, i.e. until a new minor Plasma release.

That's not true. Always use pimpl in library code, say KWin can break backward compatibility, KWayland, KScreen, etc. does not. If you do it as it should be then it may be accepted (i cannot guaranteed but will be step in right direction, at least).

Apr 22 2020, 12:14 PM · Plasma
romangg added a comment to D29028: feat(wayland): add Wrapland plugin.

I understand David's point: Wrapland project has one developer and we don't know how successful it will be, while the other backends have developers. What would happen if you suddenly quit / disappear and the project dies? Then kscreen will have a folder of dead code.

This is a Plugin, it can live in any folder / project, you already forked KWinFT, create a new project to put this KScreen plugin, we can't scale to N projects adding code as plugins that will need to be maintained for quite a while in the future.

Come on man, do you really want to make this ugly? I thought we would still treat each other with respect David. :(

Your words. His words are technical, Please don't distort things and make it about you.

I haven't noticed much technical words in what was said. I did ask about the headers-only proposal that was of technical nature. Also the tone made it seem to me personal, but that sadly might have been just what is often the default tone in Plasma reviews (no finger pointing intended, I have been guilty of that in the past too).

Apr 22 2020, 12:09 PM · Plasma
romangg added a comment to D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen.

I like that. KCMs should be more inter-connected anyway. The message could just be shown all the time instead of making it dependent on the font size selected but no need to change that now.

Apr 22 2020, 9:31 AM · Plasma

Apr 21 2020

romangg added a comment to D29028: feat(wayland): add Wrapland plugin.
In D29028#653192, @apol wrote:

I don't really see why we'd want to support something that is not offering ABI stability and doesn't push Plasma in any direction.

Apr 21 2020, 12:05 AM · Plasma

Apr 20 2020

romangg added a comment to D29028: feat(wayland): add Wrapland plugin.

I don't see why we should have that in KDE code.

Apr 20 2020, 10:22 PM · Plasma
romangg added a comment to D29024: feat(wayland): support multiple protocol extensions through plugin system.

KScreen already is a plugin system.

You mean libkscreen? It has a plugin system for differentiating between windowing systems, yes.

Apr 20 2020, 9:44 PM · Plasma
romangg added a comment to D29029: feat(wayland): add plugin for wlroots based compositors.

Test on sway.

Apr 20 2020, 9:29 PM · Plasma
romangg added a dependency for D29029: feat(wayland): add plugin for wlroots based compositors: D29028: feat(wayland): add Wrapland plugin.
Apr 20 2020, 9:22 PM · Plasma
romangg added a dependent revision for D29028: feat(wayland): add Wrapland plugin: D29029: feat(wayland): add plugin for wlroots based compositors.
Apr 20 2020, 9:22 PM · Plasma
romangg requested review of D29029: feat(wayland): add plugin for wlroots based compositors.
Apr 20 2020, 9:21 PM · Plasma
romangg added a dependent revision for D29024: feat(wayland): support multiple protocol extensions through plugin system: D29028: feat(wayland): add Wrapland plugin.
Apr 20 2020, 9:18 PM · Plasma
romangg added a dependency for D29028: feat(wayland): add Wrapland plugin: D29024: feat(wayland): support multiple protocol extensions through plugin system.
Apr 20 2020, 9:18 PM · Plasma
romangg requested review of D29028: feat(wayland): add Wrapland plugin.
Apr 20 2020, 9:18 PM · Plasma
romangg updated the diff for D29024: feat(wayland): support multiple protocol extensions through plugin system.

Cleanup

Apr 20 2020, 9:02 PM · Plasma
romangg updated the diff for D29024: feat(wayland): support multiple protocol extensions through plugin system.

Cleanup

Apr 20 2020, 8:55 PM · Plasma
romangg added inline comments to D29024: feat(wayland): support multiple protocol extensions through plugin system.
Apr 20 2020, 8:49 PM · Plasma
romangg requested review of D29024: feat(wayland): support multiple protocol extensions through plugin system.
Apr 20 2020, 8:44 PM · Plasma

Apr 17 2020

romangg updated the summary of D28916: fix(kded): center action OSD on wayland.
Apr 17 2020, 2:03 PM · Plasma
romangg accepted D28916: fix(kded): center action OSD on wayland.

Looks good to me. Also happy @davidedmundson ?

Apr 17 2020, 2:03 PM · Plasma
romangg updated the summary of D28916: fix(kded): center action OSD on wayland.
Apr 17 2020, 2:00 PM · Plasma
romangg added inline comments to D28882: Create protocol to manage video feeds.
Apr 17 2020, 8:33 AM · Frameworks

Apr 14 2020

romangg added a comment to D28817: fix (kcm): correct output identifier position on wayland.

Yes, please put the m_timer removal in a separate patch. And (in this separate patch) if you removed the m_timer the QTimer include in the header file can be removed as well I assume. Thanks.

Apr 14 2020, 2:53 PM · Plasma
romangg accepted D28817: fix (kcm): correct output identifier position on wayland.

Thanks. Some minor remaining nitpicks you can change on push.

Apr 14 2020, 2:39 PM · Plasma
romangg accepted D28818: fix(kcm): show output ids in reference to currently applied config.

I changed up the description a bit more (line length!). Please make sure to push with arc so it fetches this description for the commit message.

Apr 14 2020, 2:32 PM · Plasma
romangg updated the summary of D28818: fix(kcm): show output ids in reference to currently applied config.
Apr 14 2020, 2:29 PM · Plasma
romangg added a comment to D28817: fix (kcm): correct output identifier position on wayland.

Conceptually makes sense. +1 form me on that. Good solution. Thanks for outlining it in the summary.

Apr 14 2020, 2:15 PM · Plasma
romangg added a comment to D28818: fix(kcm): show output ids in reference to currently applied config.

Header subject and commit message body must have shorter line length in line with message guideline. Also note regarding capitalization Angular's subject guideline.

Apr 14 2020, 1:53 PM · Plasma
romangg added a comment to D28817: fix (kcm): correct output identifier position on wayland.

Please explain your solution in the summary. I don't directly understand how this change fixes the bug. Thanks.

Apr 14 2020, 1:11 PM · Plasma
romangg requested changes to D28818: fix(kcm): show output ids in reference to currently applied config.

Message guideline must be adhered. Summary must be more extensive.

Apr 14 2020, 1:06 PM · Plasma
romangg requested changes to D28817: fix (kcm): correct output identifier position on wayland.

Message guideline must be adhered. Summary must be more extensive.

Apr 14 2020, 1:06 PM · Plasma

Apr 13 2020

romangg accepted D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate.

Add the const and push.

Apr 13 2020, 12:26 PM · Plasma

Apr 12 2020

romangg added a comment to D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate.

I'm not sure about the renaming. the lock... implies that the rotation stays the way it is at the moment (what it does). But I'm fine either way.

Apr 12 2020, 2:28 PM · Plasma
romangg added reviewers for D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate: Plasma, bshah.
Apr 12 2020, 2:19 PM · Plasma

Apr 6 2020

romangg accepted D28630: [xwl] Fix crash if same data is requested twice.

Yes, makes sense. I checked back on the protocol to see if a Wayland client can request the same offer multiple times and of course it can to receive multiple mime types.

Apr 6 2020, 5:56 PM · KWin
romangg accepted D28620: Add readmes clarifying state of plasma component versions.

If you want to you can also add a ⚠️ (:warning:) emoticon to the deprecated text and in both some headings with #, ##, etc.

Apr 6 2020, 1:57 PM · Frameworks
romangg added a comment to D28620: Add readmes clarifying state of plasma component versions.

README.md is common for viewing in modern code hosting solutions with markdown support.

Apr 6 2020, 1:07 PM · Frameworks

Apr 1 2020

romangg committed R133:c103ceb1caf0: Add support for logging categories (authored by romangg).
Add support for logging categories
Apr 1 2020, 9:33 PM
romangg closed D28389: Add support for logging categories.
Apr 1 2020, 9:33 PM · Plasma

Mar 31 2020

romangg added a comment to D27677: refactor: incorporate prior libkscreen EDID changes.

Oh, I just noticed: Please absolutely add a commit message body to this commit on push! Just a single line explaining what you do is enough.

Mar 31 2020, 2:36 PM · Plasma
romangg accepted D27675: feat: avoid duplicated text when assembling user-facing output names.

Sorry for late review. I didn't get notified by this bullshit platform (which might be because I disabled all notifications at one point to not get spammed constantly).

Mar 31 2020, 2:35 PM · Plasma
romangg accepted D10042: feat: parse EDID on the backend side.

Agreed. deviceId is not actually used (it's stored in KDED config files, but the value doesn't seem to be used anywhere). I'll fix it in a separate commit (since it also needs adjusting a bunch of unit-tests in libkscreen and kscreen).

Mar 31 2020, 2:34 PM · Plasma

Mar 30 2020

romangg closed D28386: fix(kded): watch config also when known config is applied.
Mar 30 2020, 11:56 AM · Plasma
romangg committed R104:3dced489d7c1: fix(kded): watch config also when known config is applied (authored by romangg).
fix(kded): watch config also when known config is applied
Mar 30 2020, 11:56 AM
romangg added inline comments to D28389: Add support for logging categories.
Mar 30 2020, 11:52 AM · Plasma
romangg updated the diff for D28389: Add support for logging categories.

Include the cpp files

Mar 30 2020, 11:51 AM · Plasma

Mar 28 2020

romangg added inline comments to D28389: Add support for logging categories.
Mar 28 2020, 10:42 PM · Plasma
romangg requested review of D28389: Add support for logging categories.
Mar 28 2020, 10:41 PM · Plasma
romangg committed R108:f8bafef294aa: Adapt to new KScreenLocker API (authored by romangg).
Adapt to new KScreenLocker API
Mar 28 2020, 10:00 PM
romangg closed D28085: Adapt to new KScreenLocker API.
Mar 28 2020, 10:00 PM · KWin
romangg committed R133:decf7c9d4f43: Take file descriptor only instead of whole KWayland Display (authored by romangg).
Take file descriptor only instead of whole KWayland Display
Mar 28 2020, 9:39 PM
romangg closed D28082: Take file descriptor only instead of whole KWayland Display.
Mar 28 2020, 9:38 PM · Plasma
romangg committed R133:c893e333b060: Populate Greeter process exit stderr (authored by romangg).
Populate Greeter process exit stderr
Mar 28 2020, 9:37 PM
romangg closed D28081: Populate Greeter process exit stderr.
Mar 28 2020, 9:37 PM · Plasma
romangg requested review of D28386: fix(kded): watch config also when known config is applied.
Mar 28 2020, 8:37 PM · Plasma

Mar 25 2020

romangg awarded D27883: Register spawned applications as an independent cgroups a Like token.
Mar 25 2020, 3:33 PM · Frameworks

Mar 24 2020

romangg added a comment to T11550: Add SPDX License markers.

Thank you @zzag.

Mar 24 2020, 8:32 PM · KF6

Mar 23 2020

romangg added a comment to D28085: Adapt to new KScreenLocker API.

Shall I put the connects in the constructor to move this forward?

Mar 23 2020, 1:25 PM · KWin
romangg added inline comments to D28217: Fix Formatter library CMake.
Mar 23 2020, 11:06 AM · Plasma
romangg accepted D28217: Fix Formatter library CMake.

Compiles again on Neon.

Mar 23 2020, 11:02 AM · Plasma

Mar 22 2020

romangg added a comment to D28115: feat(kded): add a dbus method to lock current rotation.

How does mobile retrieve the current lockAutoRotate value?

Mar 22 2020, 5:49 PM · Plasma
romangg accepted D28115: feat(kded): add a dbus method to lock current rotation.
Mar 22 2020, 3:29 PM · Plasma
romangg committed R110:2dd74419990a: build: ignore clang-format file (authored by romangg).
build: ignore clang-format file
Mar 22 2020, 3:19 PM