| romangg |
| Plasma |
Currently output identification uses the pending configuration to position
output ids. That can result in output ids being inverted (if you move screen
for example).
In order to fix that, we instead use the applied configuration to identify
outputs.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Seems very sensible. +1
Note that kscreen has a commit message schema different to every other KDE policy. See CONTRIBUTING.md at the root level.
Header subject and commit message body must have shorter line length in line with message guideline. Also note regarding capitalization Angular's subject guideline.
Also the current description sucks. That's a single sentence with way too many words and no grammar.
Come on, coding is not only about the code. Be proud of your work and present it to us in the way that it deserves.
Also my assumption is you work together with the original reviewers in the same company and may have discussed this patch internally already. That's fine but note that this project and any other KDE project is not owned by your company alone and it's your responsibility in the end to transform your internal discussions and the knowledge you gained from that into public knowledge available to all members of this community.
That's why a good description, and in the end all of the documentation you do when coding, is tremendously important.
I changed up the description a bit more (line length!). Please make sure to push with arc so it fetches this description for the commit message.
Code change makes sense. Thanks for the fix.