Differential D28386

fix(kded): watch config also when known config is applied
ClosedPublic
Actions

Authored by romangg on Mar 28 2020, 8:37 PM.

Details

Reviewers
bshah
Group Reviewers
Plasma
Commits
R104:3dced489d7c1: fix(kded): watch config also when known config is applied
Summary

When a known config is applied the doApplyConfig with the Config wrapper
override is called. In this case we still want to activate config watching
like when a config from the ConfigPtr override is applied.

Otherwise we are not be able to detect a control change until the first time
a new config is applied.

Test Plan

Started with rotation in manual mode. Switched in KCM only from manual to
automatic mode without changing anything else. With the patch the daemon
notices this change, without it not.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Mar 28 2020, 8:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 28 2020, 8:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Mar 28 2020, 8:37 PM
bshah accepted this revision.Mar 29 2020, 3:35 AM
bshah added a subscriber: bshah.

Makes sense

This revision is now accepted and ready to land.Mar 29 2020, 3:35 AM
Closed by commit R104:3dced489d7c1: fix(kded): watch config also when known config is applied (authored by romangg). · Explain WhyMar 30 2020, 11:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/daemon.cpp (4 lines)

Diff 78882

View Options

kded/daemon.cpp

Loading...