Is this now a bug fix or a feature? I would call it a refactor since there is no regression or prior bug and neither does it add a new feature. The feature was added in libkscreen. And please don't say refactor: fix... How about refactor: incorporate prior libkscreen EDID changes?

Fix commit message

Harbormaster completed remote builds in B23817: Diff 77830.Mar 17 2020, 2:41 PM

dvratil retitled this revision from feat: fix build after EDID changes in libkscreen to refactor: incorporate prior libkscreen EDID changes.Mar 17 2020, 2:41 PM

romangg accepted this revision.Mar 17 2020, 3:01 PM

This revision is now accepted and ready to land.Mar 17 2020, 3:01 PM

Oh, I just noticed: Please absolutely add a commit message body to this commit on push! Just a single line explaining what you do is enough.

Revision Contents
Changeset List

			Path	Packages
M			console/console.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76460	51fd586		Feb 26 2020, 12:18 PM	★	★
Diff 2	77830	b0f3fa3	* Fix commit message	Mar 17 2020, 2:41 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
760b36878274	cee392dfb0b2	b0f3fa30d427	Daniel Vrátil	refactor: incorporate prior libkscreen EDID changes (Show More…)	Feb 26 2020, 12:17 PM

Status	Author	Revision
Closed	dvratil	D10041 Decode full monitor vendor name from EDID using hwdata
Accepted	dvratil	D27675 feat: avoid duplicated text when assembling user-facing output names
Accepted	dvratil	D27677 refactor: incorporate prior libkscreen EDID changes
Accepted	dvratil	D10042 feat: parse EDID on the backend side
Closed	davidedmundson	D10040 Add serial number and EISA ID to OutputDevice interface

Diff 77830

View Options

refactor: incorporate prior libkscreen EDID changesAcceptedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 77830

console/console.cpp

refactor: incorporate prior libkscreen EDID changes
AcceptedPublic
Actions

Revision Contents
Changeset List