Differential D28217

Fix Formatter library CMake
ClosedPublic
Actions

Authored by ahiemstra on Mar 23 2020, 10:57 AM.

Details

Reviewers
romangg
Group Reviewers
Plasma
Commits
R111:7a13a67827ea: Fix Formatter library CMake
Summary

On older versions, install(TARGETS target PUBLIC_HEADER) does not seem
to work too well, so just use install(FILES) for now. In addition, the
Qml and Quick components were missing from the main CMake file.

Test Plan

Still builds and installs

Diff Detail

Repository
R111 KSysguard Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Mar 23 2020, 10:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 23 2020, 10:57 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Mar 23 2020, 10:57 AM
romangg accepted this revision.Mar 23 2020, 11:02 AM
romangg added a subscriber: romangg.

Compiles again on Neon.

CMakeLists.txt
30

Accidentally added QML and Quick?

This revision is now accepted and ready to land.Mar 23 2020, 11:02 AM
romangg added inline comments.Mar 23 2020, 11:06 AM
CMakeLists.txt
30

I removed experimentally the Qml and Quick package specifiers and it still compiled.

ahiemstra added inline comments.Mar 23 2020, 11:23 AM
CMakeLists.txt
30

It's in response to the comment here: https://phabricator.kde.org/D27869#632172

Closed by commit R111:7a13a67827ea: Fix Formatter library CMake (authored by ahiemstra). · Explain WhyMar 23 2020, 11:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Mformatter/CMakeLists.txt (7 lines)

Diff 78282

View Options

CMakeLists.txt

Loading...
View Options

formatter/CMakeLists.txt

Loading...