Populate Greeter process exit stderr
ClosedPublic

Authored by romangg on Mon, Mar 16, 7:45 PM.

Details

Summary

Give more info in debug output when and how the Greeter porcess exited and
what counter-measures are triggered to unregular exits.

Should simplify debugging.

Diff Detail

Repository
R133 KScreenLocker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Mon, Mar 16, 7:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Mar 16, 7:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Mon, Mar 16, 7:45 PM
zzag added a subscriber: zzag.Mon, Mar 16, 8:26 PM
zzag added inline comments.
ksldapp.cpp
258

Shouldn't it be in an else branch?

romangg added inline comments.Mon, Mar 16, 8:32 PM
ksldapp.cpp
258

Yes, thanks!

romangg updated this revision to Diff 77784.Mon, Mar 16, 9:49 PM

else case

romangg marked 2 inline comments as done.Mon, Mar 16, 9:50 PM
apol accepted this revision.Mon, Mar 16, 11:09 PM
This revision is now accepted and ready to land.Mon, Mar 16, 11:09 PM

Can we use categorised logging please.

But general +1

Can we use categorised logging please.

Yea, but I haven't seen any categorized logging in KScreenLocker so I opted for now with non-categorized logging as the rest of the code does. The category logging should be introduced for sure in another patch though (and then all debug messages converted to categorized logging at once).

But general +1

This revision was automatically updated to reflect the committed changes.