In T13145#230815, @davidre wrote:

Well right now you have that problem too that you can select both. Even worse both settings are on different sub pages. I would also happy to remove Copy file location to clipboard after saving but I'm not sure if it's an extensive used feature. To me seems unnecessary when we have automatic copy.

Works, but the notification is empty and the file doesn't get saved at all:

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

@davidre ping :)

Done :)

• Renaming of functions

In D29006#671172, @ngraham wrote:

Nice feature. I would rename the menu items a bit:
"Move to inactive split view"
"Copy to inactive split view"

No need to mention "the selection" because it's implicit. And I would mention that this is about the split view, or else when not using the split view feature, it's not clear how to enable the menu items. If you mention splits in the name though, it's advertising the split view feature for whose who haven't found it yet.

• Minor renaming of text and the according variables
• Merge remote-tracking branch 'origin' into arcpatch-D29006

In D29006#670660, @meven wrote:

Rather than merging master into your branches, I would recommend you rebasing ;)

In T13145#230250, @davidre wrote:

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

• Renamed to destinationUrl

• Merge branch 'master' of https://anongit.kde.org/dolphin into arcpatch-D29006
• Merge branch 'master' of https://anongit.kde.org/dolphin into arcpatch-D29006
• Rename to (copy|move)SelectedItems

In D29596#668032, @davidre wrote:

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

So I have to check this box and it is under the "When spectacle is running" section. But the image will be autosaved regardless whether the other checkbox is saved or not. I think the problem is no easy but I will try again to think of something.

In D29006#667654, @meven wrote:

In D29006#667588, @dfaure wrote:

It sounds to me like you found bugs in some kioslaves. Fixing that is out of scope for this change request. Certainly a good idea to do that, but IMHO not a blocker for this to go in.

I don't think this is a bug in any ioslave : dolphin view doesn't have this issue when copy/pasting files in , and for instance recentlyused:/ has "writing=false" and "moving=false" in its json file.
So I would guess this is not a bug there but somewhere else along the call chain. One can compare this code to DolphinContextMenu::createPasteAction that uses KIO::pasteActionText

I agree this should not keep this bug from landing.

@meven
These seem to be 'special-cases' locations.
The call to capabilitiesDestination.isWritable() :

• Rewrite so it's obvious that it is copying/moving to the inactive view

• Merge branch 'master' of https://anongit.kde.org/dolphin into arcpatch-D29006

• Merge branch 'master' of https://anongit.kde.org/dolphin into arcpatch-D29399

• Revert "Instead of append, change the value to a simplifiedUrlList"

@elvisangelaccio
copySelectedItems() is already used to copy to clipboard. See L365.

• Add check if destination is writable for copy
• Move copy/move logic to DolphinTabWidget
• Set Shift+F5/F6 instead of CTRL+F5/F6 as keyboard shortcut

In D29006#662058, @meven wrote:

Just a check to add.

In D29006#661964, @dfaure wrote:

Looks good to me.

Did you test copying and moving directories as well? Should work, but just to make sure.

I'll let the Dolphin developers/maintainers decide on whether the shortcuts are OK, and land this.

• Connect to copyingDone to update m_selectedUrls

• Instead of append, change the value to a simplifiedUrlList
• Remove 'selected' from text

Done :)

• Rename slotPasteJobResult to more generic slotJobResult
• Added error check when copying to other view

@dfaure is it good now? Anyone found anything else to fix and/or improve?

In D29006#660096, @dfaure wrote:

You can compare with what happens when doing the same invalid move using Cut / Paste for instance.

The job gives the error "A folder cannot be moved into itself" and dolphin displays this in the view.

You want to connect to the job's result() signal and emit errorMessage from the slot, like DolphinView::slotPasteJobResult does.

• Update docbook

One more fix and update.
Is it ok that nothing happens if a user wants to move a folder into one of it's subfolders?
If dolphin is launched from bash, one can see "Could not rename file /tmp/subfolder copy." if one tries to move /tmp/subfolder to /tmp/subfolder/subsub/

• Make moving only available if file is movable.
• Update docbook

In D29006#659658, @dfaure wrote:

Increase the version number at the top of dolphinui.rc
Otherwise, any user who made local changes (e.g. shortcuts) isn't getting that new version of the ui.rc file

Add functions into the Edit menu

In D29006#659534, @dfaure wrote:

Yes I'd say those should be actions in the menus otherwise the feature is too hidden.

Fix wrong naming

Changed to use KIO::copy and ::move - thanks @dfaure !
One thing, I almost forgot, what about the predefined keyboard shortcuts I've set? Keep as CTRL+F5/F6 or change to something else?

Use KIO copy and move instead of going trough the clipboard

Also what kind of file do you copy, only local right ?

Yes, local files on local ssd that are in my home directory.

In D29006#654415, @meven wrote:

In D29006#654111, @aprcela wrote:

Do I have to invoke thread apply all bt in gdb before or after I copy/move to the other view?
Tried it before, but couldn't get any info in gdb while dolphin stopped responding..

I forgot to mention : once dolphin is blocked, then type CTRL+C in your gdb terminal and them you can thread apply all bt
A step by step:

gdb dolphin

type run // will launch dolphin, do your think until things hang

type CTRL + C in your gdb terminal // to stop dolphin and switch back to gdb

type thread apply all bt

Do I have to invoke thread apply all bt in gdb before or after I copy/move to the other view?
Tried it before, but couldn't get any info in gdb while dolphin stopped responding..

• Renamed some variables and changed some text for the new functions
• Merge branch 'master' of https://anongit.kde.org/dolphin into arcpatch-D29006

Thanks for the feedback and help!

In D23366#653823, @alex wrote:

First of all this feature sounds great!

I am just a bit confused about how we define "tasks" now:
In your current implementation it looks like they should be executed after the file gets saved.

And after capture a new window appears with a bunch of options

This seems like an action gets executed after the screenshot is taken.

In D23366#653219, @ngraham wrote:

I love the idea. However is it likely that the user will always want to run the same task on every screenshot? It feels more like this should be a list of tasks, and the user should be able to choose which one to run, optionally marking one as an overridable default task.

Thoughts?

Merge and fix conflicts

In D23366#652581, @ngraham wrote:

Oh gosh, how did this get missed? Sorry about that.

I highly doubt it.
And thanks for reminding me. Will work on it in this week.

In D28790#647470, @ngraham wrote:

In D28790#647396, @aprcela wrote:

So I can disregard this and maybe change the current option "Show full path in titlebar" to only switch the full path On/Off for the window title instead of both window and tab?

Yep, makes sense to me!

In D28790#647309, @ngraham wrote:

Yeah, but we're trying to move away from that and toward having good defaults and offering only options that make sense. :)

In D28790#647213, @ngraham wrote:

I wonder... might it make sense to just always display the full path in the titlebar? And as for tab titles, does it ever make sense to display the full path there? The amount of horizontal space is very small so the path will almost always be elided away into uselessness.

Searching and debugging and I just can't find the reason why.
So currently the counter works fine when the first image of a folder is opened and THEN one goes into fullscreen. But if one goes directly into fullscreen with the first image loaded, than it sets the counter to 0.

Removed comment that was used for the timer

In D24622#548349, @ngraham wrote:

Did you mean to remove the timer in this patch?

Remove timer. Use simple method call instead.

Reverted the timer to 0.
Now it works when switching to fullscreen. Next step: make the counter work properly when -f for fullscreen is used.

Revert timer and add additional updateDocumentCountLabel call

In D24622#547028, @tommo wrote:

And if updating the current index takes longer than 250 msec it would fail again, wouldn't it?

Probably, I can't get to that case where it's so slow. But I am aware that it can happen.

Works fine. All buttons get proper focus on TAB now.

In D23446#537268, @Leon0402 wrote:

I can build it, but when I run spectacle - I get a segmentation fault. Has anyone else such a problem?
The problem seems to be in the setupShortcuts().

ofc, i commented it out just to see if it would run at all.

I'm also not experiencing this issue. Do you have the problem if you put "setupShortcuts()" to it's old position? And perhaps you could find out where execactly the setupShortcuts() method causes the problem? Maybe this gives us some hint, what might be wrong.
Obviously, if anybody else can confirm the problem that would be super helpful.

In D23446#536356, @Leon0402 wrote:

Anyone, who can review this?

In D23891#529846, @davidre wrote:

Did you test this? I think the way it was was correct. A transient window is for example a popup . Only the popup is transientOnly (capturemode window under cursor) and everything is transientwithparent. See also the help text

-u, --windowundercursor    Capture the window currently under the cursor,
                             including parents of pop-up menus
  -t, --transientonly        Capture the window currently under the cursor,
                             excluding parents of pop-up menus

and the gui version
https://cgit.kde.org/spectacle.git/tree/src/Gui/KSWidget.cpp#n217

Please revert this

In D23723#525820, @davidre wrote:

This also applies the delay of 250 ms when saving the picture not only copying. To make this better we could move this either inside the if-else above or have another test if we copied to clipboard - can't get around a bit of duplication. However this piece of code is all over the place already and I don't like the design of forceNotify and quitting through the main window. So this if fine with me if we could avoid the extra wait when saving to a file.

Edit if and add else if

Same solution as here:
https://cgit.kde.org/spectacle.git/tree/src/Gui/KSMainWindow.cpp#n399

In D19715#463799, @kdautovic wrote:

I plan on fixing this before the beta release, or at least the full release. Anyone have any ideas what might be causing this?