Do not display full path in the title of the tab
ClosedPublic

Authored by aprcela on Apr 15 2020, 3:20 PM.

Details

Summary

Displays the full path only in the window title, not in the tab title.

Screenshot for comparison: ( Dolphin on the right is without D28815 , Dolphin on left has both D28815 and this patch)

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aprcela created this revision.Apr 15 2020, 3:20 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 15 2020, 3:20 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
aprcela requested review of this revision.Apr 15 2020, 3:20 PM
aprcela edited the summary of this revision. (Show Details)Apr 15 2020, 3:22 PM
ngraham accepted this revision.Apr 15 2020, 3:33 PM
ngraham added subscribers: meven, elvisangelaccio, ngraham.

Seems perfect to me. @meven/@elvisangelaccio?

This revision is now accepted and ready to land.Apr 15 2020, 3:33 PM
meven accepted this revision.Apr 15 2020, 3:40 PM
This revision was automatically updated to reflect the committed changes.

Shouldn't we also change the description of the setting? "Show full path in title bar" should probably now become "Show full path in window title", no?

Shouldn't we also change the description of the setting? "Show full path in title bar" should probably now become "Show full path in window title", no?

That would be fine too but the existing string is accurate since the window title lives in the window's title bar. This patch actually is what makes the string accurate since previously it also controlled whether the full path was shown in the tabs, which are *not* on the title bar. No objection to your proposed change though.