Leon0402 (Leon De Andrade)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 21 2019, 3:01 PM (11 w, 5 d)
Availability
Available

Recent Activity

Sep 28 2019

Leon0402 added a comment to D23932: WIP Implement backends as plugins.

Also we are not in a situation where we have that many backends where there would be a significant impact on executable size

Sep 28 2019, 11:52 AM · Spectacle

Sep 24 2019

Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

I can build it, but when I run spectacle - I get a segmentation fault. Has anyone else such a problem?
The problem seems to be in the setupShortcuts().

ofc, i commented it out just to see if it would run at all.

Sep 24 2019, 7:19 PM · Spectacle

Sep 23 2019

Leon0402 added a comment to T11746: Make it possible to only apply certain parts of a Global Theme.

Yes, that's why it's called that way now :-)

Thanks ;) Any chance you know what exactly is set by it?

Sep 23 2019, 10:40 PM · VDG, Plasma
Leon0402 added a comment to T11746: Make it possible to only apply certain parts of a Global Theme.

Split the KCM into two KCMs: one for theme, one for desktop layout

Sep 23 2019, 5:12 PM · VDG, Plasma
Leon0402 added a comment to D23932: WIP Implement backends as plugins.

Hi there,

Sep 23 2019, 5:03 PM · Spectacle
Leon0402 updated the diff for D23932: WIP Implement backends as plugins.
  • Fixs to CMakeLists
Sep 23 2019, 4:53 PM · Spectacle
Leon0402 updated the diff for D23932: WIP Implement backends as plugins.
  • Added CaptureMode Rectangular Region
  • Moved code to determine wether the "Current Screen" CaptureMode should be shown to the comboBox
  • ComboxBox and shutter options update, when the backend changes
  • Fixed a few bugs
  • Only uses one enum now called CaptureMode, instead of two very similar enums
Sep 23 2019, 4:34 PM · Spectacle
Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

Anyone, who can review this?

Sep 23 2019, 1:31 PM · Spectacle
Leon0402 added a comment to D23687: New Bottom Help text.

Is there something holding this back to land?

Sep 23 2019, 1:29 PM · Spectacle

Sep 21 2019

Leon0402 added a comment to T10997: Improve check box design.

While I think both look quite good, I would go with the horizontal line. Our current goal is to make the look more consistent and I feel like part of this should be to respect cross de standards. And at least to me, the horizontal line seems to be the standard out there.

Sep 21 2019, 12:12 PM · VDG, Breeze
Leon0402 added a comment to T11579: Unify navigation through sidebar categories/views.

@ngraham I hope I understand you correctly. Your problem is that the actual sidebar or the side view, which comes if you click on the sidebar, takes width as well ... and therefore you don't want to waste more width, right?

Sep 21 2019, 11:55 AM · Goal: Consistency, KDE Human Interface Guidelines, VDG

Sep 20 2019

Leon0402 added a comment to T11579: Unify navigation through sidebar categories/views.

Personally, I prefer the suggestion of @felixernst with some small changes

Sep 20 2019, 11:06 PM · Goal: Consistency, KDE Human Interface Guidelines, VDG

Sep 19 2019

Leon0402 added a member for Spectacle: Leon0402.
Sep 19 2019, 4:53 PM
Leon0402 added a comment to T10243: Some KDE applications could use better icons.

Personally, I prefer branding icons much over functionality. It would be horrible if all my browsers and code editors would have the same icon. I want to know when I look in my task bar, what apps exactly I have open. Furthermore, it's always been like that ... no app on my phone or somewhere else uses a generic icon ... for good reason, I search for an app by looking at the icon and not at the text (in fact, some icons don't even have text like the icon in the bottom "favourite bar" on iOS).
Imho, a good branding icon gives some hint about the functionality as well, but it doesn't have to. And well the branding icon is designed by the application, not by breeze.

Sep 19 2019, 2:28 PM · KDE Applications, VDG
Leon0402 updated the test plan for D23932: WIP Implement backends as plugins.
Sep 19 2019, 1:53 PM · Spectacle
Leon0402 updated the diff for D23932: WIP Implement backends as plugins.
  • Use dynamic plugins instead of static plugins
  • Changed CMakeLists, so plugins will be compiled to shared libs (dymanic plugins)
  • Use json metadata
  • Improved auto selection algorithm (added "recommended" field in .json, so the algo knows, which plugin should be preferred)
  • Added runtime checks, so the plugins can check whether all requirements are fullfilled (for example if kwin is available)
  • plugins are unloaded automatically if not needed (instead of install/remove button)
  • Fixed some Bugs
Sep 19 2019, 1:50 PM · Spectacle

Sep 14 2019

Leon0402 added a comment to D23932: WIP Implement backends as plugins.

...But is this true? the feature doesn't exist yet. We have no idea whether or not it would impose overhead on Spectacle when not in use. Maybe we should implement it before designing a feature to turn it off if it has bad performance. Who knows, maybe the performance turns out to be just fine! :) I honestly have no idea how the feature could possibly cause bad performance when it's not in use. "I want to turn it off because it has bad performance" smacks of a fixable design error that should be fixed, not worked around.

Sep 14 2019, 1:20 PM · Spectacle

Sep 13 2019

Leon0402 added a comment to D23932: WIP Implement backends as plugins.

Anything requiring so technical an explanation of the options is certainly not something that should be in the UI.

That's unfair :D it's not a finished feature, it's wip , it was a technical analysis of scenarios, which should be taken into account and possible solutions (with the option to add some solutions from you or another). That doesn't make the setting complicated or anything for the user. I could explain every single revision I've done in such great detail ;)

Sep 13 2019, 10:54 PM · Spectacle
Leon0402 added a comment to D23932: WIP Implement backends as plugins.

I see your points at @ngraham and @ndavis

Sep 13 2019, 9:50 PM · Spectacle
Leon0402 updated the task description for T11655: Multiple backend support in Spectacle.
Sep 13 2019, 6:15 PM · Spectacle
Leon0402 updated the test plan for D23932: WIP Implement backends as plugins.
Sep 13 2019, 6:15 PM · Spectacle
Leon0402 added reviewers for D23932: WIP Implement backends as plugins: davidre, Spectacle, VDG.
Sep 13 2019, 6:14 PM · Spectacle
Leon0402 requested review of D23932: WIP Implement backends as plugins.
Sep 13 2019, 6:13 PM · Spectacle
Leon0402 created T11655: Multiple backend support in Spectacle.
Sep 13 2019, 5:32 PM · Spectacle

Sep 6 2019

Leon0402 added a comment to D23759: Remove unneeded media icons.

unless all icons were removed from the desktop theme (all icons would come from the icon theme)

Sep 6 2019, 5:31 PM · Frameworks

Sep 5 2019

Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

Okay I changed it in Spectacle, so in the ComboBox, Spectacle shortcut settings, global settings it displays the correct string.

Sep 5 2019, 10:26 PM · Spectacle
Leon0402 updated the diff for D23446: Shortcuts displayed in capture mode ComboBox.

Updated capture/action names (and captureMode names in enum)

Sep 5 2019, 10:20 PM · Spectacle
Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

I would like this to be more consistent as well. I suppose the best wording would be
Capture entire screen
Capture current screen

What do you think?

That sounds just fine to me . And then in the combo box, you would omit the word "Capture" (it's implied).

Sep 5 2019, 8:25 PM · Spectacle
Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

One important change with that version is that Fullscreen is called "Entire Desktop" instead.

Sep 5 2019, 6:12 PM · Spectacle
Leon0402 updated the test plan for D23446: Shortcuts displayed in capture mode ComboBox.
Sep 5 2019, 6:05 PM · Spectacle
Leon0402 updated the diff for D23446: Shortcuts displayed in capture mode ComboBox.

Changed include order

Sep 5 2019, 4:49 PM · Spectacle
Leon0402 updated the diff for D23446: Shortcuts displayed in capture mode ComboBox.
  • Improve code in various places
  • Change model to QListModel
  • Keep reference to QAction (so the texts can be updated if a shortcut changes)
  • Add captureMode as a property of QAction (setData)
Sep 5 2019, 4:41 PM · Spectacle
Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

I'm not sure about the structure of the tableModel. Thinking about it we don't really have a table structure of items but a list. Also it seems you are mixing columns an roles. Your model advertises itself with 3 columns but only has data 2 and each column in a row refers to the same item.

Sep 5 2019, 11:22 AM · Spectacle
Leon0402 updated the diff for D23687: New Bottom Help text.

Changed if condition according to David's comment

Sep 5 2019, 11:02 AM · Spectacle

Sep 4 2019

Leon0402 planned changes to D23446: Shortcuts displayed in capture mode ComboBox.
Sep 4 2019, 7:54 PM · Spectacle
Leon0402 updated the diff for D23446: Shortcuts displayed in capture mode ComboBox.
  • Removed formatting/style issues mentioned by ngraham
  • Shortcut changes no dynamically if user changes them in spectacle's or the global settings. It does't work for the fullscreen shortcut though, this needs to be fixed
Sep 4 2019, 7:52 PM · Spectacle
Leon0402 added a comment to D23687: New Bottom Help text.

Would be great if someone could check again all options make sense in the different branches and I have not deleted any useful information accidentally.

Sep 4 2019, 7:17 PM · Spectacle
Leon0402 updated the diff for D23687: New Bottom Help text.

Updated style for the other if branch

Sep 4 2019, 7:02 PM · Spectacle
Leon0402 updated the test plan for D23687: New Bottom Help text.
Sep 4 2019, 4:15 PM · Spectacle
Leon0402 added a comment to D23687: New Bottom Help text.

Alright, in terms of strings if I were to make one suggestion it'd be this:
Change the SHIFT tips to language like "(Hold SHIFT to Blah)" (e.g.: "Hold SHIFT to Magnify").

Sep 4 2019, 4:09 PM · Spectacle
Leon0402 updated the diff for D23446: Shortcuts displayed in capture mode ComboBox.

Fixed small bugs, updates now if you change global shortcuts

Sep 4 2019, 9:52 AM · Spectacle
Leon0402 updated the diff for D23687: New Bottom Help text.
  • Result is now on the left side, action on the right side
  • Mouse Actions are above Keyboard actions
  • Word fine-tune replaced by more clear explaination
Sep 4 2019, 9:39 AM · Spectacle
Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.
I don't know if it's the right metric
Sep 4 2019, 9:27 AM · Spectacle
Leon0402 added inline comments to D23446: Shortcuts displayed in capture mode ComboBox.
Sep 4 2019, 9:21 AM · Spectacle
Leon0402 updated the diff for D23446: Shortcuts displayed in capture mode ComboBox.
  • Did things David suggested in the comments
Sep 4 2019, 9:13 AM · Spectacle

Sep 3 2019

Leon0402 added a comment to D23687: New Bottom Help text.

< Also, "pixel-by-pixel" (there might be a better way to say it, maybe find it later) is better than "fine tune" because it's more accurate.

Sep 3 2019, 3:47 PM · Spectacle
Leon0402 added a comment to D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.

If we would write it in qml I would still disagree since my initial feeling how this would look like would be somehting like:

Sep 3 2019, 10:53 AM · Spectacle
Leon0402 added a comment to D23687: New Bottom Help text.

This is how it could look like. I really like it and perhaps we could add some styling to make it look better (but I'm not a designer, so perhaps someone else has a mockup for that then :P)

Sep 3 2019, 10:24 AM · Spectacle
Leon0402 added a comment to D23687: New Bottom Help text.

I just had another idea: We have multiple controls for the same action. What about switching the order of Layout around:

Sep 3 2019, 9:41 AM · Spectacle
Leon0402 added a comment to D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.

I'll try to explain what I have thought about the different things you mentioned (and hope it makes sense):

Sep 3 2019, 7:55 AM · Spectacle

Sep 2 2019

Leon0402 updated the test plan for D23687: New Bottom Help text.
Sep 2 2019, 10:06 PM · Spectacle
Leon0402 requested review of D23687: New Bottom Help text.
Sep 2 2019, 10:01 PM · Spectacle
Leon0402 updated the test plan for D23446: Shortcuts displayed in capture mode ComboBox.
Sep 2 2019, 4:31 PM · Spectacle
Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

The style should be now as normal with the right margin and selection color.
Especially getting the right margin was more difficult than expected, I figured a way out to get it, although I'm not 100% sure if that's the simplest way.

Sep 2 2019, 4:27 PM · Spectacle
Leon0402 updated the diff for D23446: Shortcuts displayed in capture mode ComboBox.
  • Added style for ComboBox from theme
  • Added logic for resizing the ComboBox View
Sep 2 2019, 4:22 PM · Spectacle
Leon0402 updated the diff for D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.
  • Works directly with the Color from the colorscheme and changes the transparency, rather than constructing a new color
  • Style is connected to a paletteChange of QGuiApplication, so that the style would be updated if the colorscheme changes (makes no difference at the moment as the Object is created new every time at the moment anyway)
Sep 2 2019, 12:14 PM · Spectacle

Aug 31 2019

Leon0402 updated the diff for D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.
  • Refactored code
  • Added licensing
  • Used QPalette instead of stylesheets
Aug 31 2019, 9:26 AM · Spectacle

Aug 27 2019

Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

Figured out with @davidre how to do get the highlighting text color (on in general the text brush) and the padding most likely:

Aug 27 2019, 7:49 AM · Spectacle

Aug 26 2019

Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

@felixernst my bad, sorry! I was only focused on the ComboBox itself and therefore overread that you were actually talking about the dropdown.

Aug 26 2019, 11:32 PM · Spectacle
Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

If the combobox's pop-up is a bit long sometime, that's not really a problem.

I actually haven't thought about that at all! I just assumed that the popup has to have the same width as the QComboBox itself. Thanks for the suggestion :)

Aug 26 2019, 11:02 PM · Spectacle
Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

@ngraham That's how it currently is. The shortcuts are only displayed in the popup, but the space there is limited. I agree with you that it should stay there and shall not be displayed in the ComboBox itself.
Unless you were talking about tooltips? Or did I misunderstand you completely?

Aug 26 2019, 4:44 PM · Spectacle
Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

@ngraham Good point, I didn't know that. What would you suggest then? It seems to me like the only way to go then is to set a width limit for the shortcuts? If a shortcut to long we could display an error message there? Something like "too long" just?

Aug 26 2019, 3:41 PM · Spectacle
Leon0402 added a comment to T10574: Make shortcuts consistent.

Personally I think it would make sense to have the same shortcut for copy and non-copy with an additional modifier.

+1

Also I am a fan of Meta + Print for taking a screenshot of the active window as it maps to the windows key on my laptop which is a great metaphor.

+1

Aug 26 2019, 9:57 AM · Spectacle
Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

I agree if the shortcut is displayed it should be displayed always

I'm not sure if you mean the same than me. I was favouring an approach, where only default shortcuts are displayed. So even if custom shortcuts were short enough, I wouldn't display them as from a user perspective it seems more reasonable to me when all my custom shortcuts are not displayed then when only a few of them are displayed and some other not (because they are too long).
I agree though, perfect would be to display all shortcuts always, but that's probably impossible -> Print+Volume Up+Volume Down ... I don't see a way to display such a long shortcut without making the shortcut incredibly wide, which would perhaps look very strange.

Aug 26 2019, 9:39 AM · Spectacle

Aug 25 2019

Leon0402 added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

Personally, I find it a very useful feature too. Especially the argument of @felixernst that there is not really a point anymore in displaying the shortcut, if the user has changed them, is quite strong. In general, we can assume that users, who change the default shortcut, are then aware of their own shortcut they set (most likely these users are also power users). Still one could argue that it might be helpful for one shortcuts as well. So there would be the possibility to display only shortcuts up to a specific width. I would rather not this though, as such an approach is not straight forward to the user and might lead to confusion and bug reports.

Aug 25 2019, 11:24 PM · Spectacle
Leon0402 awarded D23448: Capacity degradation -> Battery health a Like token.
Aug 25 2019, 6:46 PM · Plasma
Leon0402 updated the test plan for D23446: Shortcuts displayed in capture mode ComboBox.
Aug 25 2019, 6:23 PM · Spectacle
Leon0402 updated the diff for D23446: Shortcuts displayed in capture mode ComboBox.

Removed unrelated changes

Aug 25 2019, 6:20 PM · Spectacle
Leon0402 updated the test plan for D23446: Shortcuts displayed in capture mode ComboBox.
Aug 25 2019, 6:16 PM · Spectacle
Leon0402 requested review of D23446: Shortcuts displayed in capture mode ComboBox.
Aug 25 2019, 6:15 PM · Spectacle

Aug 24 2019

Leon0402 added a comment to D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.

Hi David,

Aug 24 2019, 1:35 PM · Spectacle
Leon0402 updated the diff for D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.

Code refactoring: Bottom text has own class, improving readability, better separation of position and layout -> improved performance for changing the position (screen)

Aug 24 2019, 1:16 PM · Spectacle

Aug 23 2019

Leon0402 added a comment to D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.

An idea to avoid calling layoutBottomHelpText would be to store the current screen rect as a member and only relayout if the center of the selection is outside the screen.

Yeah thought about that as well. But I suppose the screen rect is not really an attribute of that class from an OOP view. I think the actual problem is more that positioning logic has been mixed up with the logic for layouting.

Aug 23 2019, 1:00 PM · Spectacle
Leon0402 added a comment to D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.

I think it's not a problem. The default is that spectacle only remembers the old selection until it is closed. Also I would be seeing the relatively big bottom help text on one screen. And I don't really find the old rectangle I can simply start drawing a new one by clicking and dragging.

Convinced. Especially if spectacle doesn't remember the old selection on closing, my argument has no point anymore.

Aug 23 2019, 10:42 AM · Spectacle
Leon0402 updated the diff for D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.

mid help text should be displayed on right screen now: mSelection`s top left corner defaults now to the active screen`s top left corner
bottom help text should update: update() (-> paintEvent()) calls now layoutBottomHelpText

Aug 23 2019, 10:28 AM · Spectacle
Leon0402 added a comment to D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.

No it's always on the left screen. The reason is probably we call drawMidHelpText if `mSelection.size().isEmpty() .

Aug 23 2019, 9:52 AM · Spectacle
Leon0402 updated the test plan for D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.
Aug 23 2019, 9:23 AM · Spectacle

Aug 22 2019

Leon0402 updated the diff for D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.

Removed unecessary local variable

Aug 22 2019, 9:39 PM · Spectacle
Leon0402 updated the test plan for D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.
Aug 22 2019, 8:33 PM · Spectacle
Leon0402 requested review of D23362: Display help texts in "rectangular region"-mode on the right screen on mutiple screen setups.
Aug 22 2019, 8:31 PM · Spectacle
Leon0402 updated the test plan for D23322: Add new touch-friendly drag handlers.
Aug 22 2019, 5:28 PM · Spectacle
Leon0402 updated the diff for D23322: Add new touch-friendly drag handlers.

Implemented new behaviour of handlers when they touch a screen edge
Rectangle can no be resized on edges, if the rectangle is big enough (>= 100x100)

Aug 22 2019, 5:23 PM · Spectacle
Leon0402 added a comment to D23322: Add new touch-friendly drag handlers.

Okay going to implement the feature that only some of the handles move inside (and we can see then if it's worth it) and going to implement the feature that resizing work on the rectangle`s edges works as well if the rectangle is not too small.

Aug 22 2019, 2:27 PM · Spectacle
Leon0402 added a comment to D23322: Add new touch-friendly drag handlers.

This is how it would look like


or like this

Aug 22 2019, 1:52 PM · Spectacle
Leon0402 updated the diff for D23322: Add new touch-friendly drag handlers.

Temporary fix for multiple screen issue: Other parts (like the tooltip) don't handle multiple screens either. Will fix all these issue in a seperate patch

Aug 22 2019, 1:12 PM · Spectacle
Leon0402 awarded D23346: Fix Quickeditor only be shown on one screen on Wayland a Like token.
Aug 22 2019, 12:16 PM · Spectacle

Aug 21 2019

Leon0402 updated the diff for D23322: Add new touch-friendly drag handlers.

Removed unused property: Instead of a fixed size for the mouse area, it's a multiple of the handle`s size instead as it varies (touch or mouse mode)

Aug 21 2019, 9:50 PM · Spectacle
Leon0402 added a comment to D23322: Add new touch-friendly drag handlers.

@ngraham You have a 2-1 device, right? Could you please test if the the handles` radius increases as soon as you use touch and goes back to normal as soon as you use your mouse again? (change should happen on single click/touch)

Aug 21 2019, 9:09 PM · Spectacle
Leon0402 updated the diff for D23322: Add new touch-friendly drag handlers.

Added "touch-mode": Adjusts the size of the handles if touch is used

Aug 21 2019, 9:03 PM · Spectacle
Leon0402 added a comment to D23322: Add new touch-friendly drag handlers.

There is actually one "problem" I noticed. If you resize the rectangle from big to small (where the handles become free-floating), the cursor is at the end still there, where the handler should be in the normal mode. So the handler moved away from the cursor and you have to move the cursor back to the drag handler, if you want to resize the rectangle again. I'm actually not quite sure if that's a problem, but it's definitely different to how it behaved before the patch. One possible solution would be to move the cursor automatically to the drag handler it grabbed before. But it might look strange if the cursor suddenly jumps somewhere else?
Some opinions on this would be great!
@ngraham Is there a possibility to detect a touch device? If not what radius would you prefer? I also included an option to make the area, where resizing events are noticed bigger than the actual handles. At the moment the area is twice as big see "increaseDragAreaFactor". What value would you prefer for that?

Aug 21 2019, 5:23 PM · Spectacle
Leon0402 updated the test plan for D23322: Add new touch-friendly drag handlers.
Aug 21 2019, 5:10 PM · Spectacle
Leon0402 updated the test plan for D23322: Add new touch-friendly drag handlers.
Aug 21 2019, 4:44 PM · Spectacle
Leon0402 updated the diff for D23322: Add new touch-friendly drag handlers.

Removed unnecessary changes

Aug 21 2019, 4:33 PM · Spectacle
Leon0402 updated the diff for D23322: Add new touch-friendly drag handlers.

Removed unessecary changes

Aug 21 2019, 4:31 PM · Spectacle
Leon0402 requested review of D23322: Add new touch-friendly drag handlers.
Aug 21 2019, 4:09 PM · Spectacle