I wonder... might it make sense to just always display the full path in the titlebar? And as for tab titles, does it ever make sense to display the full path there? The amount of horizontal space is very small so the path will almost always be elided away into uselessness.

In D28790#647213, @ngraham wrote:

I wonder... might it make sense to just always display the full path in the titlebar? And as for tab titles, does it ever make sense to display the full path there? The amount of horizontal space is very small so the path will almost always be elided away into uselessness.

Yup, that's exactly the setup I would use. Current settings allow only "full path everywhere, or nowhere". This allows the user to set it up as they want it. Showing the full path always in the window title and tab only current folder - I'd say go for it. But would every user prefer that? And... ain't KDE famous for the overwhelming amount of options? :)

Also, is the way how I implemented this ok?

In D28790#647298, @aprcela wrote:

In D28790#647213, @ngraham wrote:

I wonder... might it make sense to just always display the full path in the titlebar? And as for tab titles, does it ever make sense to display the full path there? The amount of horizontal space is very small so the path will almost always be elided away into uselessness.

Yup, that's exactly the setup I would use. Current settings allow only "full path everywhere, or nowhere". This allows the user to set it up as they want it. Showing the full path always in the window title and tab only current folder - I'd say go for it. But would every user prefer that? And... ain't KDE famous for the overwhelming amount of options? :)

Yeah, but we're trying to move away from that and toward having good defaults and offering only options that make sense. :)

Also, is the way how I implemented this ok?

The implementation looks sane, I'm just wondering if we should instead make the tab never display the full path (because it never makes sense there) and make the option only affect the window's titlebar.

VDG folks, your thoughts?

Yeah, showing the full path in the tab makes very little sense, so we shouldn't allow it.

And -1 for adding yet another option, we already have two "Show full path" settings and that's already too much.

In D28790#647213, @ngraham wrote:

I wonder... might it make sense to just always display the full path in the titlebar?

Just about this specific part, I wouldn't recommend it, because not every path is as "user friendly" as a full local path.
There's even a bug report about it: https://bugs.kde.org/show_bug.cgi?id=406624. Example:
https://bugs.kde.org/show_bug.cgi?id=406624

Maybe the "full path" heuristics should be improved before taking that step.
This is also a problem in the history menu (which does not follow any setting and shows always a "full path")

In D28790#647309, @ngraham wrote:

Yeah, but we're trying to move away from that and toward having good defaults and offering only options that make sense. :)

Ah okay, a lil housekeeping then. Just change or remove the current option.

In D28790#647376, @elvisangelaccio wrote:

Yeah, showing the full path in the tab makes very little sense, so we shouldn't allow it.

And -1 for adding yet another option, we already have two "Show full path" settings and that's already too much.

So I can disregard this and maybe change the current option "Show full path in titlebar" to only switch the full path On/Off for the window title instead of both window and tab?

In D28790#647396, @aprcela wrote:

So I can disregard this and maybe change the current option "Show full path in titlebar" to only switch the full path On/Off for the window title instead of both window and tab?

Yep, makes sense to me!