In D23891#529846, @davidre wrote:

Did you test this? I think the way it was was correct. A transient window is for example a popup . Only the popup is transientOnly (capturemode window under cursor) and everything is transientwithparent. See also the help text

-u, --windowundercursor    Capture the window currently under the cursor,
                             including parents of pop-up menus
  -t, --transientonly        Capture the window currently under the cursor,
                             excluding parents of pop-up menus

and the gui version
https://cgit.kde.org/spectacle.git/tree/src/Gui/KSWidget.cpp#n217

Please revert this

Damn, looks like I mixed up while testing with the gui for Bug 411290.. Yeah, the way it was, is correct..
Should I revert or can ngraham undo the commit?

Will revert.

We should consider renaming the enums or serialized values or adding a comment in the code though, because the way this is written is is confusing and looks wrong (even if it's right).

In D23891#529990, @ngraham wrote:

Will revert.

We should consider renaming the enums or serialized values or adding a comment in the code though, because the way this is written is is confusing and looks wrong (even if it's right).

I don't think it was confusing in this instance there is a difference between transientonly and TransientWithParent. From the name I expect them to be different things