Regarding hamburger menus, I think Falkon/new Dolphin style is the best implementation because it gives the user the option to use the traditional menu or the hamburger menu. This is better for accessibility because people who rely on accelerators can enable a traditional menu and it ensures that the menu options will appear in the global or titlebar menu.

For now

This is kind of more like a selection icon than a No Borders icon TBH. I'm not sure if this is really more accurate than edit-none.

I think it would be better if this icon had bits in the corners like many of the existing breeze icons:

What is this icon used for?

Keep the 24px icon for now. It's in Adwaita at 24px too, so there might be some app out there that uses 24px icons. When the repo is setup to generate 24px icons at build time, then we can remove all of the 24px icons. If you need to update it to match the 22px version, just copy the 22px icon, open it in a text editor, change the viewbox or document height/width to 24x24, then group the shapes:

+1. Not sure about the icon choice for No Borders, but I don't have any better ideas.

I think we should still have 24px icons for compatibility, but since they're exactly the same as the 22px icons with wider margins, it might be better to generate 24px icons at build time.

In D23761#526874, @ngraham wrote:

While you're at it, we should auto-generate the dark monochrome versions at build-time. There's no good reason to duplicate all of them with only a single difference (changing the text in the stylesheet)

In D23761#526872, @ngraham wrote:

This is one of those monochrome action icons that happens to have a 24px version. The 24px version also has a small bug: the horizontal line at the bottom goes a bit too far into the area claimed by the clock emblem.

I can fix that too, or we could delete the 24px versions for simplicity's sake.

In D23712#526826, @trickyricky26 wrote:

I love this patch, however I am curious as to why you moved the sidebar to the bottom.
Judging from your screenshot, it results in quite a bit of empty horizontal space.
Conceptually I think it is nicer to have the scrollable view go to the bottom of the window and have the details of the selected item be shown in a sidebar.

In D23759#526814, @broulik wrote:

-1 we've had do much trouble when we touched media icons last, and still get bug reports about "missing icons" so i prefer not touching them again for no good reason.

In D23757#526812, @ngraham wrote:

Right now it's always in its own single-item group, which looks bad IMO. Open to suggestions.

In D23760#526835, @meven wrote:

Also it seems to me the icon is not very similar to

The thickness of the clock pen in particular.
They should be somewhat reminiscent of one another IMHO.

Use this 16px icon. It's more similar to the style of the 22px icon.

In D23754#526703, @ngraham wrote:

Alternatively, we could get a large colorful version of view-preview in the Breeze Icon theme.

Why is add to places grouped with paste?

In D23759#526784, @Leon0402 wrote:

unless all icons were removed from the desktop theme (all icons would come from the icon theme)

What's the drawback with that? That not every icon theme has all icons?

A few things to consider:

In T10273#198113, @onvitaik wrote:

Might not be the most appropriate place or time to ask this, but considering how the KCM title is shown on the title bar and on the side bar, isn't it unnecessary to have a header that pretty much says the same thing a third time?

+1

Never mind, a KWin rule I had was messing things up. You're good to go.

This doesn't seem to do anything, unless I'm testing the wrong thing.
KInfocenter with main page selected:

We're supposed to use 6px margins on the top and bottom, making the visible part of the icon 52px tall. Bottom line shadows are normally supposed to be 1px tall. Other than that, it looks pretty good.

In D23389#521614, @ngraham wrote:

Here are some more UI possibilities I've been thinking of:

• Instead of using pushbuttons, make them checkable toggle buttons, with the checked one being default

In D23685#525085, @ngraham wrote:

Actually, that's a great point. The current red appearance is indeed a constant annoyance to me and makes me want to keep it empty all the time, which, now that I think about it, defeats the whole point of the trash.

Let's go with this in its current state.

Also, "pixel-by-pixel" (there might be a better way to say it, maybe find it later) is better than "fine tune" because it's more accurate.

In D23687#524929, @Leon0402 wrote:

This is how it could look like. I really like it and perhaps we could add some styling to make it look better (but I'm not a designer, so perhaps someone else has a mockup for that then :P)

In D23685#525072, @ngraham wrote:

All right, let's scratch that. Maybe put a black trashbag on the ground on front of it? And add banana peels and buzzing flies! Make it really obvious that someone needs to take out the trash. :)

I just realized that the full icon is used when the trash has anything in it and not when it's full. Is this intentional?

Yeah. The full state is used when there's anything at all in the trash, not when it's actually full.

Looks like you've got everything

Move color preference clapper to center

In D23685#524775, @ngraham wrote:

Yay real trashcans!!!! The appearance is definitely more appropriate compared to before. I really like it.

However I'm afraid the visual recognizability of the full state compared to the empty state is worsened compared to the status quo

You're getting there.

Add breeze dark icons

Add breeze dark icons

I could use a modified version of the KAlarm systray icon

In D23627#523987, @ngraham wrote:

I kinda like the off-center clapper, but I understand how it might drive OCD people mildly insane. :) However the full-color icon theme notification preferences icon has an off-center clapper, so I think if we're going to make that change here, we need to do it there too.

Having said this, a centered clapper looks a bit odd to me. I wonder... so we even need it at all? The bell is still plenty recognizable as a bell without it. Maybe experiment with removing it entirely?

That's some nice consistent spacing. Does it get the icons from the desktop theme? If so, I could add some additional sizes so that it doesn't look as blurry.

@cblack thoughts?

In R98:523249683744d533570fd12730ee2b0be6c5ed90#3816152, @freeno wrote:

The script no longer installs my themes into /.local/share/themes after the latest commit. I get this error and the older version works fine. "cp: cannot create directory '': No such file or directory". The theme is there but my gtk's are missing the title buttons. I finally got it to make the theme by adding -t with the name but it made it in the same folder as script and it did not color the new assets.

In D23464#522459, @alexde wrote:

In D23464#522270, @trickyricky26 wrote:

As @noahdvs mentioned above, the white background should be removed and the entire symbol should be made up of one filled path with no outline (!). This is important to keep the icon looking as intended with the Qt SVG renderer

He mentioned that the white background should be removed. He did not mention, that it should be made up of one filled path with no outline. ;-)

As for the 32px and 64px designs, I would much prefer using only two colors by placing white variants of the smaller icons on top of a blue document background.
I think this fits much better with other Breeze mimetype icons.

ndavis saw this differently:

In D23464#521662, @ndavis wrote:

I think we should use #1ed4e5 for the color instead since that's what the official logo uses. Normally, I'd say to use a similar Breeze-like color, but mimetype icons are a mess anyway and I don't think it's worth worrying too much about unless Breeze's official color palette is expanded.

If we go with your suggestion, I think the outer ring should be dropped completely as it distracts more from the root / original branding than it benefits IMHO, like that:

It looks "Breezie" to me. :)

I think we should use #1ed4e5 for the color instead since that's what the official logo uses. Normally, I'd say to use a similar Breeze-like color, but mimetype icons are a mess anyway and I don't think it's worth worrying too much about unless Breeze's official color palette is expanded.

LGTM

In D23547#521618, @cblack wrote:

In D23547#521615, @ndavis wrote:

I should have been more clear, but I meant all of the checkbox and radio button SVGs. The SVGs I provided just did the most difficult changes and could be reused to create the other versions. The Window buttons should go back to being 18px.

Ok, I'll make the other SVGs as well.

I'll change the window buttons in a seperate revision.

I should have been more clear, but I meant all of the checkbox and radio button SVGs. The SVGs I provided just did the most difficult changes and could be reused to create the other versions.