Differential D23754

Use all colorful icons in config window's sidebar
ClosedPublic
Actions

Authored by ngraham on Sep 6 2019, 3:00 PM.

Details

Reviewers
None
Group Reviewers
VDG
Maniphest Tasks
T10165: Large category icons should all be colorful
Commits
R260:4c95041c07b2: Use all colorful icons in config window's sidebar
Test Plan

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Sep 6 2019, 3:00 PM
Restricted Application added a project: Gwenview. · View Herald TranscriptSep 6 2019, 3:00 PM
ngraham requested review of this revision.Sep 6 2019, 3:00 PM
ngraham added a comment.Sep 6 2019, 3:01 PM

Alternatively, we could get a large colorful version of view-preview in the Breeze Icon theme.

ndavis added a subscriber: ndavis.Sep 6 2019, 7:05 PM
In D23754#526703, @ngraham wrote:

Alternatively, we could get a large colorful version of view-preview in the Breeze Icon theme.

I could do that

ngraham added a comment.Sep 6 2019, 7:33 PM

Go right ahead if you want. There's no particular rush.

ngraham added a comment.Sep 10 2019, 1:17 PM

I'm going to land this now because I think the proposed new icon is sufficient. If we get a larger colorful version of view-preview we can always switch back to that.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 10 2019, 1:21 PM
Closed by commit R260:4c95041c07b2: Use all colorful icons in config window's sidebar (authored by ngraham). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/configdialog.cpp (2 lines)

Diff 65747

View Options

app/configdialog.cpp

Loading...