Add "edit-none-border" icon
AbandonedPublic

Authored by GB_2 on Sep 8 2019, 7:26 AM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Summary


For D23779.

Test Plan

Search for edit-none-border in Cuttlefish.

Diff Detail

Repository
R266 Breeze Icons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16244
Build 16262: arc lint + arc unit
GB_2 created this revision.Sep 8 2019, 7:26 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 8 2019, 7:26 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
GB_2 requested review of this revision.Sep 8 2019, 7:26 AM
broulik added a subscriber: broulik.Sep 8 2019, 8:33 AM

Shouldn't it be "edit-border-none"?

GB_2 added a comment.Sep 8 2019, 8:34 AM

Shouldn't it be "edit-border-none"?

No, then it doesn't fall back to edit-none.

On one hand I kind of agree with @kbroulik about the name choice, but on the other hand the fallback seems appropriate too.

ndavis added a subscriber: ndavis.Sep 8 2019, 10:08 AM

What is this icon used for?

What is this icon used for?

@GB_2 used it here: https://phabricator.kde.org/D23779#527639. It is used for the KWin no window border context menu entry.

GB_2 added a comment.Sep 8 2019, 11:00 AM

The fallback is needed, because Plasma 5.17 depends on Frameworks 5.62, which was already tagged and edit-none was the best fallback I could find.

ndavis requested changes to this revision.EditedSep 8 2019, 11:45 AM

I think it would be better if this icon had bits in the corners like many of the existing breeze icons:

Here's an example of the look I'm thinking of:

This revision now requires changes to proceed.Sep 8 2019, 11:45 AM

This is kind of more like a selection icon than a No Borders icon TBH. I'm not sure if this is really more accurate than edit-none.

GB_2 added a comment.EditedSep 8 2019, 12:07 PM

This is kind of more like a selection icon than a No Borders icon TBH. I'm not sure if this is really more accurate than edit-none.

Yeah, maybe it's best if we just use that. I'll keep the edit-none-border in the code in case someone wants to make an icon for it in Breeze or another icon theme.

GB_2 abandoned this revision.Sep 8 2019, 12:08 PM
In D23782#527560, @GB_2 wrote:

No, then it doesn't fall back to edit-none.

Alright, makes sense.

I kinda liked the originally proposed icon IMO. :)