Differential D23779

Make KWin action menu consistent with task manager, use action verbs for configure items and add more icons
ClosedPublic
Actions

Authored by GB_2 on Sep 7 2019, 10:07 PM.

Tags

Subscribers

trickyricky26, davidedmundson, ndavis and 3 others

Details

Reviewers

ndavis
davidedmundson

Group Reviewers

KWin
VDG

Commits

R108:37700113b204: Make KWin action menu consistent with task manager, use action verbs for…

Summary

Test Plan

Open the context menu for a window (Alt+F3).

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

GB_2 created this revision.Sep 7 2019, 10:07 PM

Restricted Application added a project: KWin. · View Herald TranscriptSep 7 2019, 10:07 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

GB_2 requested review of this revision.Sep 7 2019, 10:07 PM

Harbormaster completed remote builds in B16235: Diff 65609.Sep 7 2019, 10:07 PM

Make more changes

Harbormaster completed remote builds in B16236: Diff 65610.Sep 7 2019, 10:08 PM

Don't change "All Activities" mnemonic

Harbormaster completed remote builds in B16237: Diff 65611.Sep 7 2019, 10:14 PM

+1. Not sure about the icon choice for No Borders, but I don't have any better ideas.

This revision is now accepted and ready to land.Sep 7 2019, 11:12 PM

Use edit-none-border (edit-none will be the fallback).

Harbormaster completed remote builds in B16242: Diff 65633.Sep 8 2019, 7:21 AM

edit-none-borders -> edit-none-border

Harbormaster completed remote builds in B16243: Diff 65634.Sep 8 2019, 7:23 AM

GB_2 mentioned this in D23782: Add "edit-none-border" icon.Sep 8 2019, 7:26 AM

Keeping them in sync makes sense. +++

My comment applies to both here and taskmanager. I'd like you to have a brainstorm on that.

useractions.cpp
653	I don't like this one as the behaviour doesn't "move" the window.

GB_2 added inline comments.Sep 8 2019, 8:20 AM

useractions.cpp
653	Yeah, "Show in Activities" is more accurate. I'll change it to that.

"Move to Activity" -> "Show in Activities"

Harbormaster completed remote builds in B16246: Diff 65637.Sep 8 2019, 8:32 AM

GB_2 marked 2 inline comments as done.Sep 8 2019, 8:37 AM

GB_2 edited the summary of this revision. (Show Details)Sep 8 2019, 8:46 AM

Closed by commit R108:37700113b204: Make KWin action menu consistent with task manager, use action verbs for… (authored by GB_2). · Explain WhySep 8 2019, 8:47 AM

This revision was automatically updated to reflect the committed changes.

GB_2 mentioned this in D23785: Rename activities context menu item in task manager to "Show in Activities".Sep 8 2019, 8:56 AM

trickyricky26 added a subscriber: trickyricky26.Sep 8 2019, 10:32 AM

trickyricky26 added inline comments.

useractions.cpp
291	If I'm not mistaken, this icon is currently not in the Breeze icon theme and is added in D23782. Not sure if this should have been used here already, but adding this comment for reference in D23782.

GB_2 mentioned this in R119:b411c132d77b: Rename activities context menu item in task manager to "Show in Activities".Sep 8 2019, 10:57 AM

GB_2 added inline comments.Sep 8 2019, 10:59 AM

useractions.cpp
291	It currently falls back to `edit-none` thanks to the name. If an entirely different icon should be used I can make a new commit or patch.

Revision Contents
Changeset List

			Path	Packages
M			useractions.h (4 lines)
M			useractions.cpp (50 lines)

Diff 65640

useractions.h

Loading...

useractions.cpp

Loading...